Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/16773/?format=api
{ "id": 16773, "url": "https://patchwork.libcamera.org/api/1.1/covers/16773/?format=api", "web_url": "https://patchwork.libcamera.org/cover/16773/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220726124549.1646-1-naush@raspberrypi.com>", "date": "2022-07-26T12:45:32", "name": "[libcamera-devel,00/17] Raspberry Pi IPA code refactor", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/16773/mbox/", "series": [ { "id": 3325, "url": "https://patchwork.libcamera.org/api/1.1/series/3325/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3325", "date": "2022-07-26T12:45:32", "name": "Raspberry Pi IPA code refactor", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3325/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/16773/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61928C3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 26 Jul 2022 12:45:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3012A63313;\n\tTue, 26 Jul 2022 14:45:57 +0200 (CEST)", "from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4351F60487\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Jul 2022 14:45:55 +0200 (CEST)", "by mail-wr1-x42c.google.com with SMTP id b26so20016475wrc.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Jul 2022 05:45:55 -0700 (PDT)", "from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\ty17-20020adfd091000000b0021e87ec980bsm5948460wrh.84.2022.07.26.05.45.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 26 Jul 2022 05:45:53 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658839557;\n\tbh=ySe/VCmyycpDktyOORKb/CZMYVDptVXg8kKGG4Qzfzg=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=xEViQ4pIDqMvJMoJWUAq0eIDf5Qv/KFNbCg5j8fhojzaoQWdVpGiBXA7UoaPhxRvA\n\tLQxnZ8XyVHLRyy5bKl7HiCgPwYUiOU2+IONsM4XDzbIUMaMRtH/e6QMObQzPI8aSig\n\t9PJmeNskDxoUYBy2P/xBVBzRyknTd8EZLOXCk9NoUxpoOD02gKob9Y8M5lZ/y6p/Iv\n\tYe2V+8lsn/iWAZ7yGCqWRtHceXwCD2MU0kjpjq2Fs8Ad7Zse+4/XGUiO7dcbh24yl0\n\tHfK2VH31rqU6LYavjhMWFJaHn/6zFH95uS+HAdmPn7zaNuGc9IXOCXRPrwAflZOcss\n\txf1HxRTr7n6Ow==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=qFSnn1lOseMMM63Y6lYck9mORwJfXdPXUUyhmrn9ZZM=;\n\tb=bydZ/SLJKOr9Nk9vauFsXTh5XKPC3p0lzgnapp/eGrt18H4VNXMfU4oKQ1YONTGApg\n\tpOLnDHH/fG3H3X4HRGW5R2Wp0ATJ1dqJ/s4daNsMs8/b/s5gTKe1u/qrcQ/pLCWdQv9X\n\tq3//jhfqsNNkJTK2Uo1ZFcQ99db2jXkBQg7e/iIgAbVO8XK/utZDVmsp89vxxwbi6gnD\n\tTyFtvMZ5aSqTUprVZvR+aR6kxfAnHEyodJI+ZaJu7pdLoJN7Wdxe+T0XzZbuieRIMWsO\n\tBF3iWQF9ar/D8xjIRqC91RQPbNaxOfZ91pzoCpizP/B6HzGsxIR3kX5DTMdTR2RBX1mJ\n\t/DYw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"bydZ/SLJ\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=qFSnn1lOseMMM63Y6lYck9mORwJfXdPXUUyhmrn9ZZM=;\n\tb=GPFSI/icb0sae5bn7u4VoQhnMVxtjxvoauXb1ucv3YXrFasruWXvdS/yKRQnucFY+L\n\tH9qE+mFbsXqAg/4zpkgvXrUJVKZ4ItwqnJnue8mf/tFTjy4oEQA8UjkuMgaH/Gkcp6OQ\n\tHNEKzYavW+uxIlnqJEnNhriPNndWdtz5yO1V0lcRVRQ/fyM22pOCLtzwH5snB3LEANho\n\tV6xccru+CP4665wyd1+72K1qvAWKMA8BEfb4fVDdsSA94BmWqo+ksQ+zahl2WYz+KCHC\n\t71+SNOlLXGYlqGnaRv27b31dnCEZuQind1velRZNIc3xeHsL6qj02ID4Wb1SeK0Wv1Gx\n\tMSnQ==", "X-Gm-Message-State": "AJIora/mS+pHkUbVbRPjT2hSVcyab6SIyRpFzBsqurlvFUZbXjXyT5uq\n\tRt5bFYsKzohAoCRcy5obf2GqKyXQzdkzoQ==", "X-Google-Smtp-Source": "AGRyM1s9pauBHh4aPW2Y/22SLUcIpWfE6+V7gShbjpP8O/eIGIlJeDhlrb7uc8Ywv2zl4uPHi9vqHQ==", "X-Received": "by 2002:a5d:64e2:0:b0:21d:38e8:2497 with SMTP id\n\tg2-20020a5d64e2000000b0021d38e82497mr10020384wri.142.1658839554469; \n\tTue, 26 Jul 2022 05:45:54 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 Jul 2022 13:45:32 +0100", "Message-Id": "<20220726124549.1646-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 00/17] Raspberry Pi IPA code refactor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi,\n\nHere is the next version of the large scale refactoring of the Raspberry Pi IPA\nsource files.\n\nThis revision fixes all the points rased by Laurent - BTWthanks for the review,\nI know how tedious it would have been. I've also added 2 additional patches:\n\n16/17 - Removing #define constants and replacing with constexpr.\n17/17 - Fixed log prefix for AGC logging.\n\nI did come across one tiny typo in the AGC refactoring that is fixed.\n\nThanks,\nNaush\n\nNaushir Patuck (17):\n DNI: ipa: raspberrypi: Code refactoring to match style guidelines\n DNI: ipa: raspberrypi: Code refactoring to match style guidelines\n DNI: ipa: raspberrypi: Code refactoring to match style guidelines\n DNI: ipa: raspberrypi: Code refactoring to match style guidelines\n DNI: ipa: raspberrypi: Code refactoring to match style guidelines\n DNI: ipa: raspberrypi: Code refactoring to match style guidelines\n DNI: ipa: raspberrypi: Code refactoring to match style guidelines\n DNI: ipa: raspberrypi: Code refactoring to match style guidelines\n DNI: ipa: raspberrypi: Code refactoring to match style guidelines\n DNI: ipa: raspberrypi: Code refactoring to match style guidelines\n ipa: raspberrypi: Change to C style code comments\n ipa: raspberrypi: Remove extern \"C\" declarations\n ipa: raspberrypi: Rename header files from *.hpp to *.h\n raspberrypi: Update Copyright statement in all Raspberry Pi source\n files\n ipa: raspberryip: Remove all exception throw statements\n ipa: raspberrypi: Remove #define constants\n ipa: raspberrypi: agc: Fix log message prefixes\n\n .reuse/dep5 | 2 +-\n include/libcamera/color_space.h | 2 +-\n include/libcamera/internal/bayer_format.h | 2 +-\n include/libcamera/internal/delayed_controls.h | 2 +-\n include/libcamera/internal/v4l2_pixelformat.h | 2 +-\n include/libcamera/transform.h | 2 +-\n include/linux/bcm2835-isp.h | 2 +-\n src/cam/stream_options.cpp | 2 +-\n src/cam/stream_options.h | 2 +-\n src/ipa/libipa/histogram.cpp | 2 +-\n src/ipa/libipa/histogram.h | 2 +-\n src/ipa/raspberrypi/cam_helper.cpp | 94 +-\n src/ipa/raspberrypi/cam_helper.h | 127 ++\n src/ipa/raspberrypi/cam_helper.hpp | 123 --\n src/ipa/raspberrypi/cam_helper_imx219.cpp | 40 +-\n src/ipa/raspberrypi/cam_helper_imx290.cpp | 36 +-\n src/ipa/raspberrypi/cam_helper_imx296.cpp | 28 +-\n src/ipa/raspberrypi/cam_helper_imx477.cpp | 78 +-\n src/ipa/raspberrypi/cam_helper_imx519.cpp | 76 +-\n src/ipa/raspberrypi/cam_helper_ov5647.cpp | 48 +-\n src/ipa/raspberrypi/cam_helper_ov9281.cpp | 32 +-\n .../raspberrypi/controller/agc_algorithm.h | 31 +\n .../raspberrypi/controller/agc_algorithm.hpp | 32 -\n src/ipa/raspberrypi/controller/agc_status.h | 48 +-\n src/ipa/raspberrypi/controller/algorithm.cpp | 26 +-\n src/ipa/raspberrypi/controller/algorithm.h | 64 +\n src/ipa/raspberrypi/controller/algorithm.hpp | 60 -\n src/ipa/raspberrypi/controller/alsc_status.h | 26 +-\n .../raspberrypi/controller/awb_algorithm.h | 23 +\n .../raspberrypi/controller/awb_algorithm.hpp | 23 -\n src/ipa/raspberrypi/controller/awb_status.h | 24 +-\n .../controller/black_level_status.h | 18 +-\n src/ipa/raspberrypi/controller/camera_mode.h | 56 +-\n .../raspberrypi/controller/ccm_algorithm.h | 21 +\n .../raspberrypi/controller/ccm_algorithm.hpp | 21 -\n src/ipa/raspberrypi/controller/ccm_status.h | 12 +-\n .../controller/contrast_algorithm.h | 22 +\n .../controller/contrast_algorithm.hpp | 22 -\n .../raspberrypi/controller/contrast_status.h | 20 +-\n src/ipa/raspberrypi/controller/controller.cpp | 86 +-\n src/ipa/raspberrypi/controller/controller.h | 58 +\n src/ipa/raspberrypi/controller/controller.hpp | 54 -\n ...oise_algorithm.hpp => denoise_algorithm.h} | 12 +-\n .../raspberrypi/controller/denoise_status.h | 16 +-\n .../raspberrypi/controller/device_status.cpp | 20 +-\n .../raspberrypi/controller/device_status.h | 18 +-\n src/ipa/raspberrypi/controller/dpc_status.h | 14 +-\n src/ipa/raspberrypi/controller/focus_status.h | 20 +-\n src/ipa/raspberrypi/controller/geq_status.h | 12 +-\n src/ipa/raspberrypi/controller/histogram.cpp | 46 +-\n src/ipa/raspberrypi/controller/histogram.h | 48 +\n src/ipa/raspberrypi/controller/histogram.hpp | 44 -\n src/ipa/raspberrypi/controller/lux_status.h | 28 +-\n .../controller/{metadata.hpp => metadata.h} | 40 +-\n src/ipa/raspberrypi/controller/noise_status.h | 16 +-\n src/ipa/raspberrypi/controller/pwl.cpp | 174 +--\n src/ipa/raspberrypi/controller/pwl.h | 126 ++\n src/ipa/raspberrypi/controller/pwl.hpp | 112 --\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 1047 +++++++++--------\n src/ipa/raspberrypi/controller/rpi/agc.h | 141 +++\n src/ipa/raspberrypi/controller/rpi/agc.hpp | 139 ---\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 860 +++++++-------\n src/ipa/raspberrypi/controller/rpi/alsc.h | 110 ++\n src/ipa/raspberrypi/controller/rpi/alsc.hpp | 106 --\n src/ipa/raspberrypi/controller/rpi/awb.cpp | 770 ++++++------\n src/ipa/raspberrypi/controller/rpi/awb.h | 193 +++\n src/ipa/raspberrypi/controller/rpi/awb.hpp | 179 ---\n .../controller/rpi/black_level.cpp | 46 +-\n .../raspberrypi/controller/rpi/black_level.h | 30 +\n .../controller/rpi/black_level.hpp | 30 -\n src/ipa/raspberrypi/controller/rpi/ccm.cpp | 117 +-\n .../controller/rpi/{ccm.hpp => ccm.h} | 24 +-\n .../raspberrypi/controller/rpi/contrast.cpp | 206 ++--\n src/ipa/raspberrypi/controller/rpi/contrast.h | 52 +\n .../raspberrypi/controller/rpi/contrast.hpp | 50 -\n src/ipa/raspberrypi/controller/rpi/dpc.cpp | 34 +-\n src/ipa/raspberrypi/controller/rpi/dpc.h | 32 +\n src/ipa/raspberrypi/controller/rpi/dpc.hpp | 32 -\n src/ipa/raspberrypi/controller/rpi/focus.cpp | 18 +-\n .../controller/rpi/{focus.hpp => focus.h} | 12 +-\n src/ipa/raspberrypi/controller/rpi/geq.cpp | 64 +-\n src/ipa/raspberrypi/controller/rpi/geq.h | 34 +\n src/ipa/raspberrypi/controller/rpi/geq.hpp | 34 -\n src/ipa/raspberrypi/controller/rpi/lux.cpp | 90 +-\n src/ipa/raspberrypi/controller/rpi/lux.h | 45 +\n src/ipa/raspberrypi/controller/rpi/lux.hpp | 43 -\n src/ipa/raspberrypi/controller/rpi/noise.cpp | 64 +-\n src/ipa/raspberrypi/controller/rpi/noise.h | 32 +\n src/ipa/raspberrypi/controller/rpi/noise.hpp | 32 -\n src/ipa/raspberrypi/controller/rpi/sdn.cpp | 50 +-\n src/ipa/raspberrypi/controller/rpi/sdn.h | 32 +\n src/ipa/raspberrypi/controller/rpi/sdn.hpp | 32 -\n .../raspberrypi/controller/rpi/sharpen.cpp | 72 +-\n src/ipa/raspberrypi/controller/rpi/sharpen.h | 34 +\n .../raspberrypi/controller/rpi/sharpen.hpp | 34 -\n .../controller/sharpen_algorithm.h | 21 +\n .../controller/sharpen_algorithm.hpp | 21 -\n .../raspberrypi/controller/sharpen_status.h | 22 +-\n .../{md_parser.hpp => md_parser.h} | 50 +-\n src/ipa/raspberrypi/md_parser_smia.cpp | 112 +-\n src/ipa/raspberrypi/raspberrypi.cpp | 294 ++---\n src/libcamera/bayer_format.cpp | 2 +-\n src/libcamera/color_space.cpp | 2 +-\n src/libcamera/delayed_controls.cpp | 2 +-\n .../pipeline/raspberrypi/dma_heaps.cpp | 2 +-\n .../pipeline/raspberrypi/dma_heaps.h | 2 +-\n .../pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n .../pipeline/raspberrypi/rpi_stream.cpp | 2 +-\n .../pipeline/raspberrypi/rpi_stream.h | 2 +-\n src/libcamera/transform.cpp | 2 +-\n src/libcamera/v4l2_pixelformat.cpp | 2 +-\n src/qcam/dng_writer.cpp | 2 +-\n src/qcam/dng_writer.h | 2 +-\n utils/raspberrypi/ctt/ctt.py | 2 +-\n utils/raspberrypi/ctt/ctt_alsc.py | 2 +-\n utils/raspberrypi/ctt/ctt_awb.py | 2 +-\n utils/raspberrypi/ctt/ctt_ccm.py | 2 +-\n utils/raspberrypi/ctt/ctt_geq.py | 2 +-\n utils/raspberrypi/ctt/ctt_image_load.py | 2 +-\n utils/raspberrypi/ctt/ctt_lux.py | 2 +-\n utils/raspberrypi/ctt/ctt_macbeth_locator.py | 2 +-\n utils/raspberrypi/ctt/ctt_noise.py | 2 +-\n .../raspberrypi/ctt/ctt_pretty_print_json.py | 2 +-\n utils/raspberrypi/ctt/ctt_ransac.py | 2 +-\n utils/raspberrypi/ctt/ctt_tools.py | 2 +-\n 125 files changed, 3874 insertions(+), 3811 deletions(-)\n create mode 100644 src/ipa/raspberrypi/cam_helper.h\n delete mode 100644 src/ipa/raspberrypi/cam_helper.hpp\n create mode 100644 src/ipa/raspberrypi/controller/agc_algorithm.h\n delete mode 100644 src/ipa/raspberrypi/controller/agc_algorithm.hpp\n create mode 100644 src/ipa/raspberrypi/controller/algorithm.h\n delete mode 100644 src/ipa/raspberrypi/controller/algorithm.hpp\n create mode 100644 src/ipa/raspberrypi/controller/awb_algorithm.h\n delete mode 100644 src/ipa/raspberrypi/controller/awb_algorithm.hpp\n create mode 100644 src/ipa/raspberrypi/controller/ccm_algorithm.h\n delete mode 100644 src/ipa/raspberrypi/controller/ccm_algorithm.hpp\n create mode 100644 src/ipa/raspberrypi/controller/contrast_algorithm.h\n delete mode 100644 src/ipa/raspberrypi/controller/contrast_algorithm.hpp\n create mode 100644 src/ipa/raspberrypi/controller/controller.h\n delete mode 100644 src/ipa/raspberrypi/controller/controller.hpp\n rename src/ipa/raspberrypi/controller/{denoise_algorithm.hpp => denoise_algorithm.h} (53%)\n create mode 100644 src/ipa/raspberrypi/controller/histogram.h\n delete mode 100644 src/ipa/raspberrypi/controller/histogram.hpp\n rename src/ipa/raspberrypi/controller/{metadata.hpp => metadata.h} (61%)\n create mode 100644 src/ipa/raspberrypi/controller/pwl.h\n delete mode 100644 src/ipa/raspberrypi/controller/pwl.hpp\n create mode 100644 src/ipa/raspberrypi/controller/rpi/agc.h\n delete mode 100644 src/ipa/raspberrypi/controller/rpi/agc.hpp\n create mode 100644 src/ipa/raspberrypi/controller/rpi/alsc.h\n delete mode 100644 src/ipa/raspberrypi/controller/rpi/alsc.hpp\n create mode 100644 src/ipa/raspberrypi/controller/rpi/awb.h\n delete mode 100644 src/ipa/raspberrypi/controller/rpi/awb.hpp\n create mode 100644 src/ipa/raspberrypi/controller/rpi/black_level.h\n delete mode 100644 src/ipa/raspberrypi/controller/rpi/black_level.hpp\n rename src/ipa/raspberrypi/controller/rpi/{ccm.hpp => ccm.h} (68%)\n create mode 100644 src/ipa/raspberrypi/controller/rpi/contrast.h\n delete mode 100644 src/ipa/raspberrypi/controller/rpi/contrast.hpp\n create mode 100644 src/ipa/raspberrypi/controller/rpi/dpc.h\n delete mode 100644 src/ipa/raspberrypi/controller/rpi/dpc.hpp\n rename src/ipa/raspberrypi/controller/rpi/{focus.hpp => focus.h} (59%)\n create mode 100644 src/ipa/raspberrypi/controller/rpi/geq.h\n delete mode 100644 src/ipa/raspberrypi/controller/rpi/geq.hpp\n create mode 100644 src/ipa/raspberrypi/controller/rpi/lux.h\n delete mode 100644 src/ipa/raspberrypi/controller/rpi/lux.hpp\n create mode 100644 src/ipa/raspberrypi/controller/rpi/noise.h\n delete mode 100644 src/ipa/raspberrypi/controller/rpi/noise.hpp\n create mode 100644 src/ipa/raspberrypi/controller/rpi/sdn.h\n delete mode 100644 src/ipa/raspberrypi/controller/rpi/sdn.hpp\n create mode 100644 src/ipa/raspberrypi/controller/rpi/sharpen.h\n delete mode 100644 src/ipa/raspberrypi/controller/rpi/sharpen.hpp\n create mode 100644 src/ipa/raspberrypi/controller/sharpen_algorithm.h\n delete mode 100644 src/ipa/raspberrypi/controller/sharpen_algorithm.hpp\n rename src/ipa/raspberrypi/{md_parser.hpp => md_parser.h} (75%)" }