Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/16482/?format=api
{ "id": 16482, "url": "https://patchwork.libcamera.org/api/1.1/covers/16482/?format=api", "web_url": "https://patchwork.libcamera.org/cover/16482/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220630143543.39599-1-dse@thaumatec.com>", "date": "2022-06-30T14:35:35", "name": "[libcamera-devel,0/8] ipa: rkisp1: Add autofocus algorithm", "submitter": { "id": 126, "url": "https://patchwork.libcamera.org/api/1.1/people/126/?format=api", "name": "Daniel Semkowicz", "email": "dse@thaumatec.com" }, "mbox": "https://patchwork.libcamera.org/cover/16482/mbox/", "series": [ { "id": 3239, "url": "https://patchwork.libcamera.org/api/1.1/series/3239/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3239", "date": "2022-06-30T14:35:35", "name": "ipa: rkisp1: Add autofocus algorithm", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3239/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/16482/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1AC79BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jun 2022 14:35:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 665AF6564E;\n\tThu, 30 Jun 2022 16:35:51 +0200 (CEST)", "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB0AD6559A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jun 2022 16:35:49 +0200 (CEST)", "by mail-wr1-x432.google.com with SMTP id e28so22461626wra.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jun 2022 07:35:49 -0700 (PDT)", "from localhost.localdomain (ip092042140082.rev.nessus.at.\n\t[92.42.140.82]) by smtp.gmail.com with ESMTPSA id\n\tr5-20020a05600c320500b0039db500714fsm6405945wmp.6.2022.06.30.07.35.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 30 Jun 2022 07:35:48 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656599751;\n\tbh=0E8bHJbcitZ5Gz0AafM02LyJns1LWDO5VI1PJqHg0+Q=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=dkfTjLTdxZT2MeR8UICzAlY+kxoY4mie8WNc1RGh3tc912X/PXqteXCgQYFSf22YI\n\t2Q4HiS0NbJJXNPpvMH3+R1nqTgKYYm0Rs8ODe5ZXggS26ELF+q6WxJp5aj9VSDDYUE\n\tlAYruL2xu32W7EMF7o0buF4Nxm84WWKWd197PWb6Qc/7KvzbTQqBBIfoVKkZSJtcKb\n\tjhKXnmBl3krs572NclCKGozKvehH7rG2wdJ2TNmFAoo1xZmzno5UICauYtHqt/x+AL\n\tR4VAcRYQZibr+UHbTLniXS7Iox+CdL8QAUEXdGdrqxPXsiIc97ptaXv9pIgz5gv6KX\n\tNuFywO8zzzTYg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=hgsegQ1Ce5HrQDQuHcZ+3r99hyJZ/fx9QEQDYGNYkyc=;\n\tb=wSyc7aRyLo8BXwU8Aof61WeMNEIDc/UrKJrnC6ENEl6WOYqvHv6pg6QACFb+iHs2jp\n\tFP8O3/AFkAiM58f7oAIjvTE+nrmwi6erDhtGfO0p05Z7rEchLnkqvNCBKzUs0WZ8zs8W\n\tF9a7d5WHGQ43Z4TsSSlzbSQe4Vye1vvuC6rIm3h7IWCOcRMbrw2DqgMsv59y3/c5KKnp\n\tl810zvd6v5nK+xRlx+mh3VO9nwFQmNqq38YPkXOBMoMbD0kZLUYraUKqPMmnNCwXPj0Z\n\tnZulvXE/m/sdFWQdfBTB+wbHhwqibJ3xCU9SFfa6oZ5DGXE29srdufsXW7w0raKE3Osv\n\tomFQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"wSyc7aRy\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=hgsegQ1Ce5HrQDQuHcZ+3r99hyJZ/fx9QEQDYGNYkyc=;\n\tb=SaLc3T8N8dkjPa7VuCrG2E/h4zg6slswBhCdJpEMpJStLQcwwEQTBCObwDcjLb0HIU\n\tJOpd/QP/L8VnPB89JbJx20ulp3u8H+4ddXn/mHyNJdF/KtLXVggduwmwkAlf7XuD56HT\n\t2TRMvQkX6Z3/wCIaeU22FAhMMj683Q6TQ7W5wTlM3hpVEVnHfXwVwl8Tpz5CAtR3O28N\n\tfxLT6LOf/GHrvIQlwbSB/mVFlr7pojg+7tNuqpUIVH5I6ALmR5SLGvjPOyfC6yBdaZ6W\n\tAZ/pKBk+os/9d7BNTd45pGzgdjuYdvENZsSXl88YYA9HNFwKVHiLxmdCD3qL7lKa47Vs\n\tcS2w==", "X-Gm-Message-State": "AJIora9ZkXQTAYT8iIf802xKJDEIi+5OtxsPpj4GX5DoXmmOAPqgPCaa\n\tmgD5RswcEp16WOA3S0DDRbm1h8kqnliTyw==", "X-Google-Smtp-Source": "AGRyM1uhz537RxPhaTGtBjsleUb3+1t5RXLSDVNUWRd6L7Yj26WKIedrF1hTg4gNVooDQYq55YqkRg==", "X-Received": "by 2002:a5d:51d2:0:b0:21b:bd52:c9c9 with SMTP id\n\tn18-20020a5d51d2000000b0021bbd52c9c9mr9030552wrv.498.1656599749494; \n\tThu, 30 Jun 2022 07:35:49 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 30 Jun 2022 16:35:35 +0200", "Message-Id": "<20220630143543.39599-1-dse@thaumatec.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 0/8] ipa: rkisp1: Add autofocus algorithm", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Daniel Semkowicz via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Daniel Semkowicz <dse@thaumatec.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n\nThe following set of patches introduces an autofocus algorithm for\nrkisp1 platforms. As there are common parts of code in the IPU3, RPi and\nnow they would be repeated in rkisp1, I tried to separate the main\ncontrol part of the AF algorithm in the new AfHillClimbing class.\n\nThese changes make use of the freshly introduced algorithm registration\nmechanism. As there was a missing part for the easy way to get the\nspecific algorithm from the dynamically loaded list, I added \ngetAlgorithm<AlgoType>() method to the Module class that. It was\nimplemented in the fastest way to get it working, but I think we should\nimprove it later. Maybe it would be good to extend algorithm creation\nand store also the name of corresponding algorithm to allow calling it\nby name instead of type. Especially that algorithms are loaded from\ntuning file by name.\n\nI am not sure if the directory structure I have chosen for the common\ncode is a good place, so please correct me if I should place it\nsomewhere else.\n\nDoxygen documentation part should be, for sure, more detailed, but I\nfirstly want to wait for your comments about the code, just in case if\nthere were any changes to the design.\n\nThese changes depend on the \"libcamera: rkisp1: Add lens control\"\nchanges that are still in the review process.\nLink: https://patchwork.libcamera.org/project/libcamera/list/?series=3228\n\nI am waiting for your comments :)\n\nBest regards\nDaniel Semkowicz\n\nDaniel Semkowicz (8):\n ipa: Add base class defining AF algorithm interface\n ipa: Add class that implements base AF control algorithm\n ipa: rkisp1: Add AF algorithm basing on common AfHillClimbing class\n pipeline: rkisp1: Add basic AF controls to the supported controls list\n ipa: module: Add getAlgorithm() method\n ipa: rkisp1: Pass requests setting AF controls to the AF algorithm\n ipa: rkisp1: Add OV5675 tuning file\n ipa: rkisp1: Add \"Windows\" Metering mode to auto focus algorithm\n\n src/ipa/libipa/algorithms/af_algorithm.cpp | 77 ++++++\n src/ipa/libipa/algorithms/af_algorithm.h | 39 +++\n .../libipa/algorithms/af_hill_climbing.cpp | 89 +++++++\n src/ipa/libipa/algorithms/af_hill_climbing.h | 251 ++++++++++++++++++\n src/ipa/libipa/algorithms/meson.build | 11 +\n src/ipa/libipa/meson.build | 6 +\n src/ipa/libipa/module.cpp | 7 +\n src/ipa/libipa/module.h | 17 ++\n src/ipa/rkisp1/algorithms/af.cpp | 132 +++++++++\n src/ipa/rkisp1/algorithms/af.h | 41 +++\n src/ipa/rkisp1/algorithms/meson.build | 1 +\n src/ipa/rkisp1/data/meson.build | 1 +\n src/ipa/rkisp1/data/ov5675.yaml | 12 +\n src/ipa/rkisp1/rkisp1.cpp | 72 ++++-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 12 +-\n 15 files changed, 762 insertions(+), 6 deletions(-)\n create mode 100644 src/ipa/libipa/algorithms/af_algorithm.cpp\n create mode 100644 src/ipa/libipa/algorithms/af_algorithm.h\n create mode 100644 src/ipa/libipa/algorithms/af_hill_climbing.cpp\n create mode 100644 src/ipa/libipa/algorithms/af_hill_climbing.h\n create mode 100644 src/ipa/libipa/algorithms/meson.build\n create mode 100644 src/ipa/rkisp1/algorithms/af.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/af.h\n create mode 100644 src/ipa/rkisp1/data/ov5675.yaml" }