Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/16346/?format=api
{ "id": 16346, "url": "https://patchwork.libcamera.org/api/1.1/covers/16346/?format=api", "web_url": "https://patchwork.libcamera.org/cover/16346/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220623232210.18742-1-laurent.pinchart@ideasonboard.com>", "date": "2022-06-23T23:21:57", "name": "[libcamera-devel,00/13] gstreamer: Queue multiple requests", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/16346/mbox/", "series": [ { "id": 3214, "url": "https://patchwork.libcamera.org/api/1.1/series/3214/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3214", "date": "2022-06-23T23:21:57", "name": "gstreamer: Queue multiple requests", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3214/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/16346/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 658C8BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Jun 2022 23:22:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7322B6563A;\n\tFri, 24 Jun 2022 01:22:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F29B561FB2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jun 2022 01:22:28 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 460B5DD;\n\tFri, 24 Jun 2022 01:22:28 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656026550;\n\tbh=9K9tucfu6/SUgHLl8frLf5KptonYI+em3AMKx7LKB2M=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=W6Ffa2B4SJTrx3wfFHd/6RJsk38DYPIotKa4Pc/Usam9VKpjYWXIPbxwNZ9hRv0eR\n\tOrHXDK8Ui9bdiaW3Nrr922rWHM3vLHmaJ3YI7Idh8OYj6rAQF4hebSi9hNNTievjJS\n\t4y/1f7mXVGroj+/c5NnPxBDMp60xvf7osxaaSJFzs+VxxewCYXN5TNRZdajxKlqkhP\n\tLGfdBni+ubkVSsnd3Hhr34+KZtdMbczAQvQD9ABq9AU407fFbrwodT1xTlwjR/aSPn\n\tgcIK+DzWcoXaZt5Yw6ikUQxV1350LLON6lJfcKZpOS4N5mL2bG3VhDJFHfOib/Jug0\n\t2FQK611figEFg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656026548;\n\tbh=9K9tucfu6/SUgHLl8frLf5KptonYI+em3AMKx7LKB2M=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ZvYwDITygU0BJOTOv9WtRIBzLDhO5bjWu6FBO50tIJDXkrMc3l4i2eiYmo7R+pQpH\n\tZU2jToSDbyxrmLCr+1XXDu8kJRCGlBkKB6gurPVXkwLrsnzlT694MCwvh/Gu5ARbYI\n\tTJ03lZ7NtBQ0ZJLom4T2pdT/S7sunSTHuNK4IkCc=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ZvYwDITy\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 24 Jun 2022 02:21:57 +0300", "Message-Id": "<20220623232210.18742-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 00/13] gstreamer: Queue multiple requests", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tVedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n\nThis patch series fixes a long-standing issue in the libcamerasrc\nelement, namely the fact that it never queues more than one request at a\ntime.\n\nIt took me quite a while to grasp the implementation of libcamerasrc,\nand this probably shows through the patch series. I don't claim any of\nthis is particularly good, only that it enables libcamerasrc usage with\nrkisp1 and vimc, which isn't possible today, and that it didn't\nintroduce any regression I could notice.\n\nReviews from developers with more experience in GStreamer than me would\nbe appreciated :-)\n\nLaurent Pinchart (13):\n gstreamer: Use gst_task_resume() when available\n gstreamer: Inline gst_libcamera_buffer_get_frame_buffer()\n gstreamer: Move variable to loop scope\n gstreamer: Pass Stream to RequestWrap::addBuffer()\n gstreamer: Move timestamp calculation out of pad loop\n gstreamer: Rename queued requests queue to queuedRequests_\n gstreamer: Handle completed requests in the libcamerasrc task\n gstreamer: Combine the two pad loops in the task run handler\n gstreamer: Use dedicated lock for request queues\n gstreamer: Fix pads locking\n gstreamer: Split request creation to a separate function\n gstreamer: Split completed request processing to a separate function\n gstreamer: Fix race conditions in task pause/resume\n\n src/gstreamer/gstlibcamera-utils.cpp | 16 +-\n src/gstreamer/gstlibcamera-utils.h | 4 +-\n src/gstreamer/gstlibcameraallocator.cpp | 3 +-\n src/gstreamer/gstlibcameraallocator.h | 2 +-\n src/gstreamer/gstlibcamerapad.cpp | 35 ---\n src/gstreamer/gstlibcamerapad.h | 6 -\n src/gstreamer/gstlibcamerapool.cpp | 14 --\n src/gstreamer/gstlibcamerapool.h | 4 -\n src/gstreamer/gstlibcamerasrc.cpp | 308 ++++++++++++++++--------\n 9 files changed, 227 insertions(+), 165 deletions(-)\n\n\nbase-commit: 7ec3bfedbe22962600b438a13d9e13d37d55ce25" }