Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/15135/?format=api
{ "id": 15135, "url": "https://patchwork.libcamera.org/api/1.1/covers/15135/?format=api", "web_url": "https://patchwork.libcamera.org/cover/15135/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211211165714.23067-1-jacopo@jmondi.org>", "date": "2021-12-11T16:57:03", "name": "[libcamera-devel,v6,00/11] libcamera: Add Fence support", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/15135/mbox/", "series": [ { "id": 2838, "url": "https://patchwork.libcamera.org/api/1.1/series/2838/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2838", "date": "2021-12-11T16:57:03", "name": "libcamera: Add Fence support", "version": 6, "mbox": "https://patchwork.libcamera.org/series/2838/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/15135/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA4BABDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 11 Dec 2021 16:56:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 036446088C;\n\tSat, 11 Dec 2021 17:56:26 +0100 (CET)", "from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E36D760112\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 11 Dec 2021 17:56:24 +0100 (CET)", "(Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 5EE1E20007;\n\tSat, 11 Dec 2021 16:56:24 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 11 Dec 2021 17:57:03 +0100", "Message-Id": "<20211211165714.23067-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.33.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 00/11] libcamera: Add Fence support", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fixed two issues spotted by Laurent in review:\n\n- Request::prepare(): If timeout > 0 then start the timer\n- Test: set requestCompleted_ for successful requests too\n\nThe combination of the two bugs made the issue went unnoticed, as:\n1) Fence timer was never started\n2) In the test, the timer to signal the fence timeout was not started\n\nIt also went un-noticed when running CTS as simply a fence timeout could\nnever happen.\n\nBuildbot and CTS validated.\n\nThanks\n j\n\n\nJacopo Mondi (10):\n libcamera: Print Timer identifier\n libcamera: fence: Introduce Fence\n libcamera: framebuffer: Add Fence to FrameBuffer\n libcamera: request: Add Fence to Request::addBuffer()\n libcamera: pipeline_handler: Split request queueing\n libcamera: pipeline: Introduce stopDevice()\n libcamera: request: Add Request::Private::prepare()\n libcamera: pipeline_handler: Prepare Request\n test: fence: Add test for the Fence class\n android: Remove CameraWorker\n\nLaurent Pinchart (1):\n libcamera: request: Make Request class Extensible\n\n include/libcamera/fence.h | 31 ++\n include/libcamera/framebuffer.h | 4 +\n include/libcamera/internal/framebuffer.h | 8 +\n include/libcamera/internal/meson.build | 1 +\n include/libcamera/internal/pipeline_handler.h | 9 +-\n include/libcamera/internal/request.h | 65 +++\n .../libcamera/internal/tracepoints/request.tp | 22 +-\n include/libcamera/meson.build | 1 +\n include/libcamera/request.h | 23 +-\n src/android/camera_device.cpp | 42 +-\n src/android/camera_device.h | 3 -\n src/android/camera_request.cpp | 3 +-\n src/android/camera_request.h | 6 +-\n src/android/camera_stream.cpp | 10 +-\n src/android/camera_worker.cpp | 129 ------\n src/android/camera_worker.h | 70 ----\n src/android/meson.build | 1 -\n src/libcamera/base/event_dispatcher_poll.cpp | 3 +-\n src/libcamera/base/timer.cpp | 4 +-\n src/libcamera/fence.cpp | 112 +++++\n src/libcamera/framebuffer.cpp | 58 +++\n src/libcamera/meson.build | 1 +\n src/libcamera/pipeline/ipu3/ipu3.cpp | 4 +-\n .../pipeline/raspberrypi/raspberrypi.cpp | 4 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 +-\n src/libcamera/pipeline/simple/simple.cpp | 4 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 +-\n src/libcamera/pipeline/vimc/vimc.cpp | 4 +-\n src/libcamera/pipeline_handler.cpp | 101 ++++-\n src/libcamera/request.cpp | 395 ++++++++++++++----\n test/fence.cpp | 335 +++++++++++++++\n test/meson.build | 1 +\n 32 files changed, 1094 insertions(+), 368 deletions(-)\n create mode 100644 include/libcamera/fence.h\n create mode 100644 include/libcamera/internal/request.h\n delete mode 100644 src/android/camera_worker.cpp\n delete mode 100644 src/android/camera_worker.h\n create mode 100644 src/libcamera/fence.cpp\n create mode 100644 test/fence.cpp\n\n--\n2.33.1" }