Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/14994/?format=api
{ "id": 14994, "url": "https://patchwork.libcamera.org/api/1.1/covers/14994/?format=api", "web_url": "https://patchwork.libcamera.org/cover/14994/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211202180410.518232-1-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-12-02T18:04:04", "name": "[libcamera-devel,v1,0/6] IPA RkISP1 awb and misc improvements", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/14994/mbox/", "series": [ { "id": 2805, "url": "https://patchwork.libcamera.org/api/1.1/series/2805/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2805", "date": "2021-12-02T18:04:04", "name": "IPA RkISP1 awb and misc improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2805/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/14994/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37844BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 2 Dec 2021 18:04:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7896060832;\n\tThu, 2 Dec 2021 19:04:17 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AAE916011A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 2 Dec 2021 19:04:15 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:7fc3:78ca:aeee:c4f2])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E367464;\n\tThu, 2 Dec 2021 19:04:15 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T2/DgtuB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638468255;\n\tbh=bRclG9sLtT4Spk9m2k76VMa8LtbCee6iFa5tATRC0AY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=T2/DgtuB8mSSpq6T7o48izwH8iz/PJax6+NNlc0HxuazXQMZxOsoT6ItKPV+9bzUd\n\tk8MleYI8Kxqgw9uySnR3BwOnML+GgVlMYs4iSVGAQ6NDCqusmz9t9WEljEdgvqdRIQ\n\tj+Os+RdByVGeIHeIVAmZGVj2lbY8uV04sGmNvQOQ=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 2 Dec 2021 19:04:04 +0100", "Message-Id": "<20211202180410.518232-1-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 0/6] IPA RkISP1 awb and misc\n\timprovements", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n\nThis series introduces several algorithms or tuning parameters for the\nRkISP1 IPA.\n\nFirst, the imx219 is a non linear CMOS sensor and its channels are\ncompressed. In order to have a better exposed output frame, we need to\napply a deGamma curve on the raw pixels, which is done by a simple\nlook-up table on the ISP side. The values are taken from the imx219.json\ntuning file in the RPi IPA.\n\nThe next algorithm is the black level correction. The output is washed\nout if no black correction is applied. Again, use the tuning values from\nthe imx219 data file in RPi.\n\nNow, we can estimate the AWB gains to apply on the red and blue\nchannels. The RkISP1 could theoretically give us the red, green and blue\nmean values for the current frame, but the kernel seems to lack support\nfor this. Use the YCrCb estimation instead, and convert the values to\nRGB before estimating the gains. We don't have a grid of average values,\nonly a global mean for each channel.\n\nNext, the color correction matric needs to be a bit modified as the\ndefault one is a simple identity matrix. A very simple estimation uses\nthe red and blue gains calculated but a real tuning file would be\nbetter, based on color temperature as the imx219 data file.\n\nLast patch introduces the histogram IQ mean estimation as for the IPU3\nand uses the maximum of the relative luminance gain and the iqMean gain\nto determine the shutter speed and analogue gain to apply.\n\nI wanted to post captured images for each of those algorithm to see the\nevolution but I accidentaly broke my sd card connector... and I am now\nstuck until I can repair it... :-(\n\nJean-Michel Hautbois (6):\n ipa: rkisp1: Introduce sensor degamma\n ipa: rkisp1: Use frame index\n ipa: rkisp1: Introduce Black Level Correction\n ipa: rkisp1: Introduce AWB\n ipa: rkisp1: Introduce crosstalk correction\n ipa: rkisp1: agc: Introduce histogram calculation\n\n src/ipa/rkisp1/algorithms/agc.cpp | 92 +++++++++++++---\n src/ipa/rkisp1/algorithms/agc.h | 4 +-\n src/ipa/rkisp1/algorithms/awb.cpp | 149 ++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/awb.h | 33 ++++++\n src/ipa/rkisp1/algorithms/blc.cpp | 55 ++++++++++\n src/ipa/rkisp1/algorithms/blc.h | 30 ++++++\n src/ipa/rkisp1/algorithms/ctk.cpp | 59 ++++++++++\n src/ipa/rkisp1/algorithms/ctk.h | 30 ++++++\n src/ipa/rkisp1/algorithms/meson.build | 4 +\n src/ipa/rkisp1/algorithms/sdg.cpp | 49 +++++++++\n src/ipa/rkisp1/algorithms/sdg.h | 30 ++++++\n src/ipa/rkisp1/ipa_context.cpp | 33 ++++++\n src/ipa/rkisp1/ipa_context.h | 19 ++++\n src/ipa/rkisp1/rkisp1.cpp | 19 ++--\n 14 files changed, 583 insertions(+), 23 deletions(-)\n create mode 100644 src/ipa/rkisp1/algorithms/awb.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/awb.h\n create mode 100644 src/ipa/rkisp1/algorithms/blc.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/blc.h\n create mode 100644 src/ipa/rkisp1/algorithms/ctk.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/ctk.h\n create mode 100644 src/ipa/rkisp1/algorithms/sdg.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/sdg.h" }