Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/14761/?format=api
{ "id": 14761, "url": "https://patchwork.libcamera.org/api/1.1/covers/14761/?format=api", "web_url": "https://patchwork.libcamera.org/cover/14761/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211125054259.24792-1-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-25T05:42:48", "name": "[libcamera-devel,v5,00/11] Introduce AGC for RkISP1", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/14761/mbox/", "series": [ { "id": 2752, "url": "https://patchwork.libcamera.org/api/1.1/series/2752/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2752", "date": "2021-11-25T05:42:48", "name": "Introduce AGC for RkISP1", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2752/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/14761/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE5A9BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Nov 2021 05:43:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E61C603C2;\n\tThu, 25 Nov 2021 06:43:06 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05A6C6011E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Nov 2021 06:43:04 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:d9a5:5e40:3323:d95])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D64990E;\n\tThu, 25 Nov 2021 06:43:03 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ttDA9a22\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637818983;\n\tbh=rbStu20lar1aiv4IGOsIG50ntYZx+UsztZp7zR18KUs=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ttDA9a22iBNsiZoCq+6/kDMb2DRpLtFIrcUWaL6mx2z21JEZUu1E8Uqxi/Li9l6Ru\n\t6EFvO4TlYhl/4BqdPNrC7fO+o0ooygC/FUKRNRkaZKbKSZeYrz4wbsgu7K0FKFC+UP\n\tDg8G2yr37qazz3Mbmfpe8Tomjp3VD/ePFATnF6Qw=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 25 Nov 2021 06:42:48 +0100", "Message-Id": "<20211125054259.24792-1-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 00/11] Introduce AGC for RkISP1", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n\nThis is the v5 of the RkISP1 AGC series which includes a correction of\nbad filtering usage in v4 for AGC, and some minor modifications.\n\nIn v3, a template for the Algorithm class is introduced in\npatch 6/11 and 7/11 for the RkISP1 implementation.\n\nNow that AGC is working pretty nicely on IPU3, make it work on RkISP1\ntoo.\n\nFor that purpose, patches 1/11 to 5/11 reuse the concepts of Algorithm and\nIPAContext and make those part of the rkisp1 IPA. The effective sensor\ncontrols can then be reported with patch 8/11.\n\nIn v4, the hw revision is included in IPAContext before the AGC uses it\n(patch 9/11).\n\nPatch 10/11 is a small adaptation of the IPU3 AGC: we reuse the relative\nluminance estimation, basing it on the Y mean measured by the ISP, and\nremoves the histogram based calculation for now.\n\nIn v2 the improvements from Laurent's series \"ipa: ipu3: agc: Misc\nimprovements\" are also included.\n\nPatch 11/11 introduces a new prepare() call from the Algorithm class in\nAGC.\n\nJean-Michel Hautbois (11):\n libipa: Correct IMX219 in CameraSensorHelper\n ipa: rkisp1: Pass IPASettings at init call\n ipa: Do not modify the sensor limits\n ipa: rkisp1: Instantiate CameraSensorHelper\n ipa: rkisp1: Introduce IPAContext\n ipa: libipa: Introduce Algorithm class template\n ipa: rkisp1: Use the Algorithm class\n ipa: rkisp1: Report and use sensor controls\n ipa: rkisp1: agc: Introduce HW revision in IPAContext\n ipa: rkisp1: Introduce AGC\n ipa: rkisp1: agc: Introduce prepare call\n\n include/libcamera/ipa/rkisp1.mojom | 6 +-\n src/ipa/ipu3/algorithms/algorithm.h | 12 +-\n src/ipa/ipu3/algorithms/awb.cpp | 9 +\n src/ipa/ipu3/algorithms/meson.build | 1 -\n src/ipa/ipu3/ipu3.cpp | 4 +-\n .../{ipu3/algorithms => libipa}/algorithm.cpp | 38 +--\n src/ipa/libipa/algorithm.h | 38 +++\n src/ipa/libipa/camera_sensor_helper.cpp | 2 +-\n src/ipa/libipa/meson.build | 1 +\n src/ipa/rkisp1/algorithms/agc.cpp | 282 ++++++++++++++++++\n src/ipa/rkisp1/algorithms/agc.h | 47 +++\n src/ipa/rkisp1/algorithms/algorithm.h | 26 ++\n src/ipa/rkisp1/algorithms/meson.build | 5 +\n src/ipa/rkisp1/ipa_context.cpp | 111 +++++++\n src/ipa/rkisp1/ipa_context.h | 52 ++++\n src/ipa/rkisp1/meson.build | 11 +-\n src/ipa/rkisp1/rkisp1.cpp | 138 +++++----\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +-\n 18 files changed, 691 insertions(+), 97 deletions(-)\n rename src/ipa/{ipu3/algorithms => libipa}/algorithm.cpp (75%)\n create mode 100644 src/ipa/libipa/algorithm.h\n create mode 100644 src/ipa/rkisp1/algorithms/agc.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/agc.h\n create mode 100644 src/ipa/rkisp1/algorithms/algorithm.h\n create mode 100644 src/ipa/rkisp1/algorithms/meson.build\n create mode 100644 src/ipa/rkisp1/ipa_context.cpp\n create mode 100644 src/ipa/rkisp1/ipa_context.h" }