Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/13927/?format=api
{ "id": 13927, "url": "https://patchwork.libcamera.org/api/1.1/covers/13927/?format=api", "web_url": "https://patchwork.libcamera.org/cover/13927/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210924170234.152783-1-jacopo@jmondi.org>", "date": "2021-09-24T17:02:32", "name": "[libcamera-devel,0/2] android: Wait on acquisition fences in CameraStream", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/13927/mbox/", "series": [ { "id": 2566, "url": "https://patchwork.libcamera.org/api/1.1/series/2566/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2566", "date": "2021-09-24T17:02:32", "name": "android: Wait on acquisition fences in CameraStream", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2566/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/13927/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55768BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Sep 2021 17:01:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87BF76918A;\n\tFri, 24 Sep 2021 19:01:52 +0200 (CEST)", "from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 975EC687DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Sep 2021 19:01:50 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 18210240006;\n\tFri, 24 Sep 2021 17:01:49 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 24 Sep 2021 19:02:32 +0200", "Message-Id": "<20210924170234.152783-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 0/2] android: Wait on acquisition fences\n\tin CameraStream", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "An acquisition fence is associated to each camera3_stream_buffer_t part of a\ncapture request.\n\nStreams generated by libcamera (Type::Direct) are queued to the\nlibcamera::Camera and their fences are waited on by the CameraWorker class.\n\nAcquisition fences for Streams generated by post-processing have been so far\nignored and the fence was not closed, resulting in a leak that crashed the\ncamera service with:\n\n FATAL FileDescriptor file_descriptor.cpp:265 Failed to dup() fd: Too many open files\n\nFix this by instrumenting CameraStream to handle fences in the process()\nfunction.\n\nThis is a temporary workaround until libcamera is not instrumented with a\nmechanism to handle fences internally.\n\nThanks\n j\n\nJacopo Mondi (2):\n android: wait on fences in CameraStream::process()\n android: Post-pone fences reset in result\n\n src/android/camera_device.cpp | 46 +++++++++++++++++++++++-----------\n src/android/camera_stream.cpp | 47 ++++++++++++++++++++++++++++++++++-\n src/android/camera_stream.h | 4 ++-\n 3 files changed, 81 insertions(+), 16 deletions(-)\n\n--\n2.32.0" }