Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/13501/?format=api
{ "id": 13501, "url": "https://patchwork.libcamera.org/api/1.1/covers/13501/?format=api", "web_url": "https://patchwork.libcamera.org/cover/13501/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210826112539.170694-1-hiroh@chromium.org>", "date": "2021-08-26T11:25:30", "name": "[libcamera-devel,v3,0/9] Add offset to FrameBuffer::Plane", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "mbox": "https://patchwork.libcamera.org/cover/13501/mbox/", "series": [ { "id": 2398, "url": "https://patchwork.libcamera.org/api/1.1/series/2398/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2398", "date": "2021-08-26T11:25:30", "name": "Add offset to FrameBuffer::Plane", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2398/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/13501/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 801A2BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 26 Aug 2021 11:25:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BBD10688E5;\n\tThu, 26 Aug 2021 13:25:48 +0200 (CEST)", "from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com\n\t[IPv6:2607:f8b0:4864:20::1031])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A5786888F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Aug 2021 13:25:47 +0200 (CEST)", "by mail-pj1-x1031.google.com with SMTP id\n\tot2-20020a17090b3b4200b0019127f8ed87so5784643pjb.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Aug 2021 04:25:47 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:a5bc:b3dd:7208:bec1])\n\tby smtp.gmail.com with ESMTPSA id\n\ts29sm3472057pgl.38.2021.08.26.04.25.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 26 Aug 2021 04:25:44 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"FbjbjsAs\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=NYthwwd62eAw805O7bvdIsCeMNZHF811KpjboK4UO/s=;\n\tb=FbjbjsAsL8h3KqSlZBq5ye5PhB8qOuwdnzQDpKt5MDCHTlNjKF3TkweMBU+ZIjqZdE\n\tJDjdJJv0CMf9Gqsk0gE8M5pwa4Jdx6CkajMInVw0F9New7MQQL6QiY43I7vsyh8pKqdq\n\ttP/Z6JA9dOzmBiAaDtrJjAT4tosoe3HCTtxYg=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=NYthwwd62eAw805O7bvdIsCeMNZHF811KpjboK4UO/s=;\n\tb=kkdPob+pfVKzlEiHO4RyHorbJjNS2l6xrlXzO88FIGyQa5EM3C/Qx0tNXr6zHJAg3F\n\tTHWIL3xqVKp4avex8I4hKx2qQpxyqGlz+jNpSwL3tokjVmBU2H3C8T4NmpJUGD5sv65I\n\trg3jajc7s8FzsDp42qQc8CJi9rVVl7la+0vHiIXO7FKHnl2jiVf39CzVcgcQWzAmCJQ/\n\tFM07tIdWxFbEx/JdZHXMNuWe9iQHdUYCHICefUjf3HdOzMAyMo2r/Q/n2ZFhk83Gu+L8\n\tWb7c+1MPx1QRvPA7HnVMq0I7jyjvF/ir5GIm9cD4u2dblnI3VrJg5hfkYCp3gFJiAYVz\n\tyxaA==", "X-Gm-Message-State": "AOAM532Psox7Kb/nYhf45R8wf25kA/cBN2BBrIOMHqxc8a1JWT6p5yty\n\tJ6S055DAY2v3C3+zwQyY/z4WWv4u9Sr7+g==", "X-Google-Smtp-Source": "ABdhPJzHCjyTI6yVp42eNqrsaYLjatBKNEajpCeOn8Tz7sr/uB8qjibAQajm1hENbRKdjvbfz2XmdA==", "X-Received": "by 2002:a17:90b:1e02:: with SMTP id\n\tpg2mr3852588pjb.37.1629977145294; \n\tThu, 26 Aug 2021 04:25:45 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 26 Aug 2021 20:25:30 +0900", "Message-Id": "<20210826112539.170694-1-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.33.0.rc2.250.ged5fa647cd-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 0/9] Add offset to FrameBuffer::Plane", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since FrameBuffer::Plane doesn't have an offset variable, it is\nimpossible to map the FrameBuffer::Plane correctly. This series fixes\nthe issue by adding an offset and aligns some code of mapping and\ncreating FrameBuffer::Plane with the new offset.\n\nOne of the pateches fixes V4L2Device to make a returned FrameBuffer\ncolor format planes from v4l2 format planes. However, V4L2 API doesn't\nprovide a way of getting a dmabuf plane offset, so a multi planar\nformat e.g. V4L2_PIX_FMT_NV12M is not supported with this patch series.\n\nThis series must be applied on top of the pacth series whose id is 2384.\ncf.) https://patchwork.libcamera.org/project/libcamera/list/?series=2384\n\nChange in v3:\n- address review comments to v2\n- squash 01/10 and 02/10 (serialization change) of v2\n\nChange in v2:\n- adress review comments to v1\n\nHirokazu Honda (9):\n libcamera: framebuffer: Add offset to FrameBuffer::Plane\n libcamera: mapped_framebuffer: Return plane begin address by\n MappedBuffer::maps()\n cam: file_sink: Use offset in mapping FrameBuffer\n ipa: rkisp1: Use offset in mapping IPABuffer\n qcam: main_window: Use offset mapping FrameBuffer\n gstreamer: gstlibcameraallocator: Use offset in creating a buffer\n V4L2VideDevice::createBuffer() creates the same number of\n FrameBuffer::Planes as V4L2 format planes. Therefore, if the v4l2\n format single is single-planar format, the created number of\n FrameBuffer::Planes is 1. It should rather create the same number of\n FrameBuffer::Planes as the color format planes.\n android: camera_device: Fill offset and right length in\n CreateFrameBuffer()\n libcamera: framebuffer: Add assertion to detect offset is unfilled\n\n include/libcamera/framebuffer.h | 12 +-\n .../libcamera/internal/mapped_framebuffer.h | 4 +-\n include/libcamera/internal/v4l2_videodevice.h | 10 +-\n src/android/camera_device.cpp | 52 ++++---\n src/android/camera_device.h | 6 +-\n src/android/mm/generic_camera_buffer.cpp | 2 -\n src/cam/file_sink.cpp | 20 ++-\n src/cam/file_sink.h | 1 +\n src/gstreamer/gstlibcameraallocator.cpp | 4 +-\n src/ipa/rkisp1/rkisp1.cpp | 33 ++--\n src/libcamera/framebuffer.cpp | 29 +++-\n src/libcamera/ipa_data_serializer.cpp | 5 +-\n src/libcamera/mapped_framebuffer.cpp | 71 +++++++--\n src/libcamera/v4l2_videodevice.cpp | 147 ++++++++++++++----\n src/qcam/main_window.cpp | 15 +-\n src/qcam/main_window.h | 1 +\n test/v4l2_videodevice/buffer_cache.cpp | 6 +-\n 17 files changed, 311 insertions(+), 107 deletions(-)\n\n--\n2.33.0.rc2.250.ged5fa647cd-goog" }