Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/13290/?format=api
{ "id": 13290, "url": "https://patchwork.libcamera.org/api/1.1/covers/13290/?format=api", "web_url": "https://patchwork.libcamera.org/cover/13290/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210810161134.2243796-1-kieran.bingham@ideasonboard.com>", "date": "2021-08-10T16:11:31", "name": "[libcamera-devel,0/3] Request: Use the Camera's CameraControlValidator", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/13290/mbox/", "series": [ { "id": 2335, "url": "https://patchwork.libcamera.org/api/1.1/series/2335/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2335", "date": "2021-08-10T16:11:31", "name": "Request: Use the Camera's CameraControlValidator", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2335/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/13290/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 039D0C3240\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 Aug 2021 16:11:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53954687F0;\n\tTue, 10 Aug 2021 18:11:39 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 341DC687F0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Aug 2021 18:11:37 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B48253F0;\n\tTue, 10 Aug 2021 18:11:36 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YnblcY+E\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628611896;\n\tbh=RElEe+JDb6yYZ5QAMrwdT023Pm91OW9Ik7FIbqjjDVQ=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=YnblcY+Ee5K/AHLyfpDeLW0Vt6vDJC/4u4wgwqCcXIUQlHkDFRPn6WvOdxe+qtdJZ\n\tNi+H606GZaseRc3gR8+Xnb+OZpm4Z7fWreE+0M+0vsLrJJDbts/8Obzh7+leVhXkH6\n\t9Zlo08oBsK4KP5VXymMWzmHDGA3cRx0CJnQikK8A=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 10 Aug 2021 17:11:31 +0100", "Message-Id": "<20210810161134.2243796-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 0/3] Request: Use the Camera's\n\tCameraControlValidator", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that we have the d-pointer designs growing, we can put a\nCameraControlValidator in the Camera's private class, and expose\nit internally such that the Request class can reference the single\ninstance, rather than constructing one for each request.\n\nPatch 1/3 first fixes up the ControlList to take a const pointer\nto ControlValidator as a pre-requisite to patch 3/3.\n\nPatch 2/3 constructs a CameraControlValidator instance on the Camera,\nand exposes an internal helper on it's private interface to access it.\n - Please note / check the use of the _o() pointer here.\n\nPatch 3/3 then takes the Camera's CameraControlValidator to use on all\nRequests when they are constructed.\n\nKieran Bingham (3):\n libcamera: controls: Use a const ControlValidator\n libcamera: camera: Create a CameraControlValidator\n libcamera: request: Use external CameraControlValidator\n\n include/libcamera/controls.h | 6 +++---\n include/libcamera/internal/camera.h | 6 ++++++\n include/libcamera/request.h | 1 -\n src/libcamera/camera.cpp | 2 +-\n src/libcamera/controls.cpp | 6 ++++--\n src/libcamera/request.cpp | 11 ++++-------\n 6 files changed, 18 insertions(+), 14 deletions(-)" }