Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/12209/?format=api
{ "id": 12209, "url": "https://patchwork.libcamera.org/api/1.1/covers/12209/?format=api", "web_url": "https://patchwork.libcamera.org/cover/12209/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210506180249.318346-1-nfraprado@collabora.com>", "date": "2021-05-06T18:02:43", "name": "[libcamera-devel,v4,0/6] lc-compliance: Add test to queue more requests than hardware depth", "submitter": { "id": 84, "url": "https://patchwork.libcamera.org/api/1.1/people/84/?format=api", "name": "Nícolas F. R. A. Prado", "email": "nfraprado@collabora.com" }, "mbox": "https://patchwork.libcamera.org/cover/12209/mbox/", "series": [ { "id": 2005, "url": "https://patchwork.libcamera.org/api/1.1/series/2005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2005", "date": "2021-05-06T18:02:43", "name": "lc-compliance: Add test to queue more requests than hardware depth", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/12209/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BDEDCBDE7F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 6 May 2021 18:03:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4ABA768918;\n\tThu, 6 May 2021 20:03:54 +0200 (CEST)", "from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF56F68901\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 6 May 2021 20:03:52 +0200 (CEST)", "from localhost.localdomain (unknown\n\t[IPv6:2804:14c:1a9:2978:995d:672b:100f:2fd9])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nfraprado)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 08D651F43B87;\n\tThu, 6 May 2021 19:03:50 +0100 (BST)" ], "From": "=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 6 May 2021 15:02:43 -0300", "Message-Id": "<20210506180249.318346-1-nfraprado@collabora.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 0/6] lc-compliance: Add test to queue\n\tmore requests than hardware depth", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "kernel@collabora.com, =?utf-8?q?Andr=C3=A9_Almeida?=\n\t<andrealmeid@collabora.com>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The purpose of this series is to add a new test to lc-compliance that tests\nqueuing a lot of requests at once in order to ensure that pipeline handlers are\nable to handle more requests than they have resources for (like internal buffers\nand v4l2 buffer slots) [1].\n\nIn order to achieve this, the FrameBufferAllocator had to be adapted in order to\nallow an arbitrary amount of buffers to be allocated. But there's also the issue\nof reporting the minimum amount of requests required by the pipeline handler,\nwhich was solved by creating a new MinNumRequests property.\n\nSo patch 1 adds the new MinNumRequests property to report the minimum amount of\nrequests needed by the pipeline handler.\n\nPatch 2 adds a count argument to allocate() so that the amount of buffers to\nallocate needs to be specified, as it is no longer assumed through bufferCount.\n\nPatch 3 refactors some common capture code in lc-compliance in order to reduce\ncode duplication (Making patch 4 simpler).\n\nPatch 4 adds the test to lc-compliance.\n\nPatch 5 replaces all usage of bufferCount for allocateBuffers() and\nimportBuffers() in pipeline handlers to constants, as bufferCount wasn't a good\nfit and to allow its removal. This is intended as a temporary measure, and\npipeline handlers will probably want to improve the logic of those values.\n\nPatch 6 removes bufferCount from the StreamConfiguration as it is no longer\nneeded.\n\nThe amount of buffers to allocate in the lc-compliance test (patch 4) was\nhardcoded to 8 since more than that would cause errors when allocating.\n\nChanges in v4:\n- Thanks to Laurent:\n - Renamed QueueDepth property to MinNumRequests and better documented it\n - Changed patch 6 to also remove bufferCount from android\n- Thanks to Niklas:\n - Added patch 3 to factor common code in lc-compliance\n- Added patch 5 to remove pipeline dependency on bufferCount\n\nChanges in v3:\n- Added patches 1 and 4 to add the QueueDepth property and remove bufferCount\n- Made the count argument required in patch 2\n- Added previously missing changes to the gstreamer and v4l2 compatibility\n layers\n\nChanges in v2:\n- Renamed and reworded commits and series\n- Dropped patches 2 and 3, which were hacks to test, and added patch 1 to add\n count to FrameBufferAllocator\n- Thanks to Niklas:\n - Created new standalone test instead of looping over the other tests\n\n[1] https://bugs.libcamera.org/show_bug.cgi?id=24\n\nv1: https://lists.libcamera.org/pipermail/libcamera-devel/2021-April/019139.html\nv2: https://lists.libcamera.org/pipermail/libcamera-devel/2021-April/019398.html\nv3: https://lists.libcamera.org/pipermail/libcamera-devel/2021-April/019613.html\n\nNícolas F. R. A. Prado (6):\n libcamera: property: Add MinNumRequests property\n libcamera: framebuffer_allocator: Make allocate() require count\n lc-compliance: Factor common capture code into SimpleCapture\n lc-compliance: Add test to queue more requests than hardware depth\n libcamera: pipeline: Don't rely on bufferCount\n libcamera: stream: Remove bufferCount\n\n include/libcamera/camera.h | 2 +-\n include/libcamera/framebuffer_allocator.h | 2 +-\n include/libcamera/internal/pipeline_handler.h | 2 +-\n include/libcamera/stream.h | 2 -\n src/android/camera_stream.cpp | 7 +-\n src/cam/capture.cpp | 9 +-\n src/gstreamer/gstlibcameraallocator.cpp | 4 +-\n src/lc-compliance/simple_capture.cpp | 203 ++++++++++++------\n src/lc-compliance/simple_capture.h | 27 ++-\n src/lc-compliance/single_stream.cpp | 37 +++-\n src/libcamera/camera.cpp | 4 +-\n src/libcamera/framebuffer_allocator.cpp | 5 +-\n src/libcamera/pipeline/ipu3/cio2.cpp | 1 -\n src/libcamera/pipeline/ipu3/imgu.cpp | 12 +-\n src/libcamera/pipeline/ipu3/imgu.h | 5 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 26 +--\n .../pipeline/raspberrypi/raspberrypi.cpp | 31 ++-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 15 +-\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 4 +-\n src/libcamera/pipeline/rkisp1/rkisp1_path.h | 3 +\n src/libcamera/pipeline/simple/converter.cpp | 7 +-\n src/libcamera/pipeline/simple/converter.h | 6 +-\n src/libcamera/pipeline/simple/simple.cpp | 17 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 17 +-\n src/libcamera/pipeline/vimc/vimc.cpp | 18 +-\n src/libcamera/pipeline_handler.cpp | 1 +\n src/libcamera/property_ids.yaml | 9 +\n src/libcamera/stream.cpp | 9 +-\n src/qcam/main_window.cpp | 4 +-\n src/v4l2/v4l2_camera.cpp | 16 +-\n src/v4l2/v4l2_camera.h | 5 +-\n src/v4l2/v4l2_camera_proxy.cpp | 8 +-\n test/camera/buffer_import.cpp | 10 +-\n test/camera/capture.cpp | 4 +-\n test/camera/statemachine.cpp | 4 +-\n test/libtest/buffer_source.cpp | 4 +-\n test/libtest/buffer_source.h | 2 +-\n test/mapped-buffer.cpp | 4 +-\n test/v4l2_videodevice/buffer_cache.cpp | 4 +-\n 39 files changed, 347 insertions(+), 203 deletions(-)" }