Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/11796/?format=api
{ "id": 11796, "url": "https://patchwork.libcamera.org/api/1.1/covers/11796/?format=api", "web_url": "https://patchwork.libcamera.org/cover/11796/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210330165743.4924-1-david.plowman@raspberrypi.com>", "date": "2021-03-30T16:57:42", "name": "[libcamera-devel,0/1] Fix CameraSensor::sensorInfo by updating VBLANK ControlInfo", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/11796/mbox/", "series": [ { "id": 1873, "url": "https://patchwork.libcamera.org/api/1.1/series/1873/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1873", "date": "2021-03-30T16:57:42", "name": "Fix CameraSensor::sensorInfo by updating VBLANK ControlInfo", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1873/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/11796/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE044C0DA3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Mar 2021 16:57:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0E02F68782;\n\tTue, 30 Mar 2021 18:57:51 +0200 (CEST)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A72DA602D2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Mar 2021 18:57:49 +0200 (CEST)", "by mail-wm1-x32f.google.com with SMTP id\n\tb2-20020a7bc2420000b029010be1081172so8805655wmj.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Mar 2021 09:57:49 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\ts13sm3695448wrv.80.2021.03.30.09.57.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 30 Mar 2021 09:57:48 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"lUb8LKq7\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=s/HYy3aySFTeYwe0B2XB8aV0coXSY3WEqyhGPqGM+Og=;\n\tb=lUb8LKq7wful5Ta4r5kMeTL4/y3Mfi38vN3Ih1BQWlfbB3+C3eSZrjsvBgJ5MTp+YE\n\tF0QlIJapYMxt+PfW9K8eA5lwDjLbq5RhrBqfzwyp7DKlr65cswQ89KT4XlVHN7LU+7lC\n\tMU9GbQDmW7Ksp5u2TUFKm/0Bal3F4k9Aq22N5eO71g2wxE6fHOZTM6AIVmJxxfslRjMa\n\tQFKtFGSC7EyHtO4NwDz2jSts04XNduUuY6lEkbBK6ldI6s616BAdnoHxCNhYiXh/2loN\n\tVCKr1UGFremJvoREeuHdSmsTwaPzeRdV2OEjMPEY3d+xZYv0WIzK5fm4l+zRF+dpH4Ih\n\tmUmA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=s/HYy3aySFTeYwe0B2XB8aV0coXSY3WEqyhGPqGM+Og=;\n\tb=qtk2h/bcn83c+qGg6Z1CybQ7JWIPZLkLQCrjZxiXm7Ncqlx9qc1GQOARTS/MNS8sHO\n\t+fZaK3xgXl7PxNxDmPfQcBG9L27xXoH/O/RVOGirCfVtI1zhXwrEukaNu9dzAFHurpuB\n\tgolJTjRQaWXgoQFDKeKns03Qs9z6N49UXgEstUYOklhARyoi+ClzKZq4EIZ0EKFrcEDw\n\tqddem2VTYATLJS4wr027ScOusBWQgZHTcQf4EL7TesUYKD1i04t3rw0VRTQgzXSIMkWS\n\t3oJs6zehXcfhAGqz53o9x19tQOPET6C93vGqRWuGTlv9p8DjUv4b6YqmVtAFLNvuaYbQ\n\tpP4w==", "X-Gm-Message-State": "AOAM533KCTl4yJZR2cW/goUPMTVTee4KxCOcKOSbFlsMsNsQYtJbP8VH\n\tXL/CvDCBFIRexcBbImkvS5Bs//krWrlR/Q==", "X-Google-Smtp-Source": "ABdhPJyG6/62zYvLw4byu1NVtaaRnBhBMvfI8l/bw92rExtCYjy3OrzP5tigCW6+Vuewk4qZK9i+dA==", "X-Received": "by 2002:a7b:c0c4:: with SMTP id s4mr5113325wmh.9.1617123468663; \n\tTue, 30 Mar 2021 09:57:48 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 30 Mar 2021 17:57:42 +0100", "Message-Id": "<20210330165743.4924-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 0/1] Fix CameraSensor::sensorInfo by\n\tupdating VBLANK ControlInfo", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi everyone\n\nYou may recall a while back I raised a problem where\nCameraSensor::sensorInfo() produces incorrect min and max frame\nlengths, resulting in cameras running at incorrect framerates (and\nsometimes causing AGC wobbles). The reason was that the sensor's min\nand max vblanking can vary when the format is changed, and our\nControlInfo mechanism has no means of knowing that it needs to be\nupdated.\n\nWe discussed a number of alternatives - I think it's fair to say that\nthere weren't any obvious neat fixes at this time. Among the\nalternatives was that of updating the ControlInfos directly, and this\nhas to be run at some point after a new format is set, and before\nsensorInfo() uses the control ranges.\n\nAnyway, here is an implenentation of that scheme for folks to have a\nlook at and consider. What do we think, does it fix the problem\nsufficiently, or are there better alternatives? Opinions welcome!\n\nThanks\n\nDavid\n\nDavid Plowman (1):\n libcamera: camera_sensor: Fix frame lengths calculated by sensorInfo()\n\n include/libcamera/internal/v4l2_device.h | 2 ++\n src/libcamera/camera_sensor.cpp | 7 +++++++\n src/libcamera/v4l2_device.cpp | 26 ++++++++++++++++++++++++\n 3 files changed, 35 insertions(+)" }