Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/11625/?format=api
{ "id": 11625, "url": "https://patchwork.libcamera.org/api/1.1/covers/11625/?format=api", "web_url": "https://patchwork.libcamera.org/cover/11625/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210319130120.141563-1-jacopo@jmondi.org>", "date": "2021-03-19T13:01:17", "name": "[libcamera-devel,v2,0/3] libcamera: Do not default the location property", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/11625/mbox/", "series": [ { "id": 1804, "url": "https://patchwork.libcamera.org/api/1.1/series/1804/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1804", "date": "2021-03-19T13:01:17", "name": "libcamera: Do not default the location property", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1804/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/11625/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2ACE8C32E1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Mar 2021 13:00:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87FED68D63;\n\tFri, 19 Mar 2021 14:00:53 +0100 (CET)", "from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B77B968D5E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Mar 2021 14:00:52 +0100 (CET)", "from uno.homenet.telecomitalia.it\n\t(host-79-22-58-175.retail.telecomitalia.it [79.22.58.175])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id B91F324000D;\n\tFri, 19 Mar 2021 13:00:51 +0000 (UTC)" ], "X-Originating-IP": "79.22.58.175", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 19 Mar 2021 14:01:17 +0100", "Message-Id": "<20210319130120.141563-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.30.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 0/3] libcamera: Do not default the\n\tlocation property", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello\n we've been discussion about how to handle the camera location\nproperly in libcamera and Android HAL.\n\nThe current setup\n- defaults location to External in libcamera if the fw does not provide that\n- sets FRONT if location is External in Android Camera HAL\n\nThis will make very complex to discern in future if a camera is actually\nexternal once the camera HAL will support the EXTERNAL HW level.\n\nTo simplify this and make it easier to fallback to a getting location from\na configuration file in the Camera HAL:\n- Do not report property::Location in libcamera if not available in fw\n- Do not default External to FRONT in HAL\n- To maintain compatibility with Android set location to FRONT if not available\n from the library in the Camera HAL.\n\nNo regressions in CTS testing.\n\nv1->v2:\n- Add a patch for cam not to assume Location is available. The naming\n scheme now looks like (Soraka)\n\n\tAvailable cameras:\n\t1: 'ov13858' (\\_SB_.PCI0.I2C2.CAM0)\n\t2: 'ov5670' (\\_SB_.PCI0.I2C4.CAM1)\n\n While it was:\n\tAvailable cameras:\n\t1: Internal front camera (\\_SB_.PCI0.I2C2.CAM0)\n\t2: Internal front camera (\\_SB_.PCI0.I2C4.CAM1)\n\n- Patch 3/3 said\n \"To maintain compatibility with CTS requirements, default location to\n FRONT only if the camera property is not available.\"\n Well, that hunk was missing in v1, sorry about that. I've kept Laurent's tag\n anyhow. Let me know if it's ok.\n\nThanks\n j\n\n\nJacopo Mondi (3):\n cam: Do not assume Location is available\n libcamera: camera_sensor: Do not register Location if not available\n android: camera_device: Do not default External to Front\n\n src/android/camera_device.cpp | 12 +++++++-----\n src/cam/main.cpp | 32 ++++++++++++++++++++------------\n src/libcamera/camera_sensor.cpp | 6 ++----\n 3 files changed, 29 insertions(+), 21 deletions(-)\n\n--\n2.30.0" }