Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/11528/?format=api
{ "id": 11528, "url": "https://patchwork.libcamera.org/api/1.1/covers/11528/?format=api", "web_url": "https://patchwork.libcamera.org/cover/11528/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210309063829.8710-1-dafna.hirschfeld@collabora.com>", "date": "2021-03-09T06:38:26", "name": "[libcamera-devel,v3,0/3] rkisp1: add an initial support to different hw revision", "submitter": { "id": 46, "url": "https://patchwork.libcamera.org/api/1.1/people/46/?format=api", "name": "Dafna Hirschfeld", "email": "dafna.hirschfeld@collabora.com" }, "mbox": "https://patchwork.libcamera.org/cover/11528/mbox/", "series": [ { "id": 1775, "url": "https://patchwork.libcamera.org/api/1.1/series/1775/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1775", "date": "2021-03-09T06:38:27", "name": "rkisp1: add an initial support to different hw revision", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1775/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/11528/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30418BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 9 Mar 2021 06:38:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD4AA68A92;\n\tTue, 9 Mar 2021 07:38:39 +0100 (CET)", "from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCA26602E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 9 Mar 2021 07:38:37 +0100 (CET)", "from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: dafna) with ESMTPSA id 2B8D81F45215" ], "From": "Dafna Hirschfeld <dafna.hirschfeld@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 9 Mar 2021 07:38:26 +0100", "Message-Id": "<20210309063829.8710-1-dafna.hirschfeld@collabora.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[libcamera-devel] [PATCH v3 0/3] rkisp1: add an initial support to\n\tdifferent hw revision", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "kernel@collabora.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In kernel v5.11 the rkisp1 uapi had changed to support\ndifferent hardware versions. See [1].\nCurrently only version 10 is supported, therefore the IPA\nshould fail on 'init' if the revision is not 10.\nIn the future we want to add support for version V12.\nSee revisions documentation at [2].\n\nChanges from v1:\n- compilation fix in patch 3 that I forgot to update in first version\n- typo fixes\n- in patch 2, if 'configure' of the rkisp1 IPA fails return -EINVAL\n- in patch 3, if hw revision is not supported, return -ENODEV\n\nChanges from v2:\n- in patch 1: add doxygen documentation for the new function hwRevision\n- in patch 2: small typo fix\n- in patch 3:\n* the revision check is moved from the function 'configure' to the function 'init'.\n* remove uapi header update and support for v10 since it is already done in a different patchset\n\nDafna Hirschfeld (3):\n libcamera: media_device: add hwRevision method\n src: rkisp1: return error from ipa's configure method if it fails\n ipa: rkisp1: fail on init if hw revision is not RKISP1_V10\n\n include/libcamera/internal/media_device.h | 2 ++\n include/libcamera/ipa/rkisp1.mojom | 4 ++--\n src/ipa/rkisp1/rkisp1.cpp | 28 +++++++++++++++--------\n src/libcamera/media_device.cpp | 10 ++++++++\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 17 +++++++-------\n 5 files changed, 42 insertions(+), 19 deletions(-)" }