Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/10922/?format=api
{ "id": 10922, "url": "https://patchwork.libcamera.org/api/1.1/covers/10922/?format=api", "web_url": "https://patchwork.libcamera.org/cover/10922/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210121115849.682130-1-naush@raspberrypi.com>", "date": "2021-01-21T11:58:45", "name": "[libcamera-devel,0/4] Raspberrypi: FrameDurations control refinements", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/10922/mbox/", "series": [ { "id": 1591, "url": "https://patchwork.libcamera.org/api/1.1/series/1591/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1591", "date": "2021-01-21T11:58:45", "name": "Raspberrypi: FrameDurations control refinements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1591/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/10922/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49DA6C0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Jan 2021 11:58:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CFA26681E5;\n\tThu, 21 Jan 2021 12:58:55 +0100 (CET)", "from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 236C868193\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Jan 2021 12:58:54 +0100 (CET)", "by mail-wr1-x429.google.com with SMTP id b5so1445069wrr.10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Jan 2021 03:58:54 -0800 (PST)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\th13sm8044930wrm.28.2021.01.21.03.58.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 21 Jan 2021 03:58:52 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"FqcaL8I/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=iMeO0jsi8Q9BIZe3db/m0dYlPNHtvZyBa7aNCKNjd70=;\n\tb=FqcaL8I/DzE2rEmGSzSU1UOK9PXtmThWg8fd3InrLpz80+VPZMqHGj8KZ/0EfrOdmo\n\tSoMZVlPDGzQ27N1oYQOud2nGJ/QXgh7PVydb7ksPQeaLuCU470Pdq3WVaMk+M7Nc2Ppw\n\ta2XGVNNdqsUmcwKXVeGhY8LCxHQRF7V8U92zb4PlprVoaNOoktkxFOhPGey4BlES4vWm\n\tWnAZg495ssDNPBdzQKhGrjh/ZqQta32sKTeFvb0pWBHs/J/ww5Eg53kmR7Rgm1dtOZx5\n\tG/RhQKPHYrk7MRhACmwqvN+BI16rSqF7MRKJh9IAQGYfXcKVFCJD0JRN0jSewdL0WiWB\n\tqJ3Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=iMeO0jsi8Q9BIZe3db/m0dYlPNHtvZyBa7aNCKNjd70=;\n\tb=IdEX1TwvnDy1zlHK370LPso3sKpX6X+fkghpWcNMLrcOzoeCaQs84HAjfASOxEXvKd\n\tifZDRtymmale2w3fCElcDblEfEAkDXkKCHzjmmANiUZ+QgEtNyOjIBpP1wqS1LJx3qFk\n\tUD+RVXs8f2o5vJyVbyV+jm2zftuzRKxmpKrogYq9GRl5tycYLyPG1c6glQrUFuhR+Mp6\n\tacEKyn4BcYytJtZMMdlrO/ZihG6iUq0go5uSm5yi+cyyaDVGXYTLrq5TUurl6GapOXUj\n\t76QULgJ6utcbqbEKiCPOVucgB687LmExlq705Awc5uB7yw51Vtw5ynZGiHW/HGorzOWf\n\t1Iiw==", "X-Gm-Message-State": "AOAM533QJfKRznHUowoMnftXwTrit1Qn2TAOCEljPLQkxVm7+C7qqbhM\n\tpiMO4QUGuySx8zWNHsMvTkorePC0oHvUXg==", "X-Google-Smtp-Source": "ABdhPJw7ajAUSdqmARvu+3GzFMuKCg3HaMiamlQPWspNe933HCQfyHvRR6N5Q2Tiv58NFk5p+MmTlw==", "X-Received": "by 2002:adf:fdcc:: with SMTP id\n\ti12mr13719805wrs.317.1611230333474; \n\tThu, 21 Jan 2021 03:58:53 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 21 Jan 2021 11:58:45 +0000", "Message-Id": "<20210121115849.682130-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 0/4] Raspberrypi: FrameDurations control\n\trefinements", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi,\n\nI'm sure you all have had enough fatigue with frame rate patches from me, so just to make your day even better, here are some more :-)\n\nThis set of patches address feedback points raised for the previous patch set. As discussed, these changes have been in my back pocket for a while, I just wanted to wait for the previous series to be merged before introducing them.\n\nSome further details:\nPatch 1/4 fixes a small issue where we get a warning log point when the control values get initialised.\n\nPatch 2/4 clamps application provided frame duration with what the sensor mode can support. It also addresses the \\todo to return out the clamped values in metadata.\n\nPatch 3/4 links the maximum frame duration with AGC. The AGC now knows what the maximum allowable shutter speed is, so it can do the relevant calculations more optimally.\n\nPatch 4/4 might need a bit more context. It works around the problem of setting VBLANK and EXPOSURE through V4L2 at the same time. Of course, StaggeredCtrl is going to be deprecated, but it does provide an idea of what to do in DelayedCtrl to fix the problem. Depending on how things go, DelayedCtrl may be merged before this. In this case, patch 4/4 does not need merging, and the functionality in this change should eventually be ported across. Either way, there is no hard restriction on DelayedCtrl to have this in place straight away, as the Raspberry Pi will just about cope without it to start with - you may notice ever so slight AGC oscillations if you look for them.\n\nAs always, any and all feedback is appreciated.\n\nMany thanks,\nNaush\n\nNaushir Patuck (4):\n raspberrypi: Add the correct integer const postfix for FrameDurations\n ipa: raspberrypi: Limit the calculated vblank based on the sensor mode\n ipa: raspberrypi: Pass the maximum allowable shutter speed into the\n AGC\n pipeline: raspberrypi: Add notion of immediate write to StaggeredCtrl\n\n include/libcamera/ipa/raspberrypi.h | 2 +-\n src/ipa/raspberrypi/cam_helper.cpp | 16 ++---\n src/ipa/raspberrypi/cam_helper.hpp | 5 +-\n src/ipa/raspberrypi/cam_helper_imx219.cpp | 6 +-\n src/ipa/raspberrypi/cam_helper_imx477.cpp | 4 +-\n src/ipa/raspberrypi/cam_helper_ov5647.cpp | 4 +-\n .../raspberrypi/controller/agc_algorithm.hpp | 1 +\n src/ipa/raspberrypi/controller/camera_mode.h | 2 +\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 49 +++++++++----\n src/ipa/raspberrypi/controller/rpi/agc.hpp | 2 +\n src/ipa/raspberrypi/raspberrypi.cpp | 68 ++++++++++++++-----\n .../pipeline/raspberrypi/raspberrypi.cpp | 11 ++-\n .../pipeline/raspberrypi/staggered_ctrl.cpp | 39 ++++++++---\n .../pipeline/raspberrypi/staggered_ctrl.h | 3 +-\n 14 files changed, 142 insertions(+), 70 deletions(-)" }