Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/10697/?format=api
{ "id": 10697, "url": "https://patchwork.libcamera.org/api/1.1/covers/10697/?format=api", "web_url": "https://patchwork.libcamera.org/cover/10697/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201223121055.14178-1-sebastian.fricke.linux@gmail.com>", "date": "2020-12-23T12:10:53", "name": "[libcamera-devel,0/2] Improve BayerFormat class", "submitter": { "id": 73, "url": "https://patchwork.libcamera.org/api/1.1/people/73/?format=api", "name": "Sebastian Fricke", "email": "sebastian.fricke.linux@gmail.com" }, "mbox": "https://patchwork.libcamera.org/cover/10697/mbox/", "series": [ { "id": 1542, "url": "https://patchwork.libcamera.org/api/1.1/series/1542/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1542", "date": "2020-12-23T12:10:53", "name": "Improve BayerFormat class", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1542/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/10697/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9130BC0F1A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 23 Dec 2020 12:11:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1879B615AC;\n\tWed, 23 Dec 2020 13:11:11 +0100 (CET)", "from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n\t[IPv6:2a00:1450:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09F1360527\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 23 Dec 2020 13:11:10 +0100 (CET)", "by mail-wr1-x42d.google.com with SMTP id 91so18429529wrj.7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 23 Dec 2020 04:11:09 -0800 (PST)", "from basti.fritz.box\n\t(p200300d1ff2be200e1a8f8b471c12212.dip0.t-ipconnect.de.\n\t[2003:d1:ff2b:e200:e1a8:f8b4:71c1:2212])\n\tby smtp.gmail.com with ESMTPSA id\n\tu6sm36787733wrm.90.2020.12.23.04.11.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 23 Dec 2020 04:11:09 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"d4yI+mo9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=erUm07r1r3kYPNrHMcRuSKsM2/7Z+DUp2hWPkZgynR0=;\n\tb=d4yI+mo98iqkuX9DTyUojkG3ZEy3MFaABGCg+jRmW8rO+LB7VHf24RRq1zWdw1ouzH\n\tY0teqoOfmg70fTPQ6F1ouFD81ciPG2JTHAKauq+6ojktgMyGq5wDxHxoVhIT5y4x56o0\n\tLgVtn1UkMZHQducPqwm5q2Mr+Fw1SynmWBK+NgU937OMlUGpADWFqX5vqjPjfMxtTAgr\n\tfmDkb27QECFtQBcsNUS6DBKERftuUJiql58Yfi37tUHMX85nZqhWQOlRESkay2ELXxMh\n\trHsPSlDEtFJ35siJWY/J4rh1qaO5zzITMx6g2mOYaL6u7Teh+I8x0xc/BbrxBk9TlIVV\n\tmfqQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=erUm07r1r3kYPNrHMcRuSKsM2/7Z+DUp2hWPkZgynR0=;\n\tb=S/3cCVSTS1iCaOC6X1+eoVkotoT8DRpzxtlz7jubqjOINsX9/maAlmi4BtKRrLoYTJ\n\taUKsRVxxGFqROvZsaETQ8FZcpzus/nwy/akU7RIA0iFoK2wDw+iIiqRcvS1rYYkIFbVH\n\tNH5ssGhyEApy9pvvIq0sUFTfcgBUwMaoCVUo+JqO8AwZUMIU6Uq4FSBPItp/Nf/9AG4h\n\tvYcjKZZkE818x8l1+Z4l3iCfjz5i6hj3JMsJ7548EP1qQT5WME2TSyhiW26sI5KIAqoL\n\tvXErMbdgWSoF/vg3zuOi+qqtHOtgiF6BHLggfRvoiHipqXfXJNXjn5IOGfZ94x4iKpiG\n\tLAog==", "X-Gm-Message-State": "AOAM5312oatq/kJlKQjh3Fh1aStqLAQ1vJ7liu+Z6H63hYd6Wp3zCGGT\n\t43SEm0TtqA15ELKcAGj8Jkdv7bAthDhsaA==", "X-Google-Smtp-Source": "ABdhPJyg0dtQUXGDEKwAxOhSQtWkIQf/yf6Wo9FVIDh4G0RS0O3v8dxoiMeCDvK8X1uWIqEkeY8Cog==", "X-Received": "by 2002:adf:f18a:: with SMTP id\n\th10mr30641233wro.244.1608725469726; \n\tWed, 23 Dec 2020 04:11:09 -0800 (PST)", "From": "Sebastian Fricke <sebastian.fricke.linux@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 23 Dec 2020 13:10:53 +0100", "Message-Id": "<20201223121055.14178-1-sebastian.fricke.linux@gmail.com>", "X-Mailer": "git-send-email 2.29.2", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 0/2] Improve BayerFormat class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch series adds unit-tests and the `fromV4L2PixelFormat` method\nto the BayerFormat class.\n\nI also wanted to discuss one alternative that I played around with.\nWe could maybe drop one of the two mapping tables and use the following\nlogic to get the map key from a mapped value.\n\n```\n#include <algorithm>\n...\nBayerFormat BayerFormat::fromV4L2PixelFormat(V4L2PixelFormat v4l2Format) const\n{\n auto it = std::find_if(\n bayerToV4l2.begin(),\n bayerToV4l2.end(),\n [v4l2Format](const auto& i) { return i->second == v4l2Format; }\n );\n if (it != bayerToV4l2.end())\n return it->first;\n\n return BayerFormat();\n}\n```\n\nSebastian Fricke (2):\n libcamera: Add the fromV4L2PixelFormat method\n test: Add unit tests for the BayerFormat class\n\n include/libcamera/internal/bayer_format.h | 1 +\n src/libcamera/bayer_format.cpp | 14 ++\n test/bayer_format.cpp | 154 ++++++++++++++++++++++\n test/meson.build | 1 +\n 4 files changed, 170 insertions(+)\n create mode 100644 test/bayer_format.cpp" }