From patchwork Tue Mar 24 09:41:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 3295 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A91B60414 for ; Tue, 24 Mar 2020 10:41:17 +0100 (CET) Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FD68308 for ; Tue, 24 Mar 2020 10:41:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1585042876; bh=kp4RgOS1YVp9bE542upXiAYHmEdxaecwpFrgQxjokws=; h=From:To:Subject:Date:From; b=qhI8ni6At1DsRDYWPFSW9JDju6oudnmqeq7dHVNqa4iy+kPfHcwfgGQhywtoUrS0M zkO2tTYFD266rhmiFIelAEVFx+JeMVeZuop2vbLyvp5dCkqPYmQxC6s7ngLpWQuVst +sB/YtaVNc9wV1q+rxnWHhLJQCAiEdYlYZK1nwdc= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 24 Mar 2020 11:41:12 +0200 Message-Id: <20200324094112.704-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] qcam: viewfinder: Print message to report format converter usage X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2020 09:41:17 -0000 Print an info message when initializing the viewfinder to report if the format converter is used or if zero-copy is enabled. This is useful to notify of a possible impact on performances. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/qcam/viewfinder.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp index c7c6d099dfba..df5ee5ee7b83 100644 --- a/src/qcam/viewfinder.cpp +++ b/src/qcam/viewfinder.cpp @@ -56,6 +56,11 @@ int ViewFinder::setFormat(const libcamera::PixelFormat &format, return ret; image_ = QImage(size, QImage::Format_RGB32); + + qInfo() << "Using software format conversion from" + << format.toString().c_str(); + } else { + qInfo() << "Zero-copy enabled"; } format_ = format;