From patchwork Tue Feb 11 08:50:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 2802 Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D033E6043C for ; Tue, 11 Feb 2020 09:52:15 +0100 (CET) Received: by mail-wr1-x441.google.com with SMTP id c9so11203082wrw.8 for ; Tue, 11 Feb 2020 00:52:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XT9QGHUjP7HVNJEwI5Rbt3JF/kduWzVHHnlHBMyvjIY=; b=MWzv0Iph9U/jgZqUPqGhvB2igj71tYKXmdWxcM9ycbE+w0tE7UvXEeg3XxtXyR1n+C Nr3VyXjUI1ydE/Ux21t8zqEE+V600o10xtykxabsl+VfxVjzujhO907TlDd4N4B1Trr7 KRryLp3K1x6Jmg/t1rc36Etswn1cdmVAcq3d1jWsvZn10Riu9IelHkaboj/lfS/ToJKk vr3ZQ/KUOJ66lbx1s+kzCpsfN/GmV/CSD2eJfizvLu+ZsRJ3XJZUJ9NDEYgv9wkMvT0z JYaM2fYEUQJzsEsNijLUsrKWTkNeHOaTlFtmIiYuutNZPIurZNkR7h9HAJDZE93fB/ut sQbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XT9QGHUjP7HVNJEwI5Rbt3JF/kduWzVHHnlHBMyvjIY=; b=TzoFbGt/6MLAbNf/QiiHyJefq24QjYh4Ys820QC62BEjTFAALobRQd68mJ2Mhtk9oz AvtVnK22qLhiwbKR4rRFMaXHWOQ3CVWSknPRp1tPjnn8fMnuDl7WBmlziIF/m3ga+yXk di7VARoRWFBEwoScwS55sbBvCuJ5e8nO9Y6fcst5s159KkW0/ddEZdvglfzZ6oqkjo9Q 9+S6xNjfAvTecOKSUfK/PimCuEk0iXR/UFNVv1wNKFGb801hqUMIh50OcF/l9JnpqeXf SfFm+1NE8tAadhExYMLTWX+3jMOPbGHnVRKGICOk7915/SmUXEgWoBXDLV/NS3iL80Ug k1hw== X-Gm-Message-State: APjAAAX2wSulVu5hFvotm9kzYN4FzOvpzYDVP2fJw5NXlHYRdLmQZhb5 ueFeI49F5qRun1GFIIDlfOTExKPNlh6u7w== X-Google-Smtp-Source: APXvYqxcTQ1l70y2KyCgb0a1mgpcjT5sDy4+bKSo2Vi8SjohiHDyRwSTiZH/v2WVx41sMtqghzAQyg== X-Received: by 2002:a5d:4702:: with SMTP id y2mr7049371wrq.37.1581411135221; Tue, 11 Feb 2020 00:52:15 -0800 (PST) Received: from naushir-VirtualBox.pitowers.org (cust51-dsl50.idnet.net. [212.69.50.51]) by smtp.gmail.com with ESMTPSA id a13sm4400386wrp.93.2020.02.11.00.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 00:52:14 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Tue, 11 Feb 2020 08:50:10 +0000 Message-Id: <20200211085010.10191-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2] qcam: Switch default stream role to viewfinder X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Feb 2020 08:52:16 -0000 qcam currently only displays a standard viewfinder. As such set the StreamRole parameter to Viewfinder so that the pipeline handlers can setup the appropriate resolutions and formats. Signed-off-by: Naushir Patuck Reviewed-by: Kieran Bingham Reviewed-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- src/qcam/main_window.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp index df51fa8..70a3e61 100644 --- a/src/qcam/main_window.cpp +++ b/src/qcam/main_window.cpp @@ -125,7 +125,7 @@ int MainWindow::startCapture() { int ret; - config_ = camera_->generateConfiguration({ StreamRole::VideoRecording }); + config_ = camera_->generateConfiguration({ StreamRole::Viewfinder }); StreamConfiguration &cfg = config_->at(0); if (options_.isSet(OptSize)) {