From patchwork Thu Oct 29 11:41:25 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 28664 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 02ADCC324C for ; Thu, 29 Oct 2026 11:41:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AA61469097; Thu, 29 Oct 2026 12:41:29 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="WvyZC7ew"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D575E68E07 for ; Thu, 29 Oct 2026 12:41:27 +0100 (CET) Received: from pb-laptop.local (185.221.143.99.nat.pool.zt.hu [185.221.143.99]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C16F4DC for ; Thu, 29 Oct 2026 12:39:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1793273954; bh=tsePh2g16N/sqrNS9VCKJ73TYcVD4hu/gUUfBue9tI0=; h=From:To:Subject:Date:From; b=WvyZC7ew8yHuUKshsrk52vO0LiytzWxR5SIoDMSBwhZF7LyH3QG3RlxJfCp4gAQcS 2gAYMWRzWZ4+buAtV3/02mRlfyG4M77hXuteY0e14yz14R62Srpu+toduJYd67ujQz 1OEz91VKqehrIR1Ye/PbRjYwwoW6ioWd6gmTmB3A= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1] ipa: libipa: awb: Do not ignore initialization errors Date: Thu, 29 Oct 2026 12:41:25 +0100 Message-ID: <20261029114125.152164-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.56.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Propagate the return value from `AwbAlgorithmBase::init()` instead of silently ignoring it. Signed-off-by: Barnabás Pőcze Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- src/ipa/libipa/awb.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/ipa/libipa/awb.h b/src/ipa/libipa/awb.h index ef9e78b1e8..9952556f4c 100644 --- a/src/ipa/libipa/awb.h +++ b/src/ipa/libipa/awb.h @@ -115,7 +115,9 @@ class AwbAlgorithm : public AwbAlgorithmBase public: int init(const ValueNode &tuningData, ControlInfoMap::Map &controls) { - AwbAlgorithmBase::init(tuningData); + int ret = AwbAlgorithmBase::init(tuningData); + if (ret) + return ret; gainMin_ = std::max(Q::TraitsType::min, 1.0f); gainMax_ = Q::TraitsType::max;