From patchwork Fri Oct 9 19:32:45 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 28428 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 802EDBDCB6 for ; Fri, 9 Oct 2026 19:32:58 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7CF0368A13; Fri, 9 Oct 2026 21:32:57 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="hQfY1OHu"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 184C3689CD for ; Fri, 9 Oct 2026 21:32:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1791574371; cv=none; d=zohomail.com; s=zohoarc; b=L+5pVy/yU3hHmfbce7KWrYiHpHwcn10ot/IDSAi+Ef3rSPOc6DeVxsEtm2X9ANXFP8Tz+yXMaJVYsuEaZxpFBAt99IIaLzxB0O42Oh05Bhkbf3eCcxAYcVBh4oz+FK0MKLlWfHjv5vFYIEUKvchcj1Ld7xt75ClDQW8f3J5nuDk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791574371; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=xsb20camAUanQSTruBDKBQ4W4XmdGz5CXiZVS1TGcPQ=; b=lsjcE5nY5D8spYvwoZpJQTV7HID9u2Rkd6Tjz6Ow+Bz1P684LKcsBxHkfIUeFSUlYfiymY4PZo3ev3/luJrOxpKDRN0q+bREGZzrVCYdXtlpwfg1OncP014FeQPwKhzNi16u6rXjARotGmqFC66psHFDaYYNF+gPfkn6GCElj7Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1791574371; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=xsb20camAUanQSTruBDKBQ4W4XmdGz5CXiZVS1TGcPQ=; b=hQfY1OHunRt2pmHtIfCpo7tr+7Suei2vbXHi+mh6DgFXnREI/jcsXRk/xOymAobv 4uJ5ixukVWW7VarFXoHk3K8Jb90JmUBcejEH2u9HN0s9aAfysfECX1uotz67FxXJR46 qQixrty2AvCnxaB3YgSBXQXyyu8faOOOQ36gVc50= Received: by smtp.zohomail.com with SMTPS id 1791574371005515.1262874430352; Fri, 9 Oct 2026 12:32:51 -0700 (PDT) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader Subject: [PATCH v1] virtual: Implement framerate handling Date: Fri, 9 Oct 2026 21:32:45 +0200 Message-ID: <20261009193245.19325-1-robert.mader@collabora.com> X-Mailer: git-send-email 2.56.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Throttle requests to the minimal frame duration in order to honor the configured framerates. Client-requested values are ignored for now. Signed-off-by: Robert Mader --- Changes in v1 (from RFC version): - Use std::this_thread::sleep_for() instead usleep() (Barnabás) - Sleep only once per request, after generating all frames - Remove control handling in start() (defer that for later) - Reset state in stop() instead of start() --- src/libcamera/pipeline/virtual/virtual.cpp | 35 ++++++++++++++++++---- src/libcamera/pipeline/virtual/virtual.h | 1 + 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp index e25dd85a7391..8d63a39caca2 100644 --- a/src/libcamera/pipeline/virtual/virtual.cpp +++ b/src/libcamera/pipeline/virtual/virtual.cpp @@ -130,6 +130,9 @@ VirtualCameraData::VirtualCameraData(PipelineHandler *pipe, void VirtualCameraData::processRequest(Request *request) { + int64_t sensorTimestamp = *request->metadata().get(controls::SensorTimestamp); + std::vector buffers; + for (const auto &[stream, buffer] : request->buffers()) { bool found = false; /* map buffer and fill test patterns */ @@ -139,7 +142,7 @@ void VirtualCameraData::processRequest(Request *request) fmd.status = FrameMetadata::Status::FrameSuccess; fmd.sequence = streamConfig.seq++; - fmd.timestamp = currentTimestamp(); + fmd.timestamp = sensorTimestamp; std::span planes = buffer->planes(); for (const auto [i, p] : utils::enumerate(planes)) @@ -151,12 +154,22 @@ void VirtualCameraData::processRequest(Request *request) stream->configuration().size, buffer)) fmd.status = FrameMetadata::Status::FrameError; - bufferCompleted.emit(buffer); + buffers.push_back(buffer); break; } } ASSERT(found); } + + uint64_t now = currentTimestamp(); + if (now < static_cast(sensorTimestamp)) { + std::chrono::nanoseconds sleep(sensorTimestamp - now); + LOG(Virtual, Debug) << "Sleeping for ns: " << sleep; + std::this_thread::sleep_for(sleep); + } + + for (auto buffer : buffers) + bufferCompleted.emit(buffer); } VirtualCameraConfiguration::VirtualCameraConfiguration(VirtualCameraData *data) @@ -349,18 +362,30 @@ void PipelineHandlerVirtual::stopDevice(Camera *camera) /* Process pending `bufferCompleted` signals. */ thread()->dispatchMessages(Message::Type::InvokeMessage, this); data->bufferCompleted.disconnect(this); + data->lastTimestamp = 0; while (!data->queuedRequests_.empty()) cancelRequest(data->queuedRequests_.front()); } -int PipelineHandlerVirtual::queueRequestDevice([[maybe_unused]] Camera *camera, - Request *request) +int PipelineHandlerVirtual::queueRequestDevice(Camera *camera, Request *request) { VirtualCameraData *data = cameraData(camera); - const auto timestamp = currentTimestamp(); + uint64_t timestamp = currentTimestamp(); + uint64_t minFrameDurationNsec = + camera->controls().find(&controls::FrameDurationLimits)->second.min().get() * 1000; + + if (data->lastTimestamp) { + if (((timestamp - data->lastTimestamp) < minFrameDurationNsec) || + (timestamp < data->lastTimestamp)) + timestamp = data->lastTimestamp + minFrameDurationNsec; + } else { + timestamp += minFrameDurationNsec; + } request->_d()->metadata().set(controls::SensorTimestamp, timestamp); + data->lastTimestamp = timestamp; + data->invokeMethod(&VirtualCameraData::processRequest, ConnectionTypeQueued, request); diff --git a/src/libcamera/pipeline/virtual/virtual.h b/src/libcamera/pipeline/virtual/virtual.h index 215e56fa3b9d..84b53dfb66f3 100644 --- a/src/libcamera/pipeline/virtual/virtual.h +++ b/src/libcamera/pipeline/virtual/virtual.h @@ -66,6 +66,7 @@ public: std::vector streamConfigs_; Signal bufferCompleted; + uint64_t lastTimestamp = 0; }; } /* namespace libcamera */