From patchwork Sat Sep 26 12:56:46 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 28383 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 037FDBDCBC for ; Sat, 26 Sep 2026 12:57:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C6843689CA; Sat, 26 Sep 2026 14:57:17 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="K23e88dY"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B93E68615 for ; Sat, 26 Sep 2026 14:57:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1790427431; cv=none; d=zohomail.com; s=zohoarc; b=QL+nEgmfgerzUBbnOQnWgZJ8ENateOY2dthxArE99PMo5gWKy8h6fC86zBlb5eL683K1jra2ko1d106wgjZdFCLBA4sCDIy3n4ZJzxYcvvUaN+N+lTqOnHHB7Rd3uIGorJTPS3exdkwYM2KITXDBE8YpYTaJKSH54BPq8DLFb4g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790427431; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=zGWcHu/7qL7xi4TOC+muwzR9vPrmqzKMfi0ylE/X41o=; b=AO8i1O4n6nnpqotxffSbnbArhlnDSJdlni2RK5B4MIH5O4T9qIcRI2FRLKIB2P4f2k+qhSsjop5ZynkwSMk+DB7vonCiMpDLE/Cy9Kr40zIS9UqxTQApJONp1zE/dy25FOK3v/7p/RG4wIu8+OoCSCxoY7biTD0uj261Nd5t22A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1790427431; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=zGWcHu/7qL7xi4TOC+muwzR9vPrmqzKMfi0ylE/X41o=; b=K23e88dY89pZalMxtCmhJfgfcA7qfzkkkVIeRt05nl7S3OxRVtabeZL1FSQukN1E 5RsxY+oMdGGEYCzgZyStP+yKwRyI8zSS3H0SNXjeFh5rBeEc6xkZdSJwpIxyxNMLFJ5 DyVYpdcbbx+eaAry+e28u90Na/bLSX0OnsJdT3BI= Received: by smtp.zohomail.com with SMTPS id 1790427431499355.154836668912; Sat, 26 Sep 2026 05:57:11 -0700 (PDT) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader Subject: [PATCH v2] debayer: Further demote 'Unsupported input format' log Date: Sat, 26 Sep 2026 14:56:46 +0200 Message-ID: <20260926125646.47951-1-robert.mader@collabora.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" On some platforms such as the PinePhone these logs clutter the output of tools and the journal a lot. Let's silence them for normal usage. Also add error logs for the cases where hitting the path would actually be errors. Signed-off-by: Robert Mader --- Changes in v2: - Add error logs in callers --- src/libcamera/software_isp/debayer_cpu.cpp | 9 ++++++--- src/libcamera/software_isp/debayer_egl.cpp | 7 +++++-- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp index c6d5d1e1813b..ce8b3c647aee 100644 --- a/src/libcamera/software_isp/debayer_cpu.cpp +++ b/src/libcamera/software_isp/debayer_cpu.cpp @@ -470,8 +470,8 @@ int DebayerCpu::getInputConfig(PixelFormat inputFormat, DebayerInputConfig &conf return 0; } - LOG(Debayer, Info) - << "Unsupported input format " << inputFormat.toString(); + LOG(Debayer, Debug) + << "Unsupported input format " << inputFormat; return -EINVAL; } @@ -626,8 +626,11 @@ int DebayerCpu::configure(const StreamConfiguration &inputCfg, const std::vector> &outputCfgs, bool ccmEnabled) { - if (getInputConfig(inputCfg.pixelFormat, inputConfig_) != 0) + if (getInputConfig(inputCfg.pixelFormat, inputConfig_) != 0) { + LOG(Debayer, Error) + << "Unsupported input format " << inputCfg.pixelFormat; return -EINVAL; + } if (stats_->configure(inputCfg, threads_.size()) != 0) return -EINVAL; diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp index 4477c928342f..300822f9d1b2 100644 --- a/src/libcamera/software_isp/debayer_egl.cpp +++ b/src/libcamera/software_isp/debayer_egl.cpp @@ -91,7 +91,7 @@ int DebayerEGL::getInputConfig(PixelFormat inputFormat, DebayerInputConfig &conf return 0; } - LOG(Debayer, Info) + LOG(Debayer, Debug) << "Unsupported input format " << inputFormat; return -EINVAL; @@ -275,8 +275,11 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg, const std::vector> &outputCfgs, [[maybe_unused]] bool ccmEnabled) { - if (getInputConfig(inputCfg.pixelFormat, inputConfig_) != 0) + if (getInputConfig(inputCfg.pixelFormat, inputConfig_) != 0) { + LOG(Debayer, Error) + << "Unsupported input format " << inputCfg.pixelFormat; return -EINVAL; + } if (stats_->configure(inputCfg) != 0) return -EINVAL;