From patchwork Thu Jul 9 11:30:55 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Scally X-Patchwork-Id: 27355 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 61A05C3306 for ; Thu, 9 Jul 2026 11:31:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5F242660DD; Thu, 9 Jul 2026 13:31:06 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CVGOmxeJ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F0A465FA2 for ; Thu, 9 Jul 2026 13:31:05 +0200 (CEST) Received: from [127.0.1.1] (chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net [82.19.20.230]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BEBD6448; Thu, 9 Jul 2026 13:30:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1783596614; bh=99R7e6D0xuuNUs67P0RJ1XvEHYoh+E4qiVJzW5D1wVU=; h=From:Date:Subject:To:Cc:From; b=CVGOmxeJRLsIHOxonndXv20nYAnlnh1o76F3gSMrKZCMJTYHdG6Wtz/Udbp58ttXd m/GgTRHOqGzQ3/D6kAIrj1+zfgrPRor1vnro2EIDG700Tipfl44En5Z6xHyFfcfSQv sxwABPTgWQiDDc2K52Pb9aV1smHYvFEBAcDDrjjY= From: Daniel Scally Date: Thu, 09 Jul 2026 12:30:55 +0100 Subject: [PATCH] ipa: camera_sensor_helper: Add black levels for OV5693 MIME-Version: 1.0 Message-Id: <20260709-ov5693-v1-1-a17e72273f43@ideasonboard.com> X-B4-Tracking: v=1; b=H4sIAG6GT2oC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDMyML3fwyUzNLY11zY9PURIMUy8SUVEMloOKCotS0zAqwQdGxtbUAdSw IuFgAAAA= X-Change-ID: 20260628-ov5693-735ea0d9ade1 To: libcamera-devel@lists.libcamera.org Cc: Daniel Scally X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=999; i=dan.scally@ideasonboard.com; h=from:subject:message-id; bh=99R7e6D0xuuNUs67P0RJ1XvEHYoh+E4qiVJzW5D1wVU=; b=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBqT4Z4UyX6W5H8njqn2fBpBIuYEbpdNH8nrv2OB MeEQWFp1WKJAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCak+GeAAKCRDISVd6bEV1 Mjn3D/0WROiUXBaZ5oRNmM/SDLe6GBkmFz71EjSX3YjjHM7PG5u0TC0I7pIKB2ptEFEXYeLDAzl G2E8uT9reLt3S7GXPSnfVERboM4n/JaCuQ6fVPDQPGwxTLiRIvVZezk025GgcqBm7H7FGvv6NIz FQ8tcgka10z7kjX4lx1nDW0pg1R0ESOJZ0uWNSQrdw6GoQi73kCPizQ0sCkyniZkensqVKJb8GX 1MwyolT5ED0lk771SDC+dX3Zgs1hgDjLO06hQGwZrSRmEQyWPYdib20CMdNo+Ywvmy3k+8a46qQ Tpqv3EYYsnKbbGYyrGX3HSYwwiZKw8xk+bv1DOnzGa26zaUsWwxABNJ5kbaeSUSkundYsWofK6q 6L16uH1L6o/CAdo9M6lU+UMoLX//mRhsYRh82huGTUYWi1i20nUAbRpzL90W1+hznq6Z8TkNFNe +xJbk4B073FRJcHW51axoqBL+QIsfgdIPX5gwk5qKhKqlWm0TXTbmhuDLBnKjuVgbKM3K6kg2Zn 3Ef0tErMoqVsFTXntuJiN7+4vgPwKJy4NETcrRUYXt+Ks9Rsga3CSzYmFxzaHNDO6IdFQbw1MpQ eq0TJbgXLKtZbWuYuwOF0/+2MsYbs9hJlJhKnXlB4ta+0iay+u0q32nz9qFRadZUsyP8/MtTgNN rilUeRSNOPgcXHw== X-Developer-Key: i=dan.scally@ideasonboard.com; a=openpgp; fpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The OmniVision OV5693 sensor has a configurable data pedestal that is set by default to 0x10 for 10-bit data. Add the 16-bit representation of that level to CameraSensorHelperOv5693. Signed-off-by: Daniel Scally Reviewed-by: Kieran Bingham --- src/ipa/libipa/camera_sensor_helper.cpp | 1 + 1 file changed, 1 insertion(+) --- base-commit: 32b0d940baaf182a9d01d4833e30bd340d4dc918 change-id: 20260628-ov5693-735ea0d9ade1 Best regards, diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 9ab7a52f2644c93454520f0a20a4c3e370ce9d15..b73ecae6c1d010aad7a49cb3c1d75b4caad97c01 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -752,6 +752,7 @@ class CameraSensorHelperOv5693 : public CameraSensorHelper public: CameraSensorHelperOv5693() { + blacklevel_ = 1024; gain_ = AnalogueGainLinear{ 1, 0, 0, 16 }; } };