From patchwork Sat Jan 4 06:00:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 2513 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 85DD960461 for ; Sat, 4 Jan 2020 07:00:46 +0100 (CET) Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 022C1A49 for ; Sat, 4 Jan 2020 07:00:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1578117646; bh=FyalGOSqD/0Ddg2IVA1FHmOG4H3+KApUKAambj0u6wE=; h=From:To:Subject:Date:From; b=TGLDs15MyUh0G02gIYP7fWWP2Ab0YIkvbGxVnByf6EJPymxBoSZQiD8cpl7W26oDY oGSgYJmOKyc9i2oT6Y2VOpXFPrqk2jwx/kZ1qBZpN+ZKxZfuSzpvUx89Kqx4pGtaR1 3RHCAt4+lgcDHco71ZF5s6Ypt5VPDyINyTgqiBeM= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Sat, 4 Jan 2020 08:00:31 +0200 Message-Id: <20200104060031.17140-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: control_serializer: Initialize serial_ X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jan 2020 06:00:46 -0000 The ControlSerializer::serial_ member variable isn't initialized. Add a constructor to the class to initialize it. Signed-off-by: Laurent Pinchart Reviewed-by: Niklas Söderlund --- src/libcamera/control_serializer.cpp | 5 +++++ src/libcamera/include/control_serializer.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp index b787655e6769..a5d6d875c76f 100644 --- a/src/libcamera/control_serializer.cpp +++ b/src/libcamera/control_serializer.cpp @@ -84,6 +84,11 @@ static constexpr size_t ControlValueSize[] = { * proceed with care to avoid stale references. */ +ControlSerializer::ControlSerializer() + : serial_(0) +{ +} + /** * \brief Reset the serializer * diff --git a/src/libcamera/include/control_serializer.h b/src/libcamera/include/control_serializer.h index bb3cb8e7b904..55259913a2ca 100644 --- a/src/libcamera/include/control_serializer.h +++ b/src/libcamera/include/control_serializer.h @@ -20,6 +20,8 @@ class ByteStreamBuffer; class ControlSerializer { public: + ControlSerializer(); + void reset(); static size_t binarySize(const ControlInfoMap &info);