From patchwork Tue May 12 13:45:05 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 26735 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 719DBBDB1C for ; Tue, 12 May 2026 13:45:21 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7C9986302E; Tue, 12 May 2026 15:45:18 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="N29FdFg/"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C933362FEA for ; Tue, 12 May 2026 15:45:16 +0200 (CEST) Received: from [192.168.1.7] (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9BAC41E5A; Tue, 12 May 2026 15:45:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1778593508; bh=eQnNTTlpzLv5JKLf2Jmscdmml78NL0b90WPZR/XJaIg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=N29FdFg/3WqKU3ZqxGpfv1qncaGMHM9fMhsg9oNsXQ9JSK6ZLHVKknPhi7xtElo3c SlIRUdfOcNn3sdJGEJ5BB1BJ9spvUK6Mb11N+HdMQP065uVAj26DlJTztuKP5kse/V IbgInb431auTBVXsanQ+t6RrC5t2cMM/WmZbA2UM= From: Jacopo Mondi Date: Tue, 12 May 2026 15:45:05 +0200 Subject: [PATCH v4 1/2] include: v4l2-isp: Update to support extensible stats MIME-Version: 1.0 Message-Id: <20260512-extensible-stats-v4-1-e0425f6171e2@ideasonboard.com> References: <20260512-extensible-stats-v4-0-e0425f6171e2@ideasonboard.com> In-Reply-To: <20260512-extensible-stats-v4-0-e0425f6171e2@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Antoine Bouyer Cc: Jacopo Mondi , Kieran Bingham X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=8888; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=eQnNTTlpzLv5JKLf2Jmscdmml78NL0b90WPZR/XJaIg=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqAy7rzN/TmKQ+eq237r+8fYOdPJ07oUvOnPJ3d hWxGTYkOz2JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCagMu6wAKCRByNAaPFqFW POgWD/9eqKwCeB8I797xW5ak3r5ijGQ2YIEyFSOL8wvOwt/ZlVeXqG9oZVZLhW/nei4oYEqPf94 F2WktmCOpR7cSTDLkFi5TEHaqtzbo2YGX34G2huyq9CT/csQXM/WYsOB9UKKBbHlWrNbfZynEkB 112ejkWyJ+zzUS13CC/nnq0AHqkjn3eu5EDTpslEWCjaoeUvo7DF397aNiXve7MNU0VEX4C00Cb NK7pRRUYNfIZES1PTGlJ7ksgFZeqXyLTKK55d6xkz4XN3uMhyIvkQrucWH4rwiGkh2bRRe+UzXB Qye2TspbNSurxo1tyPbOGrvvQr2SoY6dx0hZWGxEnr9BCDh6vZRq6kMtH+bogsMj2kzEimwXjoi pjyxd3uOCMGRt+EEnWQRJc2VVFfzk16HCNOWaAlUbKsdKh3u6tF/U4PzjPAL51aNT1Mj6YwZhxc 1g0JUmYID6kyOu4uZ9z3n89ovwfFcwPDcBX7a8QXUraK264QmiC5DzmoIubU/DGUnaCGoMaZvYQ 0QBD9jr4IJx9HDmw4T+GHdgAbB7Dt1olNHG5d7h2fcIemtWBHI99xCLu6BZJbM1M7+yJhMv6ZI2 TvNgPgrmR46XVmKFSCmPbOIbGzvLGJ0iPyqJyi4MprKSF02cgDIgsT2Q4UNNaER9KMJd07ZW987 tQpmfI/6QXR5S9g== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Update the v4l2-isp.h header to prepare to support extensible statistics. The new header version is generated from the following in-review patch series: https://patchwork.linuxtv.org/project/linux-media/patch/20260505-extensible-stats-v1-1-e16f326b8dad@ideasonboard.com/ Signed-off-by: Jacopo Mondi Acked-by: Kieran Bingham --- include/linux/media/v4l2-isp.h | 125 ++++++++++++++++++++++++++--------------- 1 file changed, 79 insertions(+), 46 deletions(-) diff --git a/include/linux/media/v4l2-isp.h b/include/linux/media/v4l2-isp.h index 0cfc4ab94967..60a716177d52 100644 --- a/include/linux/media/v4l2-isp.h +++ b/include/linux/media/v4l2-isp.h @@ -13,25 +13,33 @@ #include /** - * enum v4l2_isp_params_version - V4L2 ISP parameters versioning + * enum v4l2_isp_version - V4L2 ISP serialization format versioning * - * @V4L2_ISP_PARAMS_VERSION_V0: First version of the V4L2 ISP parameters format - * (for compatibility) - * @V4L2_ISP_PARAMS_VERSION_V1: First version of the V4L2 ISP parameters format + * @V4L2_ISP_VERSION_V0: First version of the V4L2 ISP serialization format + * (for compatibility) + * @V4L2_ISP_VERSION_V1: First version of the V4L2 ISP serialization format * * V0 and V1 are identical in order to support drivers compatible with the V4L2 - * ISP parameters format already upstreamed which use either 0 or 1 as their - * versioning identifier. Both V0 and V1 refers to the first version of the - * V4L2 ISP parameters format. + * ISP format already upstreamed which use either 0 or 1 as their versioning + * identifier. Both V0 and V1 refers to the first version of the V4L2 ISP + * serialization format. * - * Future revisions of the V4L2 ISP parameters format should start from the + * Future revisions of the V4L2 ISP serialization format should start from the * value of 2. */ -enum v4l2_isp_params_version { - V4L2_ISP_PARAMS_VERSION_V0 = 0, - V4L2_ISP_PARAMS_VERSION_V1 +enum v4l2_isp_version { + V4L2_ISP_VERSION_V0 = 0, + V4L2_ISP_VERSION_V1 }; +/* + * Compatibility with existing users of v4l2_isp_params which pre-date the + * introduction of v4l2_isp_stats. + */ +#define v4l2_isp_params_version v4l2_isp_version +#define V4L2_ISP_PARAMS_VERSION_V0 V4L2_ISP_VERSION_V0 +#define V4L2_ISP_PARAMS_VERSION_V1 V4L2_ISP_VERSION_V1 + #define V4L2_ISP_PARAMS_FL_BLOCK_DISABLE (1U << 0) #define V4L2_ISP_PARAMS_FL_BLOCK_ENABLE (1U << 1) @@ -39,64 +47,89 @@ enum v4l2_isp_params_version { * Reserve the first 8 bits for V4L2_ISP_PARAMS_FL_* flag. * * Driver-specific flags should be defined as: - * #define DRIVER_SPECIFIC_FLAG0 ((1U << V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(0)) - * #define DRIVER_SPECIFIC_FLAG1 ((1U << V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(1)) + * #define DRIVER_SPECIFIC_FLAG0 ((1U << V4L2_ISP_FL_DRIVER_FLAGS(0)) + * #define DRIVER_SPECIFIC_FLAG1 ((1U << V4L2_ISP_FL_DRIVER_FLAGS(1)) */ -#define V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(n) ((n) + 8) +#define V4L2_ISP_FL_DRIVER_FLAGS(n) ((n) + 8) /** - * struct v4l2_isp_params_block_header - V4L2 extensible parameters block header - * @type: The parameters block type (driver-specific) + * struct v4l2_isp_block_header - V4L2 extensible block header + * @type: The parameters or statistics block type (driver-specific) * @flags: A bitmask of block flags (driver-specific) - * @size: Size (in bytes) of the parameters block, including this header + * @size: Size (in bytes) of the block, including this header * - * This structure represents the common part of all the ISP configuration - * blocks. Each parameters block shall embed an instance of this structure type - * as its first member, followed by the block-specific configuration data. + * This structure represents the common part of all the ISP configuration or + * statistic blocks. Each block shall embed an instance of this structure type + * as its first member, followed by the block-specific configuration or + * statistic data. * * The @type field is an ISP driver-specific value that identifies the block - * type. The @size field specifies the size of the parameters block. + * type. The @size field specifies the size of the block, including this + * header. * - * The @flags field is a bitmask of per-block flags V4L2_PARAMS_ISP_FL_* and - * driver-specific flags specified by the driver header. + * The @flags field is a bitmask of per-block flags. If a block is used for + * configuration parameters this field can be a combination of + * V4L2_ISP_PARAMS_FL_* and driver-specific flags. If a block is used + * for statistics this fields is used to report optional + * driver-specific flags, if any. */ -struct v4l2_isp_params_block_header { +struct v4l2_isp_block_header { __u16 type; __u16 flags; __u32 size; } __attribute__((aligned(8))); /** - * struct v4l2_isp_params_buffer - V4L2 extensible parameters configuration - * @version: The parameters buffer version (driver-specific) - * @data_size: The configuration data effective size, excluding this header - * @data: The configuration data + * v4l2_isp_params_block_header - V4L2 extensible parameters block header + * + * Compatibility with existing users of v4l2_isp_params_block_header + * which pre-date the introduction of v4l2_isp_block_header. + */ +#define v4l2_isp_params_block_header v4l2_isp_block_header + +/** + * struct v4l2_isp_buffer - V4L2 extensible buffer + * @version: The extensible buffer version (driver-specific) + * @data_size: The data effective size, excluding this header + * @data: The configuration or statistics data * - * This structure contains the configuration parameters of the ISP algorithms, - * serialized by userspace into a data buffer. Each configuration parameter - * block is represented by a block-specific structure which contains a - * :c:type:`v4l2_isp_params_block_header` entry as first member. Userspace - * populates the @data buffer with configuration parameters for the blocks that - * it intends to configure. As a consequence, the data buffer effective size - * changes according to the number of ISP blocks that userspace intends to - * configure and is set by userspace in the @data_size field. + * This structure contains ISP configuration parameters or ISP hardware + * statistics serialized into a data buffer. Each block is represented by a + * block-specific structure which contains a :c:type:`v4l2_isp_block_header` + * entry as first member. * - * The parameters buffer is versioned by the @version field to allow modifying - * and extending its definition. Userspace shall populate the @version field to - * inform the driver about the version it intends to use. The driver will parse - * and handle the @data buffer according to the data layout specific to the - * indicated version and return an error if the desired version is not + * When used for ISP parameters, userspace populates the @data buffer with + * configuration parameters for the blocks that it intends to configure. As a + * consequence, the data buffer effective size changes according to the number + * of ISP blocks that userspace intends to configure. + * + * When used to report ISP statistics, the driver populates the @data buffer + * with statistics for each supported measurement block. + * + * The buffer is versioned by the @version field to allow modifying + * and extending its definition. The writer shall populate the @version field + * to inform the reader about the version it intends to use. The reader will + * parse and handle the @data buffer according to the data layout specific to + * the indicated version and return an error if the desired version is not * supported. * - * For each ISP block that userspace wants to configure, a block-specific - * structure is appended to the @data buffer, one after the other without gaps - * in between. Userspace shall populate the @data_size field with the effective - * size, in bytes, of the @data buffer. + * For each ISP block, a block-specific structure is appended to the @data + * buffer, one after the other without gaps in between. The writer shall + * populate the @data_size field with the effective size, in bytes, of the + * @data buffer. */ -struct v4l2_isp_params_buffer { +struct v4l2_isp_buffer { __u32 version; __u32 data_size; __u8 data[] __counted_by(data_size); }; +/** + * v4l2_isp_params_buffer - V4L2 extensible parameters compatibility + * + * Compatibility with existing users of v4l2_isp_params_buffer which + * pre-date the introduction of v4l2_isp_buffer. + */ +#define v4l2_isp_params_buffer v4l2_isp_buffer + #endif /* _V4L2_ISP_H_ */ From patchwork Tue May 12 13:45:06 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 26736 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 792F5C32F7 for ; Tue, 12 May 2026 13:45:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E69746302C; Tue, 12 May 2026 15:45:19 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="atA7xAR5"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 09D4C6271A for ; Tue, 12 May 2026 15:45:17 +0200 (CEST) Received: from [192.168.1.7] (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id ED154243E; Tue, 12 May 2026 15:45:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1778593509; bh=AzzSi2gpxUUj3ll8LbdCwMWxALEnriAqD3AoNr6nrwg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=atA7xAR5iC7lV6a8usDeEG+YdfFoLs72kFumAtreofLnru5wWd0NDXYqvywZFhQmT 4FhbBwvuW6h/iuYo6qIeQiPePxulMipAnQ1uEpOlmtMWszK/KQ/1DclHHwjv271jhw FsdE5mCQn8mY0b+uVzs3Ll4InOhv6gJmYLg1a44k= From: Jacopo Mondi Date: Tue, 12 May 2026 15:45:06 +0200 Subject: [PATCH v4 2/2] ipa: libipa: Introduce V4L2Stats MIME-Version: 1.0 Message-Id: <20260512-extensible-stats-v4-2-e0425f6171e2@ideasonboard.com> References: <20260512-extensible-stats-v4-0-e0425f6171e2@ideasonboard.com> In-Reply-To: <20260512-extensible-stats-v4-0-e0425f6171e2@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Antoine Bouyer Cc: Jacopo Mondi , Kieran Bingham X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=10305; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=AzzSi2gpxUUj3ll8LbdCwMWxALEnriAqD3AoNr6nrwg=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqAy7rvXhrwdOHpcDo2sQGsto2e6kiCs6Ym4uLG Hn38w7bGtyJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCagMu6wAKCRByNAaPFqFW PPK3D/4qytS7orTk9wL+1QJ3ZRxCqWI99uNRzRHub4/boDHewoDmNksISsDSsSDrJHVL52ON3G/ /HWgyfy1IiPIJ3LPSZX252yHZCJLQlcIsPgYo/3FPNK6wBgqzf+w840fLUvSqETAw2DNP7Gb7Fl tAh8bC3yn3rXkAX+EqXYLwCe26R7/FqSA7HQnBzE/qm0XThRRQ0pUMrrZATAt6xkKNjt6B5Ez4j vel2WYZMqFP8aufv29+YyBeFJZqOeSmosg7poJo5S88utqwZiDgOtJ0c3X8DiwQYMAW6kcwLFrk aVr9AgUPKir1pigGqMZvjY2+LuN64xijxmHxfZ66gOGMFXfUBlw9hVJMRx9ow8igJsXk/oed+hr NuM9Bx8/u1u7DUpCN72zn832LRP4INiwNfYqTyAAkik+MMzZJlEyJ8761S2vDak9OWKC/2lKX6F xAAXnBo06k2e3vLObp6+184AiCAUtLUStKRSAH1+srtD88GPBeY03ua+7F4qNVkv4oE8eAZDbbO Xy13JgCoB/D7ticPR/5PLL2PngtKQZPJkoYWwP7k02BpzJhMmabCz0J2j6YmT2jxX4lhGs5bSEi Cd/JEDoqvf37pSlTDvzLS8lUubJy3q+Xqi2a/m8AUV1vAQQR14/E9Tvay6V6Bk37eEJoYo7XMtY WCcIeo6QSeb1JfQ== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add a V4L2Stats class similar in spirit to the existing V4L2Params class to allow IPA modules to easily sub-class it to access ISP statistics blocks serialized into a v4l2_isp_buffer. Signed-off-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- src/ipa/libipa/meson.build | 2 + src/ipa/libipa/v4l2_stats.cpp | 243 ++++++++++++++++++++++++++++++++++++++++++ src/ipa/libipa/v4l2_stats.h | 67 ++++++++++++ 3 files changed, 312 insertions(+) diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build index 963c5ee73063..16f4b095f220 100644 --- a/src/ipa/libipa/meson.build +++ b/src/ipa/libipa/meson.build @@ -19,6 +19,7 @@ libipa_headers = files([ 'pwl.h', 'quantized.h', 'v4l2_params.h', + 'v4l2_stats.h', ]) libipa_sources = files([ @@ -40,6 +41,7 @@ libipa_sources = files([ 'pwl.cpp', 'quantized.cpp', 'v4l2_params.cpp', + 'v4l2_stats.cpp', ]) libipa_includes = include_directories('..') diff --git a/src/ipa/libipa/v4l2_stats.cpp b/src/ipa/libipa/v4l2_stats.cpp new file mode 100644 index 000000000000..7aa2add2f265 --- /dev/null +++ b/src/ipa/libipa/v4l2_stats.cpp @@ -0,0 +1,243 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ +/* + * Copyright (C) 2026, Ideas On Board + * + * V4L2 ISP Statistics + */ + +#include "v4l2_stats.h" + +#include + +namespace libcamera { + +namespace ipa { + +LOG_DEFINE_CATEGORY(V4L2Stats) + +/** + * \file v4l2_stats.cpp + * \brief Helper class to handle an ISP statistics buffer compatible with + * the generic V4L2 ISP format + * + * The Linux kernel defines a generic buffer format for ISP statistics. + * The format describes a serialisation method that allows userspace to + * access statistics data from a binary buffer. + * + * The V4L2Stats class implements support for the V4L2 ISP statistics buffer + * format and allows users to retrieve an ISP statistics block. + * + * IPA implementations using these helpers should define an enumeration of ISP + * blocks supported by the IPA module and use a set of common abstractions to + * help their derived implementation of V4L2Stats translate the enumerated ISP + * block identifiers to the actual type of the statistics data as defined by + * the kernel interface. + */ + +/** + * \class V4L2StatsBase + * \brief Base class for V4L2Stats + * + * The V4L2StatsBase is an integral part of V4L2Stats. It serves as a + * container for all code that does not depend on the V4L2Stats template + * arguments, to avoid duplicate copies of inline code. + */ + +/** + * \brief Construct an instance of V4L2StatsBase + * \param[in] data Reference to the v4l2-buffer memory mapped area + * \param[in] version The ISP parameters version the implementation supports + * + * Parse the statistics buffer and construct a cache that maps a block type to + * the memory location of a statistics block in the buffer. + * + * After construction users of this class shall check the validity of the + * constructed instance using operator bool(). + */ +V4L2StatsBase::V4L2StatsBase(Span data, unsigned int version) + : data_(data), valid_(false) +{ + const struct v4l2_isp_buffer *stats = + reinterpret_cast(data_.data()); + + if (data_.size() - sizeof(*stats) < stats->data_size) { + LOG(V4L2Stats, Error) + << "Stats buffer size mismatch: " << stats->data_size; + return; + } + + if (version != stats->version) { + LOG(V4L2Stats, Error) + << "Unsupported v4l2-isp version: " << stats->version; + return; + } + + /* Construct the cache for easier lookup. */ + size_t left = stats->data_size; + const __u8 *d = stats->data; + + while (left > 0) { + const struct v4l2_isp_block_header *header = + reinterpret_cast(d); + + if (left < sizeof(*header) || header->size < sizeof(*header)) { + LOG(V4L2Stats, Error) + << "Block type " << header->type + << " size is not valid"; + return; + } + + if (left < header->size) { + LOG(V4L2Stats, Error) + << "Not enough space for block type " << header->type; + return; + } + + auto [it, inserted] = cache_.try_emplace(header->type, d, header->size); + if (!inserted) { + LOG(V4L2Stats, Error) + << "Duplicated block type " << header->type; + return; + } + + d += header->size; + left -= header->size; + } + + valid_ = true; +} + +/** + * \brief Retrieve an ISP statistics block a return a reference to it + * \param[in] blockType The kernel-defined ISP block identifier, used to + * identify the block header + * \param[in] blockSize The ISP statistics block size, for validation + * + * Retrieve a span to the statistics block memory location by accessing the + * cache built at class construction time. + * + * \return The memory location of the ISP statistics block, or an empty Span + * if \a blockType is not supported + */ +Span V4L2StatsBase::block(unsigned int blockType, size_t blockSize) const +{ + const auto it = cache_.find(blockType); + if (it == cache_.end()) { + LOG(V4L2Stats, Error) << "Unsupported stats block type: " + << blockType; + return {}; + } + + const struct v4l2_isp_block_header *header = + reinterpret_cast(it->second.data()); + if (header->size != blockSize) { + LOG(V4L2Stats, Error) + << "Block type " << blockType + << " size mistmatch: expected " + << blockSize << " got:" + << header->size; + return {}; + } + + return it->second; +} + +/** + * \fn V4L2StatsBase::operator bool() + * \brief Retrieve if a V4L2StatsBase has been successfully constructed + * \return True if the instance has been constructed successfully, false + * otherwise + */ + +/** + * \class V4L2Stats + * \brief Helper class that represent an ISP statistics buffer + * + * This class represents an ISP statistics buffer. It is constructed with a + * reference to the memory mapped buffer that has been dequeued from the ISP + * driver. + * + * This class is templated with the type of the enumeration of ISP blocks that + * each IPA module is expected to support. IPA modules are expected to derive + * this class by providing a 'stats_traits' type that helps the class associate + * a block type with the actual memory area that represents the ISP statistics + * block. + * + * \code{.cpp} + * + * // Define the supported ISP statistics blocks + * enum class myISPStats { + * Agc, + * Awb, + * ... + * }; + * + * // Maps the C++ enum type to the kernel enum type and concrete parameter type + * template + * struct block_type { + * }; + * + * template<> + * struct block_type { + * using type = struct my_isp_kernel_stats_type_agc; + * static constexpr kernel_enum_type blockType = MY_ISP_STATS_TYPE_AGC; + * }; + * + * template<> + * struct block_type { + * using type = struct my_isp_kernel_stats_type_awb; + * static constexpr kernel_enum_type blockType = MY_ISP_STATS_TYPE_AWB; + * }; + * + * // Convenience type to associate a block id to the 'block_type' overload + * struct stats_traits { + * using id_type = myISPStats; + * template using id_to_details = block_type; + * }; + * + * ... + * + * // Derive the V4L2Stats class by providing stats_traits + * class MyISPStats : public V4L2Stats + * { + * public: + * MyISPStats::MyISPStats(Span data) + * : V4L2Stats(data, V4L2_ISP_VERSION_V1) + * { + * } + * }; + * + * \endcode + * + * Users of this class can then easily access an ISP statistics block using the + * block() function. + * + * \code{.cpp} + * + * MyISPStats stats(data); + * + * auto awb = stats.block(); + * auto mean_r = awb->mean_r; + * auto mean_g = awb->mean_g; + * auto mean_b = awb->mean_b; + * + * \endcode + */ + +/** + * \fn V4L2Stats::V4L2Stats() + * \brief Construct an instance of V4L2Stats + * \param[in] data Reference to the v4l2-buffer memory mapped area + * \param[in] version The expected V4L2 ISP serialization format version + */ + +/** + * \fn V4L2Stats::block() const + * \brief Retrieve a pointer to an ISP statistics block + * \return A pointer to the ISP statistics block or nullptr if the block is + * not present in the statistics buffer + */ + +} /* namespace ipa */ + +} /* namespace libcamera */ diff --git a/src/ipa/libipa/v4l2_stats.h b/src/ipa/libipa/v4l2_stats.h new file mode 100644 index 000000000000..b96395e5f551 --- /dev/null +++ b/src/ipa/libipa/v4l2_stats.h @@ -0,0 +1,67 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ +/* + * Copyright (C) 2026, Ideas On Board + * + * V4L2 ISP Statistics + */ + +#pragma once + +#include +#include + +#include + +#include + +namespace libcamera { + +namespace ipa { + +class V4L2StatsBase +{ +public: + V4L2StatsBase(Span data, unsigned int version); + + Span block(unsigned int blockType, size_t blockSize) const; + constexpr explicit operator bool() + { + return valid_; + } + +private: + std::map> cache_; + Span data_; + bool valid_; +}; + +template +class V4L2Stats : public V4L2StatsBase +{ +public: + static_assert(std::is_same_v, uint16_t>); + + V4L2Stats(Span data, unsigned int version) + : V4L2StatsBase(data, version) + { + } + + template + const typename Traits::template id_to_details::type * + block() const + { + using Details = typename Traits::template id_to_details; + + using Type = typename Details::type; + constexpr auto kernelId = Details::blockType; + + auto data = V4L2StatsBase::block(kernelId, sizeof(Type)); + + return data.size() > 0 ? + reinterpret_cast(data.data()) : nullptr; + } +}; + +} /* namespace ipa */ + +} /* namespace libcamera */