From patchwork Tue May 5 08:33:32 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 26633 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 89D70BE173 for ; Tue, 5 May 2026 08:33:38 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7CE556301E; Tue, 5 May 2026 10:33:37 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="XBOLDx9m"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E54962010 for ; Tue, 5 May 2026 10:33:36 +0200 (CEST) Received: from pb-laptop.local (185.221.140.217.nat.pool.zt.hu [185.221.140.217]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A7EDBC71 for ; Tue, 5 May 2026 10:33:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1777970013; bh=uQhTVrcP8idRFUYDW3HCNzNDmuJCAZ0SAKSDbkaum5s=; h=From:To:Subject:Date:From; b=XBOLDx9mBZAB9FEd9WCc4gqka3wiYIffjOyIFWW7swEGPJ6EqsEWG5Ha3L3zIZeo5 Zfh0bH67GcfobBTF6T3BfZcr2dMu6xTYfjReNGlDEy9PGdUXft7O8nVtOm1HCM3iGe 5Q7iztQJ5u96JGEGSGEKXZUXgs3C++fFsUIH+CmU= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1] libcamera: framebuffer: Fix cookie arg type Date: Tue, 5 May 2026 10:33:32 +0200 Message-ID: <20260505083332.610829-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The cookie has type `uint64_t`, but the constructor argument is of type `unsigned int`. Fix that. Unfortunately this is a public API and ABI change. Signed-off-by: Barnabás Pőcze --- include/libcamera/framebuffer.h | 2 +- src/libcamera/framebuffer.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h index 723525d05..c633d22a6 100644 --- a/include/libcamera/framebuffer.h +++ b/include/libcamera/framebuffer.h @@ -58,7 +58,7 @@ public: unsigned int length; }; - FrameBuffer(Span planes, unsigned int cookie = 0); + FrameBuffer(Span planes, uint64_t cookie = 0); FrameBuffer(std::unique_ptr d); virtual ~FrameBuffer() {} diff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp index 765dab95a..d61319030 100644 --- a/src/libcamera/framebuffer.cpp +++ b/src/libcamera/framebuffer.cpp @@ -315,7 +315,7 @@ ino_t fileDescriptorInode(const SharedFD &fd) * \param[in] planes The frame memory planes * \param[in] cookie Cookie */ -FrameBuffer::FrameBuffer(Span planes, unsigned int cookie) +FrameBuffer::FrameBuffer(Span planes, uint64_t cookie) : FrameBuffer(std::make_unique(planes, cookie)) { }