From patchwork Wed Feb 4 22:42:56 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 26092 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 716EDC31E9 for ; Wed, 4 Feb 2026 22:43:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0F1B262056; Wed, 4 Feb 2026 23:43:03 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="eAnJrTqh"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 52C6D6203F for ; Wed, 4 Feb 2026 23:43:00 +0100 (CET) Received: from [192.168.0.240] (ams.linuxembedded.co.uk [209.38.108.23]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C52C4833; Wed, 4 Feb 2026 23:42:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770244937; bh=J5BIADApSFwyrQRhxN9oKwxJ/JJPwCwNAlvi8q96pT8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=eAnJrTqhEjyZEe2EYLfKdoiceVMKJhxztKO+5JL3dJ61bXcJZGUEg17lOkyIRNd9o Qbj3trkUYuyVMs8Qoof48Q/dAKglkjqdZa2hVnSNyM5U6E/xIcExHTXcGr8ilgWJ4d dQl3gOhAWWmdMTMPe2Z3xs/Y7ySixrUw1MMbXGRQ= From: Kieran Bingham Date: Wed, 04 Feb 2026 22:42:56 +0000 Subject: [PATCH v2 1/3] ipa: rkisp1: Fix awb algorithm brief MIME-Version: 1.0 Message-Id: <20260204-kbingham-fixups-v2-1-c341cced1fad@ideasonboard.com> References: <20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com> In-Reply-To: <20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Kieran Bingham X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770244979; l=797; i=kieran.bingham@ideasonboard.com; s=20260204; h=from:subject:message-id; bh=J5BIADApSFwyrQRhxN9oKwxJ/JJPwCwNAlvi8q96pT8=; b=MsIZ/TpOzHkrBCRAU8iOgkOGXOHQaIEc+0LQ+OTkPbUzXE79uS6clZomwL734lC3UpbPSdfkt ySVG7krUG1jDMmxN5mxrXNCosjQEdHdoH6YC+w5v3SC86VzG11ewE4n X-Developer-Key: i=kieran.bingham@ideasonboard.com; a=ed25519; pk=IOxS2C6nWHNjLfkDR71Iesk904i6wJDfEERqV7hDBdY= X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The Awb brief was not updated from when the Bayes AWB was added. Extend it to account for this. Signed-off-by: Kieran Bingham --- src/ipa/rkisp1/algorithms/awb.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp index e8da7974a1d6ad9ec2e22c6b013aead0a88ee1c3..f83da545be856c08cd758dc20a5ace91344101cf 100644 --- a/src/ipa/rkisp1/algorithms/awb.cpp +++ b/src/ipa/rkisp1/algorithms/awb.cpp @@ -30,7 +30,7 @@ namespace ipa::rkisp1::algorithms { /** * \class Awb - * \brief A Grey world white balance correction algorithm + * \brief Manage the white balance with automatic and manual controls */ LOG_DEFINE_CATEGORY(RkISP1Awb) From patchwork Wed Feb 4 22:42:57 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 26093 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DDAEDC32E7 for ; Wed, 4 Feb 2026 22:43:05 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5CD2E62043; Wed, 4 Feb 2026 23:43:04 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="U3IG4wB5"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F03462041 for ; Wed, 4 Feb 2026 23:43:00 +0100 (CET) Received: from [192.168.0.240] (ams.linuxembedded.co.uk [209.38.108.23]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E354120E; Wed, 4 Feb 2026 23:42:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770244938; bh=4X0JVf1PaWuLk71UnsDWjpDVqLteWS+Rpxp35C3rSeA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=U3IG4wB5HGzAkXozab/iu1zwA2vcwfTdkcucer+2KiDLUlC0Ozj9XbPOPyoXA5//R p5ZIvG4m59t8Bp3QjqIYhE8iZH9LZsRlyKH9FFd1AWAYK6RsyDdzRftEEGrl/UC4Ya Vsr5qHaM1MZMy6+no5JCO8DH+4WfRz7lLIzhcL1k= From: Kieran Bingham Date: Wed, 04 Feb 2026 22:42:57 +0000 Subject: [PATCH v2 2/3] ipa: simple: Remove duplicate header inclusion MIME-Version: 1.0 Message-Id: <20260204-kbingham-fixups-v2-2-c341cced1fad@ideasonboard.com> References: <20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com> In-Reply-To: <20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Kieran Bingham , =?utf-8?q?Barnab?= =?utf-8?b?w6FzIFDFkWN6ZQ==?= , Milan Zamazal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770244979; l=845; i=kieran.bingham@ideasonboard.com; s=20260204; h=from:subject:message-id; bh=4X0JVf1PaWuLk71UnsDWjpDVqLteWS+Rpxp35C3rSeA=; b=s0F8yzElO0ioVK7Ph+/AA8NXVWmM5KICd4NxHCKC23cRP8V0b/axNDamkNmrY1eglvjg0Ilg1 t8FdM2Oh8CHCdMmJ66/bjaBnD3JkhKx+DCqWVCq8pRVWDD/DmxPduz2 X-Developer-Key: i=kieran.bingham@ideasonboard.com; a=ed25519; pk=IOxS2C6nWHNjLfkDR71Iesk904i6wJDfEERqV7hDBdY= X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The Awb component already references libcamera/control_ids.h. Remove the incorrect duplicate inclusion of "control_ids.h". Reviewed-by: Barnabás Pőcze Reviewed-by: Milan Zamazal Signed-off-by: Kieran Bingham --- src/ipa/simple/algorithms/awb.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp index 6fdaacaba3183bc2efa348c4182b90201006b826..6369193c686c0c69de88cb60756a00557dbdbbd9 100644 --- a/src/ipa/simple/algorithms/awb.cpp +++ b/src/ipa/simple/algorithms/awb.cpp @@ -17,8 +17,6 @@ #include "libipa/colours.h" #include "simple/ipa_context.h" -#include "control_ids.h" - namespace libcamera { LOG_DEFINE_CATEGORY(IPASoftAwb) From patchwork Wed Feb 4 22:42:58 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 26094 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E6429C32EA for ; Wed, 4 Feb 2026 22:43:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1380B62052; Wed, 4 Feb 2026 23:43:05 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="VmFptq0Y"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B48C361FBF for ; Wed, 4 Feb 2026 23:43:00 +0100 (CET) Received: from [192.168.0.240] (ams.linuxembedded.co.uk [209.38.108.23]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 603781337; Wed, 4 Feb 2026 23:42:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770244938; bh=gUjwGqFZam4HOUtVthtCwpm8yQSR4F1eQiUIUaiuX8E=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=VmFptq0YsBlXd+eaguJW9Mrr/k8LOyKiVeg9nsxR95wH+w1svHS10/0dMeYiJdfWg vXg//eUBR+OY8KbjgBjnemLgG5jjm6wvxSL+HYRY/+hrcgLAXQ/PTK5BvVNuLOiaSI D/iqC2xLRW1ZnZ85TMipySvkERqQ4q/hzLghBoN8= From: Kieran Bingham Date: Wed, 04 Feb 2026 22:42:58 +0000 Subject: [PATCH v2 3/3] libcamera: software_isp: Fix LIBCAMERA_SOFTISP_MODE log print MIME-Version: 1.0 Message-Id: <20260204-kbingham-fixups-v2-3-c341cced1fad@ideasonboard.com> References: <20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com> In-Reply-To: <20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Kieran Bingham X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770244979; l=1244; i=kieran.bingham@ideasonboard.com; s=20260204; h=from:subject:message-id; bh=gUjwGqFZam4HOUtVthtCwpm8yQSR4F1eQiUIUaiuX8E=; b=Mp/Pld+1Qjvx1/6JZweQ5ibufFECleq7XSuSGcUCZVXF697G15gvdzUsFDCgNQKVB9mLzCBNV nEIwTbu2BtlB6ti04ECcMcgxWE2NxRgSCiEOMTZdUIJxn+TjrUW3UqP X-Developer-Key: i=kieran.bingham@ideasonboard.com; a=ed25519; pk=IOxS2C6nWHNjLfkDR71Iesk904i6wJDfEERqV7hDBdY= X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When an invalid parameter is specified to LIBCAMERA_SOFTISP_MODE, the error log has a typo. Fix the typo and reflow the line while here. Signed-off-by: Kieran Bingham --- src/libcamera/software_isp/software_isp.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index a83986b787b75ac1cd9073b32f2b937e9efb6cf0..3eb9cf97dea66cb68f2277a8274003e28418d830 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -108,8 +108,10 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor, std::optional softISPMode = configuration.envOption("LIBCAMERA_SOFTISP_MODE", { "software_isp", "mode" }); if (softISPMode) { if (softISPMode != "gpu" && softISPMode != "cpu") { - LOG(SoftwareIsp, Error) << "LIBCAMERA_SOFISP_MODE " << softISPMode.value() << " invalid " - << "must be \"cpu\" or \"gpu\""; + LOG(SoftwareIsp, Error) + << "LIBCAMERA_SOFTISP_MODE " + << softISPMode.value() << " invalid " + << "must be \"cpu\" or \"gpu\""; return; } }