From patchwork Mon Jan 5 14:31:45 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 25626 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3026CBDCC0 for ; Mon, 5 Jan 2026 14:32:23 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 484D661F9F; Mon, 5 Jan 2026 15:32:22 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="bYfm29NZ"; dkim-atps=neutral Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 003F861F35 for ; Mon, 5 Jan 2026 15:32:19 +0100 (CET) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-47798f4059fso13298705e9.2 for ; Mon, 05 Jan 2026 06:32:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1767623539; x=1768228339; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SYtvXE1MkuK/e0A5BHOpwSDVdM/or9gU7hgMIsZfgpA=; b=bYfm29NZ5KVrko+qt1y+Mp8bfdl9ag8fbgILfgFaWitECaDcjvJPWB7jwNCeM0zf81 xrRv+8M0m/g8FBahFXOQFZLJtBDL3fBOK4vTM18cHOvIiAeJHyRfd7QwyPPdXQDzWUBu 2LyMCWshg/DMzfs0D6Vc9BC5L12lDwtOqidQ33pwsHOX9s+myfqeo8W6OMzHS6UrhML2 s3n47wxEsAMRoC33s2YhQa8REEqzF+4cDzysJtiaeHqoJ1zhNKHmuYi/TWqvot2CNBBx H+Gv4EYp+gpAjcJrSi5p8HgTWxw4J3hZJrFUnDbR29x+FXkB4aUPHYbe9uo8NscKbSRF CopQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767623539; x=1768228339; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SYtvXE1MkuK/e0A5BHOpwSDVdM/or9gU7hgMIsZfgpA=; b=XRS5bFhZOZtJIUhKj7w0nLWJOdDEWDgWwTu5UyKFndgJB0jKxhbKvvKwCd0zrgSoZM buBPCa3TPo1g5iCyXi46XCX4JG+mgypr5RmHYCKvG5g/SPOMovZpKd+4uqL0r8r/pdCf W/jVjC4Fat5FNT9miTKt8SnGSkpOrZFVewfNmW7R9VM3xTmuKIsK+TkE3bjG9LtLfKwk LkJ7TdVivba51KOv7rWyDJ0teYP1svcCCDkopecwivFEZ/ia7lAEFdSONhjJkeyrfpEl wbVIn1GJ9aGKXK2wDLwNFcg4QT6xUT8wIpvE3pfql8PLbkA0q4+RypYoJhNp2OkRFo49 e0Ig== X-Gm-Message-State: AOJu0YzRA/jjssxEH7w4VNBtuuHgTtXwDwokn3tX7jhpDnzFHpymhQ74 WLe9Ytd1exSKUPnyY58GHF/qTi0N8bmD7NUNQurH2womx8w03tTJyd+F2Zhs1XE0TezPPcG2IMA WBjQC X-Gm-Gg: AY/fxX4ZKzwjME4cZClyEKznViqYe4ACvuwxXY5wc5+7BVI78CdirAPrJJ6pjgBLizt hRcxzhlQvdKpa8290BqatMN6I/Ja/q29VgC7MUDCLrLvYAzQlRzmitlbQw0wHSF+gdaFTI8kzAt i3XDigcy4RfCHXZ4l2hWvpNnV1mObdUrj6cC+E/juIBggls6E/n4B+bNErKtldcZOdSjiQV9m2O lYUP55RjdaW/ueV7I6WF8DOsMBeSASEE3y+NAzlR70YfCElM4xg5m8ejt2ZnOVxDIbBcm7q4iai YuDY1I0Q8F+tG5X2IQgvxmG2n+jCyUsSDlga5hU8DZ5x42rnyCWlAGHE+PTd5UFcjEfW/q7jDT9 lOhsly/rD7ZfPmXr9lAyRiQDTW2aunN3KoIP+O9WWWKN1yLxjndAVznUfIuIW4SEsfhXywHiWiB PhZ8otCy47sxCs0t0hPm8qd9Id7+/fe9/UKJNXz7tocg== X-Google-Smtp-Source: AGHT+IF+fZeEaAQySW7t+vcsm0VQQK2QnRPcVsAkG9vyBGNy1UeAyX5VDFW//xJjE2ksoL9Xcw0GPg== X-Received: by 2002:a05:600c:4fd3:b0:477:a450:7aa2 with SMTP id 5b1f17b1804b1-47d1954d406mr388769765e9.1.1767623539068; Mon, 05 Jan 2026 06:32:19 -0800 (PST) Received: from naush-dell.pitowers.org ([2a00:1098:3142:1f:9644:8cdc:57dc:9223]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4327778e27bsm67402053f8f.12.2026.01.05.06.32.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 06:32:18 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?= =?utf-8?q?e?= Subject: [PATCH v2] v4l2_camera_proxy: Fix for getting deafult controls::FrameDurationLimits Date: Mon, 5 Jan 2026 14:31:45 +0000 Message-ID: <20260105143206.115011-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The default values for controls::FrameDurationLimits is now an array but the v4l2 proxy is fetching it as a scalar value, causing a runtime error. Fix this by templating the getter with the correct Span type. Also related, fix the RPi IPA's initial default value for controls::FrameDurationLimits to be an array and use the default const values. Fixes: 4e9be7d11b9df ("ipa: ipu3, mali-c55, rkisp1, rpi: Fix reporting non-scalar controls") Closes: https://github.com/raspberrypi/libcamera/issues/321 Signed-off-by: Naushir Patuck Reviewed-by: Barnabás Pőcze --- src/ipa/rpi/common/ipa_base.cpp | 6 ++++-- src/v4l2/v4l2_camera_proxy.cpp | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp index 14aba4500ae4..322694985e72 100644 --- a/src/ipa/rpi/common/ipa_base.cpp +++ b/src/ipa/rpi/common/ipa_base.cpp @@ -84,8 +84,10 @@ const ControlInfoMap::Map ipaControls{ { &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) }, { &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) }, { &controls::FrameDurationLimits, - ControlInfo(INT64_C(33333), INT64_C(120000), - static_cast(defaultMinFrameDuration.get())) }, + ControlInfo(static_cast(defaultMinFrameDuration.get()), + static_cast(defaultMaxFrameDuration.get()), + Span{ { static_cast(defaultMinFrameDuration.get()), + static_cast(defaultMinFrameDuration.get()) } }) }, { &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) }, { &controls::rpi::StatsOutputEnable, ControlInfo(false, true, false) }, }; diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp index 559ffc6170b1..03cd4810cc05 100644 --- a/src/v4l2/v4l2_camera_proxy.cpp +++ b/src/v4l2/v4l2_camera_proxy.cpp @@ -200,9 +200,9 @@ void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig) const auto &it = controls.find(&controls::FrameDurationLimits); if (it != controls.end()) { - const int64_t duration = it->second.def().get(); + Span duration = it->second.def().get>(); - v4l2TimePerFrame_.numerator = duration; + v4l2TimePerFrame_.numerator = duration[0]; v4l2TimePerFrame_.denominator = 1000000; } else { /*