From patchwork Mon Jan 5 10:34:03 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 25623 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4D998BDCC0 for ; Mon, 5 Jan 2026 10:34:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 62EA661FA3; Mon, 5 Jan 2026 11:34:15 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="COKsDyyN"; dkim-atps=neutral Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2109961F9F for ; Mon, 5 Jan 2026 11:34:13 +0100 (CET) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-47d211aee52so10730465e9.2 for ; Mon, 05 Jan 2026 02:34:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1767609252; x=1768214052; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rqoMihRduB5bZDnwH4ifTbRwBT2RGtsF/oHdwbtxZPY=; b=COKsDyyNMpanXQdP5XQ1ERqJqAg0HtV0aTyS2K8F2U9B+i8kXOoZVrUPyndh8zFK4U ZB7b5qPFJCasJk7ae3qAZbjdJHIILGNX7zDaP+/oABrFIBWKuSEQ9sEVKHzQ1PgY0OdG 2RvD4sccX2Wlg+4sPdB8pSszqHuBB+/U+7GH4OrAErJO1+5Bzlj75aOIiqDvC4gziEWl biA9v4OkjDYoIRCEvUSoW6+hKpgyN4K/VI5QxM5S77juW64d+CHS9RsasDZawTVaxSuC gA9XQ07jBJOOV82xdJoHwWoGMVAXXFyoMSzXPx2qqPGKSGkwAwT3JtzN4627Dc22qo3d EVeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767609252; x=1768214052; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rqoMihRduB5bZDnwH4ifTbRwBT2RGtsF/oHdwbtxZPY=; b=PpHI8K43R9+yild3gNdazrpKrynIZuHzCKBnWrbGsPRwAkrStE+/wU+A8G8ck+2/UA SuIGV7QdDCMLWJfeyrxI0fv2rXTboQsVUJmOQjW7ecwiVtu3RyuheZPjEaAfUe98E6gn EAKtI8+2jxNAWu99TfScAGq3Z42WcdNedO8Tp3RHfhtr7n7QoC3beydXV2DdM/PZiVUM Wy/XhZ3pDudU9tvshH+EHd+MKjVM3JMhxbah7aiz1pZ2/NHN46NFAIUEEbGKHNSjFK9L 63L03FlJlu4YDsfhLE+aPsX16qvAdAjctCZ9eCzZ7zl9gPKBajhkP8ZqdjCDQ14VO2l9 z34A== X-Gm-Message-State: AOJu0Yz4wo43VXKLq8amnYkXokHJsqi36kwjsqUdvwi9kGUtCfMJrbnW y15u+dryb15FGBSHS2suNzERUkCuElQNItSWVGDn/eekHfRw9Lnt94bNXHH+zRAscIa5Ou6h7xe y2lrW X-Gm-Gg: AY/fxX7hbvIKA6HqM7upe2XVeApL6EsOorY8yfw0vJdUKaNJNXb/qUfAuiVqaRN3Hq5 YFsswP1JuwxV1MEjahTX2iUOPTsirt+tiFWQ/Q0+b7KNAdqVefY80mh81U7otI9rN+4vE+7RVxz F/7SxndtzRYPrqiyORpZOuGI6liDjNUaSt8zKIwUsarPQyGIQQ78ESqvZJiMe9e05XX/+TMk7aq +EP7oooHuSze4zHZq0bCXTYY2Ux5dlaydG2dRa3rvQmjO13okxdhgIXIc/hbkb/8hl80Ujz6XZU aFxL0e3N/ljR0tJ/F6nEg0bXCD1MMCjfMUxKN69Dm39Ah/2vQMGCvpgRqRNPEO5JgXkkI7iDuEH S9vlgSLOc8mLwKMNaknmD1IroWCYk0wOiPrPBmB0pVp0XOKqUlCx9PTmVo6tgH8gXh45fleD78m KLpEThBoMckH+cHZxHouQKnDL57HKjvpA= X-Google-Smtp-Source: AGHT+IFVENV+LyKqoGbh5KVy2qo+da1fyVZXo9l9sk1mf4xPRVz9wWlKA5QSyP4DUIcwt9JGj0uh0Q== X-Received: by 2002:a05:6000:1cd1:b0:432:84ef:7159 with SMTP id ffacd0b85a97d-43284ef7493mr15925990f8f.8.1767609252283; Mon, 05 Jan 2026 02:34:12 -0800 (PST) Received: from naush-dell.pitowers.org ([2a00:1098:3142:1f:9644:8cdc:57dc:9223]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa08d9sm99928289f8f.30.2026.01.05.02.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 02:34:11 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck Subject: [PATCH v1] v4l2_camera_proxy: Fix for getting deafult controls::FrameDurationLimits Date: Mon, 5 Jan 2026 10:34:03 +0000 Message-ID: <20260105103409.50623-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The default values for controls::FrameDurationLimits is now an array but the v4l2 proxy is fetching it as a scalar value, causing a runtime error. Fix this by templating the getter with the correct Span type. Also related, fix the RPi IPA's initial default value for controls::FrameDurationLimits to be an array. Fixes: 4e9be7d11b9df ("ipa: ipu3, mali-c55, rkisp1, rpi: Fix reporting non-scalar controls") Closes: https://github.com/raspberrypi/libcamera/issues/321 Signed-off-by: Naushir Patuck Reviewed-by: Barnabás Pőcze --- src/ipa/rpi/common/ipa_base.cpp | 3 ++- src/v4l2/v4l2_camera_proxy.cpp | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp index 14aba4500ae4..9f8667a2284a 100644 --- a/src/ipa/rpi/common/ipa_base.cpp +++ b/src/ipa/rpi/common/ipa_base.cpp @@ -85,7 +85,8 @@ const ControlInfoMap::Map ipaControls{ { &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) }, { &controls::FrameDurationLimits, ControlInfo(INT64_C(33333), INT64_C(120000), - static_cast(defaultMinFrameDuration.get())) }, + Span{ { static_cast(defaultMinFrameDuration.get()), + static_cast(defaultMinFrameDuration.get()) } }) }, { &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) }, { &controls::rpi::StatsOutputEnable, ControlInfo(false, true, false) }, }; diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp index 559ffc6170b1..03cd4810cc05 100644 --- a/src/v4l2/v4l2_camera_proxy.cpp +++ b/src/v4l2/v4l2_camera_proxy.cpp @@ -200,9 +200,9 @@ void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig) const auto &it = controls.find(&controls::FrameDurationLimits); if (it != controls.end()) { - const int64_t duration = it->second.def().get(); + Span duration = it->second.def().get>(); - v4l2TimePerFrame_.numerator = duration; + v4l2TimePerFrame_.numerator = duration[0]; v4l2TimePerFrame_.denominator = 1000000; } else { /*