From patchwork Sat Dec 27 05:40:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Johannes Schneider X-Patchwork-Id: 25618 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 62045BDCC0 for ; Sat, 27 Dec 2025 05:40:51 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A06DE61F9B; Sat, 27 Dec 2025 06:40:50 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=leica-geosystems.com header.i=@leica-geosystems.com header.b="V3u2imt1"; dkim-atps=neutral Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c201::3]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6854C61F84 for ; Sat, 27 Dec 2025 06:40:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FfrR+8PXruvEkY0CLaNjmjCVdPqG/iUItXFoMx8BiJcLmjwAZvQhjKzAu8sy2ZPnItP/zwfOWC/kdbIcd2O0xWgzio22fSYKxVQwKlhI2IDsSelMf6PXtjigv24Re/9KwwykP9iqHdPYluB/E1rWyyUjheDFDyOK0/iIfoHSXw6r9ErNjT0akzK/81kujyQE+NKvyGzD9k9F5lEFq/VtMpXLdm926qY/Kx/jvmntoRT++6wYWeGoleLN3DnHUsH4Zj+31G/4ADPMVYBEqAaomRuJZKeGSMYdWwSuybVjmc5ZHaCTiv5CoBMt19tKNuysRgmC9yIbiDmRUcOjunRZ0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GUHHijY0qBtwWobKjsu/um37wU7W7qL/AiVDCkOMnaU=; b=Iuyov7MT65dMihIsmSt/CMu2BDTpfRMEwPCQwpaXIIHvTLrZ/LnPLJVJUBvwzrurjy0MfE0M0mBsO7kxIK4teMJSUvh4/oPjYyhGfkNA030Vuy6nWIXt0gY6NCeLvFescEEuvl9WiT7PoGWusI5GDFCDxEmYeE0q335KcCcXL1YgAspqD4wh7RxK3rqAC37k2soMsaH0Y80XiZCNwJ+8vg/yCbs1naHkxkfg/Otb/5y6IB1vOkzHfiViare5xmn6EwQatD7obru/9PBTnRsID3bI7RWKMSEmwCnZsr6z+62eseLF8f/g+q0h+8COcYLoAJkyx5UYKXj0mngyEgdsOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 193.8.40.99) smtp.rcpttodomain=lists.libcamera.org smtp.mailfrom=leica-geosystems.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=leica-geosystems.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leica-geosystems.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GUHHijY0qBtwWobKjsu/um37wU7W7qL/AiVDCkOMnaU=; b=V3u2imt1PlrUJpjyhbvgE/8S2kgVbx7FPoG6riG3HMzlaawqB3d2lYEGPQnGxHcuUwbjIasHM+6l+RHuAVozIMSAglMvYrlGrwYBiQomCe/9Pdvu16J2sdWx2SL8s1dN7SNY5oYJlX8WurFcho/muoZAiBk0rUtT/VqxQ2DnpV0= Received: from DB3PR08CA0017.eurprd08.prod.outlook.com (2603:10a6:8::30) by PA1PR06MB9094.eurprd06.prod.outlook.com (2603:10a6:102:45b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.11; Sat, 27 Dec 2025 05:40:45 +0000 Received: from DB1PEPF0003922F.eurprd03.prod.outlook.com (2603:10a6:8:0:cafe::78) by DB3PR08CA0017.outlook.office365.com (2603:10a6:8::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.12 via Frontend Transport; Sat, 27 Dec 2025 05:40:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 193.8.40.99) smtp.mailfrom=leica-geosystems.com; dkim=none (message not signed) header.d=none; dmarc=pass action=none header.from=leica-geosystems.com; Received-SPF: Pass (protection.outlook.com: domain of leica-geosystems.com designates 193.8.40.99 as permitted sender) receiver=protection.outlook.com; client-ip=193.8.40.99; helo=hexagon.com; pr=C Received: from hexagon.com (193.8.40.99) by DB1PEPF0003922F.mail.protection.outlook.com (10.167.8.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sat, 27 Dec 2025 05:40:44 +0000 Received: from GEO-H84s5E2W8Pk.lgs-net.com ([10.60.34.93]) by hexagon.com with Microsoft SMTPSVC(10.0.17763.1697); Sat, 27 Dec 2025 06:40:44 +0100 From: Johannes Schneider To: libcamera-devel@lists.libcamera.org, stefan.klug@ideasonboard.com, kieran.bingham@ideasonboard.com Cc: Johannes Schneider Subject: [PATCH] fix clang warnings/errors Date: Sat, 27 Dec 2025 06:40:40 +0100 Message-ID: <20251227054042.3836430-1-johannes.schneider@leica-geosystems.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-OriginalArrivalTime: 27 Dec 2025 05:40:44.0271 (UTC) FILETIME=[582C6FF0:01DC76F3] X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF0003922F:EE_|PA1PR06MB9094:EE_ X-MS-Office365-Filtering-Correlation-Id: 646baf96-b14a-4329-ffc8-08de450a7ad7 X-SET-LOWER-SCL-SCANNER: YES X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?UFTpqGxZhczYCjl6sdR24pYre/2m?= =?utf-8?q?1XYP1s/e3dNa44kfJoeZoMVYme/fMUo0LdwvLbjM8UWAw1ooHr3iRkdi?= =?utf-8?q?cCLH/xcohfUPwJj6p/wruelgRPmxuFk+Swr0B3m3dZjaZ67fsfNuLMBW?= =?utf-8?q?iVXbCxEwX2hDVNRqwaoJWHJaIuDWqTMpJ9QIZatxR9bGcllvLEmE5cHJ?= =?utf-8?q?Cj74LplzptETBf6KDVCKxS4rDip1lgx8e+k9LuHkE3WKTiMLwDzHoZ7e?= =?utf-8?q?nWgya+tnPGzU8ykWeyy4fdgED57T6Ezhp8znY5b8Bo03L1Rbqm7PX9Zo?= =?utf-8?q?CRciLzpwVOFP4ZhNJdU8QTG+Q7Tn+N6ARhWbUwd82sexegPmp1U0OF+V?= =?utf-8?q?Hp0kQl/TK02HoRoyaQPoWvsK9+iQk31G/x+ddtddalyhIHaQXxXOGsMS?= =?utf-8?q?VwuK3VewlWw+hYZDypYKLd5B9aAPsGUZaSCvR8MoY1htq1lG0QXO4OPS?= =?utf-8?q?AulEEyPWP1hiHffXEszoFXvqt9dKd5aCnHClcJbbhSKMgmvKZrHt2WdJ?= =?utf-8?q?tcP6VIhDrt45LOqGt2DAFVkqIEiRZSRRAB7Pl4ahNM8+WibiFA7B1/7o?= =?utf-8?q?iHgT43Xa+AOWjACJJRbF4hrDdj02StdiPsloWmJ8LxXLPdg5ZL1pA1Tp?= =?utf-8?q?BLR1MwO6eXer1sY0ZVpytIZx+RhTXA67rN4+0WeDUrmpK/kuhoki560o?= =?utf-8?q?HoKbDJrystZw+A+8CkEqocrSxaJRsfa8+Ms5Q0CAuKJEjtNA6jThujD3?= =?utf-8?q?L3tq2u/o73LYXBN71DI2HHshowBCaLJexAOK1s9Zwj1m0WvHXiSZFkH9?= =?utf-8?q?ueEKP5HGO01XaP1Z6TEVjlpyROz2j2eedJQ4IrfbXOo+hbg1n8Cm7Hd7?= =?utf-8?q?1pzhrIl+rTnIOBrefK6+fLUWgGGrdaDonBhNmdmLc7jxEx5I/F4hEfSz?= =?utf-8?q?n8ucBgRkTf8Qcfvdfz/NtOqNI6/L6e3vGsiep75+wHdSTlALZNOy1Peg?= =?utf-8?q?TGZxolDOz+/SUF1hFkhqxTfQwtFPnls3eJBHc6cP5PDSaXdsKmurspuz?= =?utf-8?q?qPVlKri2zuV39nZHarChOyZq7kIizvam0iHLWTExuY9u1EYvxEtftWm4?= =?utf-8?q?53/jF0dQN+8LXxUgZB08jZOALO9c1kv9zKemjkLEXg1cuAc5s25+SE03?= =?utf-8?q?0R47bbSmmALVRbpirbNwgLBE5BKM4Bl7D6guZ3YJZTjwE4NRQengikIX?= =?utf-8?q?IZ2ezt9dfNziK8DKbjbGQaF+OhWUqkfQ0cLih1nMqtAieKE37VTO/4rz?= =?utf-8?q?fH1BDHSG88/z3zKb4amPAqkY4RcIANCWPak9K0Uth03TUZA3hkcjUYPy?= =?utf-8?q?EqfHRgdlBLSj/2sAv99cX8SBNahDx9wOqaEgSp488zerYHLJTmAMJ/iH?= =?utf-8?q?8biLL2Ohu1u2l+60IB34NBK+Bz+zzFCt8cG17rO4gHyIPUKqGH2ULTXE?= =?utf-8?q?w4AsdY8hTd3FsIhHKZM/X5XjleBZ0oa5DcZ7hftfLRn25NRljGBgpZzz?= =?utf-8?q?62kOKGLqMtXHYUcFS1+2X2Wq2xbf+YmJ+mEC9q1GiWSWHRJberSE4pR4?= =?utf-8?q?ycps3BgO9aZIVUuLS2eopY+QOxjOaZojsQKydQ0=3D?= X-Forefront-Antispam-Report: CIP:193.8.40.99; CTRY:CH; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:hexagon.com; PTR:ahersrvdom51.leica-geosystems.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(376014)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: leica-geosystems.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Dec 2025 05:40:44.5508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 646baf96-b14a-4329-ffc8-08de450a7ad7 X-MS-Exchange-CrossTenant-Id: 1b16ab3e-b8f6-4fe3-9f3e-2db7fe549f6a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=1b16ab3e-b8f6-4fe3-9f3e-2db7fe549f6a; Ip=[193.8.40.99]; Helo=[hexagon.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF0003922F.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR06MB9094 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Building libcamera with clang raises some warnings-as-errors. Signed-off-by: Johannes Schneider --- Hoi, you could/should consider compiling with clang too ;-) gruß Johannes --- include/libcamera/internal/camera_sensor_helper.h | 2 +- src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) -- 2.43.0 diff --git a/include/libcamera/internal/camera_sensor_helper.h b/include/libcamera/internal/camera_sensor_helper.h index 1e1e479..1b3217b 100644 --- a/include/libcamera/internal/camera_sensor_helper.h +++ b/include/libcamera/internal/camera_sensor_helper.h @@ -61,7 +61,7 @@ public: static std::vector &factories(); - const std::string &name() const { return name_; }; + const std::string &name() const { return name_; } private: LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase) diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp index d6b95fb..368320f 100644 --- a/src/libcamera/converter/converter_v4l2_m2m.cpp +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp @@ -258,7 +258,7 @@ int V4L2M2MConverter::V4L2M2MStream::applyControls(ControlList &ctrls, const V4L2Request *request) { return m2m_->capture()->setControls(&ctrls, request); -}; +} /* ----------------------------------------------------------------------------- * V4L2M2MConverter diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index ca9e850..1437318 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -377,7 +377,6 @@ int RkISP1CameraData::loadTuningFile(const std::string &path) const auto ¶ms = algo["Dewarp"]; canUseDewarper_ = true; - Matrix m; DewarpParms dp; if (params["cm"]) { const auto &cm = params["cm"].get>();