From patchwork Tue Nov 11 14:11:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rui Wang X-Patchwork-Id: 24995 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 65ECAC3241 for ; Tue, 11 Nov 2025 14:12:10 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 15BE7606D5; Tue, 11 Nov 2025 15:12:10 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="O4hX4+tM"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CDDA2606A0 for ; Tue, 11 Nov 2025 15:12:08 +0100 (CET) Received: from rui-Precision-7560.local (unknown [209.216.122.90]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CC21143; Tue, 11 Nov 2025 15:10:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1762870210; bh=sk4RG1+0bLxU9pSX1cxGsoAR2eI44Ygk15XdXXbNKe4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O4hX4+tMIkyQ/zb6lX8Hz7eWWiiXxgwaOI7zqwZByqPzGtxPZKWbUFkO329zRO9j8 QpmIs5uTQyPms2mXUgzj0fhQGCYaOIt35BQDPrRmW2MfWER3O+Xghu6AaQLknL5zDw 01OxeSw7f2Y31WcO8mIOu6S6n9C014P/gJuWjyjA= From: Rui Wang To: libcamera-devel@lists.libcamera.org Cc: Rui Wang Subject: [PATCH v2] ipa: rkisp1: dpf: Enable strength after enable Dpf Date: Tue, 11 Nov 2025 09:11:35 -0500 Message-ID: <20251111141152.1179099-2-rui.wang@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251024120107.681968-1-rui.wang@ideasonboard.com> References: <20251024120107.681968-1-rui.wang@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The filter strength configuration block was previously only enabled on the first frame (frame == 0). Apply the strength values when denoise is active. This prevents the strength config from being disabled on subsequent frames. Signed-off-by: Rui Wang --- src/ipa/rkisp1/algorithms/dpf.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp index cb6095da..39f3e461 100644 --- a/src/ipa/rkisp1/algorithms/dpf.cpp +++ b/src/ipa/rkisp1/algorithms/dpf.cpp @@ -225,8 +225,12 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame, auto config = params->block(); config.setEnabled(frameContext.dpf.denoise); + auto strengthConfig = params->block(); + strengthConfig.setEnabled(frameContext.dpf.denoise); + if (frameContext.dpf.denoise) { *config = config_; + *strengthConfig = strengthConfig_; const auto &awb = context.configuration.awb; const auto &lsc = context.configuration.lsc; @@ -250,12 +254,6 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame, else mode = RKISP1_CIF_ISP_DPF_GAIN_USAGE_DISABLED; } - - if (frame == 0) { - auto strengthConfig = params->block(); - strengthConfig.setEnabled(true); - *strengthConfig = strengthConfig_; - } } REGISTER_IPA_ALGORITHM(Dpf, "Dpf")