From patchwork Tue Nov 11 12:06:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rui Wang X-Patchwork-Id: 24991 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 92E51C3241 for ; Tue, 11 Nov 2025 12:06:43 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 45F9860A9D; Tue, 11 Nov 2025 13:06:43 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ZzpBw5ay"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CD4C1606A0 for ; Tue, 11 Nov 2025 13:06:41 +0100 (CET) Received: from rui-Precision-7560.local (unknown [209.216.122.90]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E9726741; Tue, 11 Nov 2025 13:04:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1762862683; bh=sk4RG1+0bLxU9pSX1cxGsoAR2eI44Ygk15XdXXbNKe4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZzpBw5aymKYAXhd6NJn9Tydw0D4PpYmgkzFp6A95bcH0fgjAj6Nx+b/wsx2YgdOjS 1ytudOzt5kR5jEmoJYhEdrCp4P/7K6KomAWSeQD196fbSd2TBmN/47VaJMBXrckC7z YgkLDh/7wPVW2RpfUNQ9shzQn6Ce4hyBlFQduwAU= From: Rui Wang To: libcamera-devel@lists.libcamera.org Cc: Rui Wang Subject: [PATCH v2] ipa: rkisp1: dpf: Enable strength after enable Dpf Date: Tue, 11 Nov 2025 07:06:18 -0500 Message-ID: <20251111120634.1132790-2-rui.wang@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251024120107.681968-1-rui.wang@ideasonboard.com> References: <20251024120107.681968-1-rui.wang@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The filter strength configuration block was previously only enabled on the first frame (frame == 0). Apply the strength values when denoise is active. This prevents the strength config from being disabled on subsequent frames. Signed-off-by: Rui Wang --- src/ipa/rkisp1/algorithms/dpf.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp index cb6095da..39f3e461 100644 --- a/src/ipa/rkisp1/algorithms/dpf.cpp +++ b/src/ipa/rkisp1/algorithms/dpf.cpp @@ -225,8 +225,12 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame, auto config = params->block(); config.setEnabled(frameContext.dpf.denoise); + auto strengthConfig = params->block(); + strengthConfig.setEnabled(frameContext.dpf.denoise); + if (frameContext.dpf.denoise) { *config = config_; + *strengthConfig = strengthConfig_; const auto &awb = context.configuration.awb; const auto &lsc = context.configuration.lsc; @@ -250,12 +254,6 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame, else mode = RKISP1_CIF_ISP_DPF_GAIN_USAGE_DISABLED; } - - if (frame == 0) { - auto strengthConfig = params->block(); - strengthConfig.setEnabled(true); - *strengthConfig = strengthConfig_; - } } REGISTER_IPA_ALGORITHM(Dpf, "Dpf")