From patchwork Tue Nov 11 09:23:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 24987 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A6EEFC3263 for ; Tue, 11 Nov 2025 09:23:25 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D5727609DE; Tue, 11 Nov 2025 10:23:24 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="aLkTJxtT"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E32D60805 for ; Tue, 11 Nov 2025 10:23:23 +0100 (CET) Received: from pb-laptop.local (185.221.140.239.nat.pool.zt.hu [185.221.140.239]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 92B5850A for ; Tue, 11 Nov 2025 10:21:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1762852884; bh=1aB4nhr1F1qLCYMJ4M9BDuv0RXI8YBmaUG7RI3DvVmU=; h=From:To:Subject:Date:From; b=aLkTJxtTPrYNxEL5/CM9aUE8agPNiIVBDRYk55F1FcvJ7ucxaSktHvMdhulwe6pLm H+qUc3XZ3KNdAdXgPC7ENQC8vJ0FbSkCKwTfNSP3XI6ZTsrZqityr6P46bcbzNqSlg CMDbMvyTT+7aZTe90Na3bgQV/FP1WEh+CCwF7tos= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1] libcamera: pipeline: uvcvideo: Reject sensor configuration Date: Tue, 11 Nov 2025 10:23:19 +0100 Message-ID: <20251111092319.2313234-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.51.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The UVC pipeline handler cannot set the sensor configuration so if the desired `CameraConfiguration` specifies one, then reject it. Signed-off-by: Barnabás Pőcze Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp index 4b5816dfdd..48d6b39d53 100644 --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp @@ -143,6 +143,9 @@ CameraConfiguration::Status UVCCameraConfiguration::validate() if (config_.empty()) return Invalid; + if (sensorConfig) + return Invalid; + if (orientation != Orientation::Rotate0) { orientation = Orientation::Rotate0; status = Adjusted;