From patchwork Wed Oct 29 10:08:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 24888 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 293A5C3259 for ; Wed, 29 Oct 2025 10:08:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1689D6082E; Wed, 29 Oct 2025 11:08:52 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="qg2YhQLe"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 224CD600CC for ; Wed, 29 Oct 2025 11:08:51 +0100 (CET) Received: from pb-laptop.local (185.182.215.162.nat.pool.zt.hu [185.182.215.162]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8780A15D2 for ; Wed, 29 Oct 2025 11:07:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1761732421; bh=MIorx8uxUUa7uD/nRk8vCVkNWIYW8KbeetvlQXZgxKU=; h=From:To:Subject:Date:From; b=qg2YhQLewt+duuG+zsmuxNFCaZw22M0liYxkuyqUQTjkI4qAToZbo8n936cdVHI70 CVsyBbt374kUW+uQM26iFhewwMc8i4Ti7r9eYQ6FAKyza+GuZk1sSq1m0zdzQ8Sex1 fJqB8VhoP8NK7cvkTyubKXnCLv3U6nnssHZOQbZA= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1] utils: checkstyle.py: Accept `Closes` commit trailer Date: Wed, 29 Oct 2025 11:08:47 +0100 Message-ID: <20251029100847.730477-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.51.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" `Closes: ` is recognized by gitlab and closes the referenced issue automatically when a commit is made[0] to the project's default branch. Now that issues are hosted on gitlab, it will be the preferred way to reference the fixed issue from a commit, so add it to the checkstlye.py script. [0]: https://docs.gitlab.com/user/project/issues/managing_issues/#default-closing-pattern Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham --- Two questions remain: (1) should the regex be stricter? e.g. r"https:\/\/gitlab\.freedesktop\.org\/camera\/libcamera\/-\/issues\/[0-9]+" (2) what should happen to `Bug` ? --- utils/checkstyle.py | 1 + 1 file changed, 1 insertion(+) -- 2.51.1 diff --git a/utils/checkstyle.py b/utils/checkstyle.py index f6229bbd86..219921bc9d 100755 --- a/utils/checkstyle.py +++ b/utils/checkstyle.py @@ -542,6 +542,7 @@ class TrailersChecker(CommitChecker): known_trailers = { 'Acked-by': email_regex, 'Bug': link_regex, + 'Closes': link_regex, 'Co-developed-by': email_regex, 'Fixes': commit_regex, 'Link': link_regex,