From patchwork Fri Oct 24 12:01:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: rui wang X-Patchwork-Id: 24802 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BC61CC3259 for ; Fri, 24 Oct 2025 12:01:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0168260974; Fri, 24 Oct 2025 14:01:28 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="HjIQFZ4D"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 766C36096D for ; Fri, 24 Oct 2025 14:01:25 +0200 (CEST) Received: from rui-Precision-7560.local (unknown [209.216.122.90]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 43FC1EFF; Fri, 24 Oct 2025 13:59:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1761307179; bh=x9u3ebRjXYSB1DDO701/+1EJqBqK/snOiGp6Mn+GN9o=; h=From:To:Cc:Subject:Date:From; b=HjIQFZ4DFbGBJs62idUTUHq34xfq4BAQ5ttjzock9WsR3PvqNj6Wr3Qu0RKEEZGYq S7rdzyuxg+F/3Kf7t0sZq9oW89cFAMzj6mBb1cFWKoXicgugo3aEX//C+gJkJlJWTz 9DkXHeajl1BFWbRc8L2GAenxSRVc3P7Tuh+xOt7A= From: Rui Wang To: libcamera-devel@lists.libcamera.org Cc: Rui Wang Subject: [PATCH] ipa: rkisp1: dpf: Enable strength after enable Dpf Date: Fri, 24 Oct 2025 08:01:07 -0400 Message-ID: <20251024120107.681968-1-rui.wang@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The filter strength configuration block was previously only enabled on the first frame (frame == 0). Apply the strength values when denoise is active. This prevents the strength config from being disabled on subsequent frames. Signed-off-by: Rui Wang --- src/ipa/rkisp1/algorithms/dpf.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp index cb6095da..e95fb95d 100644 --- a/src/ipa/rkisp1/algorithms/dpf.cpp +++ b/src/ipa/rkisp1/algorithms/dpf.cpp @@ -251,9 +251,10 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame, mode = RKISP1_CIF_ISP_DPF_GAIN_USAGE_DISABLED; } - if (frame == 0) { - auto strengthConfig = params->block(); - strengthConfig.setEnabled(true); + auto strengthConfig = params->block(); + strengthConfig.setEnabled(frameContext.dpf.denoise); + + if (frameContext.dpf.denoise) { *strengthConfig = strengthConfig_; } }