From patchwork Thu Oct 16 14:07:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 24691 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8AAB2BE080 for ; Thu, 16 Oct 2025 14:07:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A741D60689; Thu, 16 Oct 2025 16:07:06 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="PQQdTucQ"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 12974605D7 for ; Thu, 16 Oct 2025 16:07:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bIi5m13jE0cHCqJ/sNK7bs7OagrkcVHquuyOPXwr7uk=; b=PQQdTucQQZQUKU99Aoul1stOYw HPEBQQZMOequgyNGz0/vPvHRphw9Pab3woiz0XXzyD+ne60mhtipY6VFKB8wBH5P8fHX+Rp6Pt4kU k5pqmGCvgHG0jg7FAXAqu0fkhEWIIdZrT+pG8iIE0Zc7Tx+lyBNC7fe4VlG+2vsB59BzGsvOGyHI+ Aa+mUBlXrqgI+D+7QccRvxc6lTLE/lhdNYMzKL2z/0pmCeizmqy18SQg2dfPV+VRi1gE3zCgbAxMP uwpV/Yzn+i0sxw0TzqMwykTAebknb8xCXL+mI6uhk4Bil5WaHKJdDGWl4m1+Lw8UFUyZ2Vvk985kh 4I1hbrHA==; Received: from [49.36.127.56] (helo=uajain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1v9OdC-00ATPu-Nr; Thu, 16 Oct 2025 16:07:03 +0200 From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , Umang Jain , Kieran Bingham Subject: [PATCH v2] libcamera: request: Clarify ReuseBuffers flag usage with fences Date: Thu, 16 Oct 2025 19:37:19 +0530 Message-ID: <20251016140720.216006-1-uajain@igalia.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Explicitly clarify the usage of Request::ReuseBuffers flag in context of buffer fences. Fences are user-supplied and are not re-cycled as part of Request::reuse(), hence document this behaviour explicitly. Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham Reviewed-by: Barnabás Pőcze --- Changes in v2: - Use \note annotation suggested by Barnabás v1: https://patchwork.libcamera.org/patch/24070/ --- src/libcamera/request.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index 26bba8f2..992d476e 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -327,6 +327,9 @@ void Request::Private::timeout() * Don't reuse buffers * \var Request::ReuseBuffers * Reuse the buffers that were previously added by addBuffer() + * + * \note Fences associated with the buffers are not reused. + * This flag should not be used if fences are used. */ /**