From patchwork Tue Jul 29 15:49:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 24027 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EDD33BDC71 for ; Tue, 29 Jul 2025 15:49:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CAAB7691E2; Tue, 29 Jul 2025 17:49:47 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="EFwTsf8R"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 89F1169052 for ; Tue, 29 Jul 2025 17:49:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BlNt7A6i7Gm+o4BFrXhna9avuo5GipneIfGKo9FY51w=; b=EFwTsf8Rc4pFqbMdWatD247e5r Cly9Ds5ti6bjz/Emj0QCydc8ZXg8N2TF2pMcNv/TEHeIiqVuHo3ISqZ8b02awR2uggoBcezPwy69w bB49CjyYWPNCdaCAYe5mOe46DpPUVvxM5My0b4VNfuSm6p10S/5O1jN3TE/vjnnJRaYLBE+0GjCmU TiFpLVq+Pyj643yuPE+JFX3c4ksCDemkg+lYXDq2paT/oCSCZNX8/EpFp2hJi43ilQxLyHKIT7dln 9ASkDXmBPQmvW+yriiceIrUD+x4hvKL6Z8iFqFCA9gikLmn3ugUSAflx0vo2JHOlYhg/hJFJEPXHA 1CIMW35g==; Received: from [49.36.71.87] (helo=uajain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1ugmaH-005V6x-9A; Tue, 29 Jul 2025 17:49:45 +0200 From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Jaslo Ziska , Nicolas Dufresne , Umang Jain Subject: [PATCH] gstreamer: Use G_TYPE_UINT type for libcamera::Size Date: Tue, 29 Jul 2025 21:19:54 +0530 Message-ID: <20250729154954.161715-1-uajain@igalia.com> X-Mailer: git-send-email 2.50.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" libcamera::Size has two components - width and height, which are of unsigned integer type. Hence, use the G_TYPE_UINT for initialising and setting the GValue for libcamera::Size in gst_libcamera_gvalue_set_size(). Signed-off-by: Umang Jain Reviewed-by: Nicolas Dufresne --- Based on [PATCH v5 0/3] gstreamer: Report camera properties as device properties --- src/gstreamer/gstlibcamera-utils.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp index ebc43f6c..e13ed43a 100644 --- a/src/gstreamer/gstlibcamera-utils.cpp +++ b/src/gstreamer/gstlibcamera-utils.cpp @@ -629,13 +629,13 @@ void gst_libcamera_gvalue_set_point(GValue *value, const Point &point) void gst_libcamera_gvalue_set_size(GValue *value, const Size &size) { GValue width = G_VALUE_INIT; - g_value_init(&width, G_TYPE_INT); - g_value_set_int(&width, size.width); + g_value_init(&width, G_TYPE_UINT); + g_value_set_uint(&width, size.width); gst_value_array_append_and_take_value(value, &width); GValue height = G_VALUE_INIT; - g_value_init(&height, G_TYPE_INT); - g_value_set_int(&height, size.height); + g_value_init(&height, G_TYPE_UINT); + g_value_set_uint(&height, size.height); gst_value_array_append_and_take_value(value, &height); }