From patchwork Wed Jun 25 16:14:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 23655 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D03F0BDCBF for ; Wed, 25 Jun 2025 16:15:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A400561533; Wed, 25 Jun 2025 18:15:02 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="eOSWFVqc"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A9F3461533 for ; Wed, 25 Jun 2025 18:15:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VqJC0R0uBZB5SynRyIO2lueJbUzL9yTBwj/CKCvMJqU=; b=eOSWFVqc1FvmplAIkSGQ4KVZG2 co9sOV77X7HAl/5eDYEwiF+dgMiqdRsUkx8aawoIrEU7r3uUl9fKA8d59IZkCLKOIo2uscSWSG2ds 9iQM6McV2fUqEQhGhC8wdY2XWGqIJVSpjovkdVaIWhX6eIVjs+bs3o9q/33Bi6olIUXnMHIphJYK/ Xv7eP6nypg3lrJMzBPJgjHszM+RbrOihptJ3twzDfTbIQdvWtaqYP2k9jQWk47m6YtysE8CsY54d9 o6TpgImYmDhuTa7TJlj8jostYhgIpck44RIbIFa/j9PDgsukrsU1+ZnXBW2FWtVurFsjKK85Pg8g5 ve3X4c5g==; Received: from [49.36.69.141] (helo=uajain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uUSm3-008bHs-Dv; Wed, 25 Jun 2025 18:14:59 +0200 From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Umang Jain Subject: [PATCH] camera_sensor: Expand on computeTransform() documentation Date: Wed, 25 Jun 2025 21:44:58 +0530 Message-ID: <20250625161458.31006-1-uajain@igalia.com> X-Mailer: git-send-email 2.50.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The description for computeTransform() when the desired orientation cannot be achieved, can be expanded a further bit, to clearly report that orientation will be adjusted to native camera sensor mounting orientation. Signed-off-by: Umang Jain Reviewed-by: Jacopo Mondi --- src/libcamera/sensor/camera_sensor.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp index d19b5e2e..6f4a13fe 100644 --- a/src/libcamera/sensor/camera_sensor.cpp +++ b/src/libcamera/sensor/camera_sensor.cpp @@ -302,7 +302,8 @@ int CameraSensor::setEmbeddedDataEnabled(bool enable) * camera sensor, likely at configure() time. * * If the requested \a orientation cannot be obtained, the \a orientation - * parameter is adjusted to report the current image orientation and + * parameter is adjusted to report the native image orientation (i.e. + * physical mounting orientation of the camera sensor) and * Transform::Identity is returned. * * If the requested \a orientation can be obtained, the function computes a