From patchwork Wed Jun 4 13:14:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antoine Bouyer X-Patchwork-Id: 23469 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 46DD2C3237 for ; Wed, 4 Jun 2025 13:13:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2D64768DC0; Wed, 4 Jun 2025 15:13:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="Qe5HbtFx"; dkim-atps=neutral Received: from AS8PR03CU001.outbound.protection.outlook.com (mail-westeuropeazlp170120005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c201::5]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0408168DB3 for ; Wed, 4 Jun 2025 15:13:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NsdT++JcBnrHv5I6dQ6WOnokWB8ODGYA18h0tut4GR5BKrFyGDvSWC/1pFdGIT5Hy54snu+gkORPd54WwxL4FdSW4nZroZBExc67POFmJlf+6sNgfuM2MmlBSfC8u7YQE18rcxzqn911iUlhycGFi+OnPujRTECMWCqF3NHxThMW5BhPP08CSljMT2OyTg3h/zT3DhDzIZ8G3Xga2oBNPVMzJFKnH74SJVA8Mc53rO51ZX3lMuZnJIR5FKDTw9OEkxFT8pvsi7JC4D/nTNwtH28cupUlxY6BRB0u6KbpCizAHt7EDwBuPlN6uaUlk49jhRU6+R6HHYwbGS9HVfG57w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VN6lxGHn9HoP4cXq8Z0jSd1IJ4C/UikCVuG43QqIH38=; b=P87hOtKzA1hAXulSakH4w4WQCNwTICPQjrnd+dMFp21DteemuCl+u9/qEj/xvIZgpjZLaQqxieNAglp51gBkCKXz1OOyaIc7MAiBv7vlmNNowJG7+bsR5xgGT87mWRZxMae6t9R4Xz2yHfYV52ufvcEsbVz+DGecRmJknFdFaO40zgBh32+O13YhF3kSv7CVSgXU4puRtZ7L3sFxFzBqRoX/TreCQxXhm3Lz02xnFHD9g4W50d0Z4Isf0wAc7C/8WSGLgPzSmCm9rlJKXQOXMGMTKdw0hj8MSwQnXCAWWhq1rhj054pAcU+y86wOEACbnE4YDD+noHE6pzW6U6HIBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VN6lxGHn9HoP4cXq8Z0jSd1IJ4C/UikCVuG43QqIH38=; b=Qe5HbtFxjKxiVVE8kgLjT0gYRTbiPeOkJMS9fck0qdoRAmCpc+UJ5rz6vIL0Z7wkyrP5/hBbxhGpQr7U8hLg9q16F1OdedX8iOGFeAzBByxl2mMzZVpWGKxzdIDBr4jeVOSNCu9Ua78QPBZlzpY93vh6dzS/L3PJQLdH6AZzB+qK3Z7TF1xVy1ro3q4Y1/7ItfJVlDd3KWJNLsbs/o+0KFccr76PkLCCElMrmMJIn8g0T0SmFhhCJwM0vgVP8vyL+Aa1aFLKlIyE4m/uXpSnCwYeFw8Iky2FVICiFWC1XBu+pmjr0DRoVGoCqMrUpRon/Sd/H7sP0H4TkUMfCiP9QQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9817.eurprd04.prod.outlook.com (2603:10a6:10:4f0::16) by PA1PR04MB11057.eurprd04.prod.outlook.com (2603:10a6:102:48f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8813.19; Wed, 4 Jun 2025 13:13:27 +0000 Received: from DB9PR04MB9817.eurprd04.prod.outlook.com ([fe80::144:cb06:336d:abb3]) by DB9PR04MB9817.eurprd04.prod.outlook.com ([fe80::144:cb06:336d:abb3%4]) with mapi id 15.20.8769.033; Wed, 4 Jun 2025 13:13:27 +0000 From: Antoine Bouyer To: libcamera-devel@lists.libcamera.org Cc: julien.vuillaumier@nxp.com, Antoine Bouyer Subject: [PATCH 1/2] pipeline: imx8-isi: Cosmetic changes Date: Wed, 4 Jun 2025 15:14:02 +0200 Message-Id: <20250604131403.1729356-1-antoine.bouyer@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: BY5PR03CA0019.namprd03.prod.outlook.com (2603:10b6:a03:1e0::29) To DB9PR04MB9817.eurprd04.prod.outlook.com (2603:10a6:10:4f0::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9817:EE_|PA1PR04MB11057:EE_ X-MS-Office365-Filtering-Correlation-Id: 5724ef3b-9da3-4c5a-4e00-08dda36997a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: eEJaTUyC+00XvsA228GE91fYyAeWXtwQ9LZ7ql7AOvgqgt0/oUwioa/tDbRRXW0GJwq/w1B7ihn6IRFI+2iC3srrMN1aSMTnCCdxbfpVlF7OQ6DastnHaE6TQd65kXKpnyNy0oc0rUEUQ5q2pHC05dEhlYcy909gtRjjVul+BQ2NIoGa66IbBckIHenNBX++2K2oRTxcKFWyQYoDISl7ffVwm/4qNy+siDDVFtMQJnkidA1dZyYFbg2MfnHj2n/LEGFLxX81ULYt6kxB//rOJQFLQC7v3Rk3/qk0XYk95WjLUAGm++ZV8Tv1Bac4Wee7zciOwT4OF+IOVTNjlxqzIsd/S5L9kbFj7kKbxxRoq6z8RI19VJgkoMkcT3mjX8t0i3+KbVNCzpMVPiwgOGffP3wj9oGKToBFZIAVKbqBvkWN23lF9alef42zhU3ldsKyGzljEvwX5hP0SzSxSRMKkhW1aGw4/n9hcZnEU9FdD+iRgo8MRkAK84OPclCYmSj+FiffM+kfipYgVabmwFsRpgInSifNnXtLttvNzdfYTYZ4CDumpBkkP8Vt7Yw9EMEHm0EAnHZZZFHJpE7WfR+dEnz7rnnXGXsYrRKAMc4Ewu2vtakf4I2YGg62h46ZFI66670IpwWKh/0DpANAH4QKXzvDGm+6bkFyE4wO39bH1RpQ7ASunGMdn4OO6pg5sRHvWx3FPaTjXrE9OU8+fcnvMR9k3YkGE1cN5IgErQos3JxewI2yq9pwnoyr4fu+wk+z4Z6Fub/l25U04RPkLuKWHNev01pkwy5ORhpGaN9p9xGOnceZ1QmioQ1eL7n5bCdtij8QS0605g8xQ9IO5jb5Gk7hCUEwSIPrOhxlgGlIgivi5/b1olX1tZN0Ucnz3im6Qh6cw6MFqKIWoN6UFEuYod2O/A48tDUfxbTMsWKvj7z2TSDOxh+6i8QgvGa8hBgeczc/tVtYQ2JBRVy/LcdJEg02M3E2I/oS1XEUkqDHFdFs5UTq1dFZxWmIV31nXnd3HBpR8mZs0IGOZV9zeUviVRiT9A6C8k+z/vlI92Mj75deYYQt5AImDbMriuXP3kCPh5f8Hv7qcjjXrovQvXnGjhjyFDuwEnAugQEj9PBxCWszgm7gdE+E9cBxgL1N/22Ouv6v0Xke8/ds/fcEbd2g+mVKeMYU1ZAgxmo5gXzXZZscjAyZ25CMUdL3Nu5MM2oX4M9rhFW5SVq24oVRT+g24DdyOtKQAKpXUu05Gfcdk4ZfT0GOnD1JncXQLaTRPpOdaUN0vEeq4P//E+02rTZB8wzb1MT+19dhDzagzXMAIwrmixbZYanI+jh+Q3m2nbL/gNGzUpA9Qjz8MCzwNWmx/c5MJ7VDPH/WuD+qebvlURLqyW+ZgwPB1k64ZBegEcnq7+St6SN6vxg41wTsrU5Y/KqI3bE8cRmY5yXXLPesidFkw4cWi05Mvs6PBu4C+WhnAVLMR81VS7G6rOtFVNJBnA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR04MB9817.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: G0InHjYy73oBRW4gntDfN7EnqQe/1kiVXN20G32ZWgkL7GqC0xsI2R8/UEfT3XxnlKABVW2iR436h8wZ6uoSQR3Wc3HYVyrox8iNcLVrIFZexmE3C8F+9EGVCBQVfgv1VYsfwNXZ63ZnnCYBgRtpaFfX0Iahqb+a410kFc5mYwz0CiDeNn+tGZUljAFoATuaHNRFVnqPIgEPu4UPr2fAywnuwBjT9Pelu5VOgSUdh0OuYy/fnblthDWnWOJTfDTRgckktpWro/tmb8OI+Z8dfFepNI5HRyoggKcATnUkicpDd7/ndTLZ8cuTfajQuRQV6iQVT6AL/nu/c/D/3ft6b5z6Q7zQGA99pAFd5jMJ0y7l8iF3mCDg7B7CLOYaT3+RzpscDaopy/bDHQZ4vx9Vk2ULV+Uze/BQCB/D7jlpM3lGuGbeF6w57faumz72OwHcfpJk5pbCaAEl/MHYtTPmv5virgku9mmCL2xHH58rOSNA6RNMxNebzzQ9XN5EDm9aqfgI974FXBbqra2r/Ho749CkgRJi/y1EYs6VcL9E40MaxaX2vv8FNBwTBZBO8AiYpSefGDvF8trpnZ6u+eYmx11iNsWVMf57uGWwE52SmmR+8riTcp05IocWra9TuAgJdAHFpn+UtE33Jx4L8bjEWxrzgQNb1peL++Dv1fLyXO/3gS4K9ycI5ckYmKuUtHy+T4aXtsdmrswuezGv6YZxhfECVUhS9Ju94YjS43nam/LTyozIPBQkvMBHT4JbhpV1ZeXiz5j4SFopN7SNIjuoXBYjQY0gIDQGmvr0kq3PfwyLBI26y2goNzTTt6Zhw1V/n7WBTS9+V1QO5D2H3FTDumoKOLpaGIc6FFKJ8Fksk6aUJTnm41KIy4BMvWPsVVzQh+23aZVaiJXAl43D+0j2aLkXJkyL4irECqALNKwBl62blEmM8ohDTRJv4KnItxogP3rezY+hGNAdU66dfHUbi3dJ3K6FObQe51VLJOugOT/shqYniPherStkY+2M5rIZENTYJXj0t0NH8Rzrc2YNN4UinhM++Y3u/MWdV2gy0rAvbH9/6IRhD+lpIC9HNQ4LFoHMNd0KHTqwdOWXqYzaYpri4adHMxcjezXpBojVhxxb5ldTC+6/2ubzTDdfDxGV3i4SPlLaBd0b6jrVTTKGolC8p3BFcnzPuXSf+bioV7YRvnHASLwF7cxI4bM0VYRn05KDHo4p4ag8R1UajotE711wCPYDfRJZiVyZnrJJ8F98yyAeVc1lgJY/iyRDfgtTBHXHyLr84qjkPOaVPQ+6SX1Nh0VvZb/4rMU6GGffVIBf45L+uXVt81dNRYllGEEbQf3Lf8BO3G5ortWCFlmNTN0CWpGpjMmPVzVc8Iz71af/uRq34VBQGTc81uA1EMdm/9GdYL73zUQOOge3qNoAhowpPJmqaELJJBxWCVv/f9MW3AcZky+ZMHagarE5yczZJzZa6Vs6WV06mq5DkSb4iKvWeRuKRxX/qHpIcXtBLTZ9VZLVjheycroBl38HwnXgRRCuqNjDd/+Ok9RaIWyw5CID0B3fslS4WdNTchi7piYlDf/pyu652c4UMTL5A2k3CZferT1Un/TATHZJAGOZPg== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5724ef3b-9da3-4c5a-4e00-08dda36997a2 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9817.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2025 13:13:27.1350 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ctPOEvSS5yEAnI3l6dzHRGm0jo2QepcAv+WVSMwCYvtdsA7EykKVcP5Vmgj847WEcmQpu/wYAL38DbhvpXUq0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11057 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Change indentation to pass checkstyle script. Fixes: 680cde600509 ("libcamera: imx8-isi: Split Bayer/YUV config generation") Signed-off-by: Antoine Bouyer Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 46 ++++++++++---------- 1 file changed, 22 insertions(+), 24 deletions(-) diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp index ecda426..dc20ab2 100644 --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp @@ -761,30 +761,28 @@ PipelineHandlerISI::generateConfiguration(Camera *camera, */ StreamConfiguration cfg; - switch (role) { - case StreamRole::StillCapture: - case StreamRole::Viewfinder: - case StreamRole::VideoRecording: { - Size size = role == StreamRole::StillCapture - ? data->sensor_->resolution() - : PipelineHandlerISI::kPreviewSize; - cfg = generateYUVConfiguration(camera, size); - if (cfg.pixelFormat.isValid()) - break; - - - /* - * Fallback to use a Bayer format if that's what the - * sensor supports. - */ - [[fallthrough]]; - - } - - case StreamRole::Raw: { - cfg = generateRawConfiguration(camera); - break; - } + switch (role) { + case StreamRole::StillCapture: + case StreamRole::Viewfinder: + case StreamRole::VideoRecording: { + Size size = role == StreamRole::StillCapture + ? data->sensor_->resolution() + : PipelineHandlerISI::kPreviewSize; + cfg = generateYUVConfiguration(camera, size); + if (cfg.pixelFormat.isValid()) + break; + + /* + * Fallback to use a Bayer format if that's what the + * sensor supports. + */ + [[fallthrough]]; + } + + case StreamRole::Raw: { + cfg = generateRawConfiguration(camera); + break; + } default: LOG(ISI, Error) << "Requested stream role not supported: " << role; From patchwork Wed Jun 4 13:14:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Antoine Bouyer X-Patchwork-Id: 23470 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6A52FC3237 for ; Wed, 4 Jun 2025 13:13:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1ECE068DC3; Wed, 4 Jun 2025 15:13:36 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="hPIwSROM"; dkim-atps=neutral Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazlp170100001.outbound.protection.outlook.com [IPv6:2a01:111:f403:c200::1]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C0EC168DBD for ; Wed, 4 Jun 2025 15:13:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NkCluYKQm7yWax/mO6IKC/vi3kTVgIiEaMJ/Yb6HVKRL6t7KPO/BmmhD+BDqnR3aFllQUHMmFs5bFN281MJ8lJ0wSEa5ilOOwnMoOJqFs0O99qW6wJTJJRUdLUY5wEFyl38k9ZEwlswcemhGrS0z2DLKYEvauAnealeW9wGjVj0PwdTrJX34v9olN+1WKiJ+AeVUHSze3HkbMPWuffeuEr1pswDbnP1ucO9NheAMLGP76ZYLanR8W3khl8gRBcQTKBoETjAHoVqtmSyAkXJntMcn+/LqejK+isI94S2DgSVSyIi/i1M5wKpO0T0W/iRYGr63shvfrLlPkbtFJN2V5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4v3eY4QbRgNlE+oQbkrgwiQ+umj4LIYI+uzNyrbZuYU=; b=sdTKOr96GHyKuz2FYHokxFO0O1K/2fdgJo7vpwP0PNgADnDbvJFGvoq2XqI1MzR4aTX7pkMqGu+19D28fn+9dkkPRME51txCVWdW/Hm+C4ZXpc6buczP2Zx14Yy+4qXrOov7Rq1kAvw/RdpgUYziJHLBJnnl+kncZ7QFc7o743ztlwwCfpucr4PfySSYILRCtri09t/JjeD5FmMba1ieBo4vIxQbFabnQiotzEXJOlSQrEnzGEGCt+f820lype/ddRO4bZij1c2dT9nUVCPFuOoHy3mqfMkbUW8QXVEY4d7ZEKWoN4aWYftSYueuT8Hwc96azd7h7TDEkhX6p1QQFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4v3eY4QbRgNlE+oQbkrgwiQ+umj4LIYI+uzNyrbZuYU=; b=hPIwSROMLvGPipC0nSzRHv7kInZ3eKj/cM82ihJ3qFpb8au1M8dC5mPL/0VT1/UDvUqr4y8DqHNpmhvvxQFRGPuG76ooKqUfwGmm4Y/KTcHzp5m7ozyiIrJa+XATErl+mJ4COl/eWdyAUSRELFnCvV/4NDJ8cDMWyAhYaXUEpUhb/YxNzW7jlB3Ur9OQS3X6KAIzQXaw3g1KqO5MwO41UV0w1KkzHYz642aU8KASOl4DWQCXwLVvSsURKXt0Rhi1f4KJgC3mrbn2Bl9q0sf6Hb8qyhj488912fE86VXLlJ/HgtVDLDj1sfk3p7eYbgQ4A0wu6E3/Jt0PV7CQcdtoHA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9817.eurprd04.prod.outlook.com (2603:10a6:10:4f0::16) by PA1PR04MB11057.eurprd04.prod.outlook.com (2603:10a6:102:48f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8813.19; Wed, 4 Jun 2025 13:13:33 +0000 Received: from DB9PR04MB9817.eurprd04.prod.outlook.com ([fe80::144:cb06:336d:abb3]) by DB9PR04MB9817.eurprd04.prod.outlook.com ([fe80::144:cb06:336d:abb3%4]) with mapi id 15.20.8769.033; Wed, 4 Jun 2025 13:13:32 +0000 From: Antoine Bouyer To: libcamera-devel@lists.libcamera.org Cc: julien.vuillaumier@nxp.com, Antoine Bouyer Subject: [PATCH 2/2] pipeline: imx8-isi: Fix match returned value in error case Date: Wed, 4 Jun 2025 15:14:03 +0200 Message-Id: <20250604131403.1729356-2-antoine.bouyer@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250604131403.1729356-1-antoine.bouyer@nxp.com> References: <20250604131403.1729356-1-antoine.bouyer@nxp.com> X-ClientProxiedBy: BY5PR03CA0019.namprd03.prod.outlook.com (2603:10b6:a03:1e0::29) To DB9PR04MB9817.eurprd04.prod.outlook.com (2603:10a6:10:4f0::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9817:EE_|PA1PR04MB11057:EE_ X-MS-Office365-Filtering-Correlation-Id: c524f712-dfe2-476e-14f4-08dda3699b0e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: 47tQeYTA1DEe1DaMB6oH6E6KbISqjAEfm0e3MjaxSxFJOlsqNAwqkI/6nLdu3RtIHAau3JteLsPtelBg6q4Ny7aFNbFlQjLIg+TOiyztr54k4iIA8n8xbCgVhx8Jmwfh521AOzhmpH9nGfdbeU8HTPgtJ7afh9UldW033FefWGFRTXOyCALj4XRa2I+LmiLBWsPOlvqp8EVLnX8bMNvSGlH/X5hw905dMm/pnkYu28dAQRUHqzygrZ9pcW/sTwystyo3NegrprmN/cvxNfSHCETz3nJTHzen3pC0os20aRaGDfS6FFwEfrSo0WE1VqkSG1K+FTVDPgNFxC32+Vw43YvBTy2q2q5skIfmgKeExu9D4v8IjhgQ3ShQOwRCTQ2+uvhqFLmOC6nNkIaECJvmIoS1h/h+wteAzztBCS7SwV6Snd4730fGMEma+8QJ1pvfalDy8bPvxpm8RpAvf5VpqkM7mPFoalJXRetODNrofXwuVPoOQEGXnV9dpL7eMkpcL7AZpKAfUf9Gff8Wamo2Vki5Z8WShbxnT5ZwbWTv3nWvxIdqoZ4fcvh/iwsyel93KlEZw/sAedYTdU+bsw/KgvcPVFQphSDS7cMc+f4hEiJ+S/hZEows7wEwxszTrYrOgjNuW7So5PyV186tF2ZR77fIsZQzwJ4E+OoeAMUWp4yuMZddZJ8lY24odTxOGSkQ1+qgjDNVUmEiaUaw+xds3RIcvD08TEFchuoKRSfddNXESxofbkV1P0U1i0qYQOwQu5TN7Db4frZ99QOviVjHsp96Krf3oih7v6aiiv1PriC7VdG3r7ujiQYOpXJZGxe+8WCDo2vzBnVCt454vPhXPfRtj7qCHGzVOX+QlxxejKjDahJhgUwr7E1Gkay0sMKo4VqtezBjm1ylI4WK/iGxxYilgFco2anxL9InnvZ3x1OpRogrR4ptbWiKRI6ufWac2ywHidBpsI2HHz2JA8hBSG9GCdyQxy9yV3aZxhWws/FNfMDHfwkikVUMf+3Iaw3p2Ee78QOBbL9uyu3a4KjbNng7xUhcuAmOQMBb1gOGAvOujXaWa0GOTnH2KT/5NjZra6Y2CSlzKm3GzBTF+Xrlw4y5k2qQrcllU2yqvmuwvSORQ/0GVtNV1tkLZ+j3uVC5rCKD6Adoq+PwJm8+o47zelIFcjhK7xJQqouEtMOWPhc7OmFHcvLn2DPQe3UVeYKu8C3R1MwyEbP27jp4aonudxRpuJmsoJxTg50DlQXG6Z9pCYz14mkZjhcN1KDnhImC+ruJ9+JgOQCgLQTBvxr22ZUHPoKyltvy9NZlvrTlQdiWRre7lYGsa5e+SB+QSReFqrtFXHQn4aGQdv0ksKHuaexB1LnYXIHMU2SqJQ9dcjP3LCp4ZakkExFj5s2xb5wF0ZF+Y/5Aog4qj7ZYnWG/GY6Ofs9eLAdJOLCtcztMFVSg5nz4Y6rRhT5wWgIeeToMG/n5bTBs3eQ9q1NQ8Z/5ag== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR04MB9817.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JA85TrXkxvfs4rpWPFxQXzdEGjpCuCYKCt5Z9OI853Vm012vBj7vFBxlwkJykcSMKostJWiB37leXW2kUUz0oKqy1o5wa0WDILkk+7i3lq3HSqnDgapa+TY0aJrXtbjXMsU82APGH6YpsL8OFGGku8O7y03Y4byw8OPObuJ1/sSUPrGCU0iR7e7XUcJWpZPeSWHtAulFooSO66knaLc5lriSkcZMA/zSZafCzs0koakNQrqD2FrsGPZcG6Te51LZiFbMZHX7e0Vgv1Lb7oujco/iSmEzuFLC1npA9Usdp01sI+bF2cZ0kQX+6Sv8Js5RpYaHXEKTv3aHdCff4i4NWN4G6jmiY5Wghej+NMy8cUzOoK2y9OtAl1tSbXkX9LGYrjvSD1vQlg0dU4J/AArzLlXIcq1XMA6YTf7WgApmFRgbBFkdXCYxpMEvqNykneZHkMTobsnzb4L+7YOgqFCNLZlqcxbtJUG7tqSN+pFSnWE0yd9bqvmzfzYiWMSvjmxPV5SAyWL0TccXe1uDCgYEJ39NgS5DXz15jBXJur1keEdld/2eDu770p04OCV52ceRhope6R9oHyS/D49dEdhIXfXVhLmBYCnKNA1JeACX+3hcJkkPzUMYfYqr6sE/Lu148qx9WswCOBWQUrnj4IzzPKwX8xeucvXwHBXLHlup9j1FlGedifQp8F9zY7EaO1bDLD+UmQL0Fd8y1BmHA9fiP2bRZjN7TxzsXnXItPVxdLRZuyrTEipdSD7SDThJwgbGgZzZGgFvSRzYZj/snzOYBSi27FtC/z4IlUxlzyMivm0lxmN39TFZo/Kdi+3orcUBqZbcoyOIju2dwNeK0fuUMGUlX1XwBOcjTF0gSXW1F5nidR5cPed2toDmpaYm+EvyWiHp1oUM2erm3muyemD0pqORjBHbINXh75HM5riJmsnmyseihR2VUSoIXiZajAjgegO3jDKuN8zSDjEx9EqL3X8p9rvcpTcDXvkjG+B7sxq2fwCqOCKfm024/EfyWhvfbr3QbD+PMxny3hHZ8YpHnC7TRCDiXYXtgriXrhCu9/SOpmydRiVlD8g3gwoga8dW2p9XTqaHgaacoQKRVrs0FdcErGKmWFpxVdAz8jMUsntAm2HaqSHf3CkRX/oWZNs2Onfyc962XL12VExdgy72rIni80ZChEWPj9AxtQtYSI4jj6c8uNdNDpe/OTBOEwEneB30OGb/jajcDqDtyguV/yvCnFjL14AB+iCTmnz2ZSYxctV3lwItTwgvN6jKBHnz85Idvn8Fcozh/zdvXOJedDAzDju8+5znLVg84O+niXgmX43BgZhiOVilKa2u4Fldh7Uwtq2ZxQvElxphpoBrEwSj61lZ6z8OoU5WGZWdCYojhCnb27Djg8nHAY43UaeRaLL9X24Jabe1T/3MPyUTYZRCNDNXvICP2wIvPWnwGB71a74e7e4P77SoRmtKbG+Nj/yHM8Qj+aHoKqisQXWErlahlr0gR8wyVfKIUYAWffRCgg0vBS7lwVI8AqHWl6ekcxD5O7ZKQyevurjKcTxUypYOLUyNm3ML1AVZjsJSN9yCcASaGqEpHqjXKU9pZD/+H5N7mi8MpjZ4HoHCGAF0kw== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c524f712-dfe2-476e-14f4-08dda3699b0e X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9817.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2025 13:13:32.8036 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4SP1F8Z5Bj1GLxrW+FwyGPA/n8SOJUqPnVZ7zFT3u8251uaqwvjR5lZ4vvYX/pI0OChSNreDun1LKM+cy/VEFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11057 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Match callback returns boolean type, while it could return int in case of error when opening the capture file. Fixes: 0ec982d2108 ("libcamera: pipeline: Add IMX8 ISI pipeline") Signed-off-by: Antoine Bouyer Reviewed-by: Barnabás Pőcze Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp index dc20ab2..1b7c661 100644 --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp @@ -1003,7 +1003,7 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator) ret = capture->open(); if (ret) - return ret; + return false; pipes_.push_back({ std::move(isi), std::move(capture) }); }