From patchwork Mon Apr 28 13:16:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 23295 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D04A0C327D for ; Mon, 28 Apr 2025 13:16:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 020D0617E0; Mon, 28 Apr 2025 15:16:24 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="oP2qrvwj"; dkim-atps=neutral Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B9E0A617DC for ; Mon, 28 Apr 2025 15:16:21 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-43edecbfb46so30659895e9.0 for ; Mon, 28 Apr 2025 06:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1745846181; x=1746450981; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CNYksSi8bqqIpsuVsVY2UVwkUyKSlBUhLt/UCD7I/F4=; b=oP2qrvwjoCX7IVFldaCWAbxwrG3pklSqejiywmSmlcp00RmHcaBy/CYhb2TgKvdmNo uK7eRHr/opaXUJNjLS0QN1Mcl0jw6a9jTeyXNp/Ig2iieg3K0VF+clynPpxyGk3VxMXF 7NIZZdtxDOofBfXxV/M5Ij5Sjb/Y+0HgOfoMlv86BC3RWoFZ6NHS8Mu0ZmuwtH2nCgiK Jqobx9F2KanJW/J80UR0oDewQvJ6bLvHJEVHAC5ceKCtp+sCFCCQgR054MGXmKoCMtTZ 0vmduOQwIEUZ8dVOWYyOrS9XupRDicXnbssHPxUVg7/7UnG4hdjxQKwcVXU54wZuQky/ 8EDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745846181; x=1746450981; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CNYksSi8bqqIpsuVsVY2UVwkUyKSlBUhLt/UCD7I/F4=; b=m3LT2hCKujpjRhFh4ZmKUk0N2VBM1JldbdwJj5DxM4Tp90oTDSBo6fowXW+LoXbEpr Ba4JAZx6cZXOpORFOrbnXgqFiChDQfoOA6cchfJvCFRpFAva8vT7qv5+uKScCHovRwCU HC303BiTH8sA3d0dg2gmi5jPDuogj/VJwQ4ztZwl2ebPij3gHq9xHHVs5V2vuGZg5QxW QHDXqA5JiYgr66Qc5Y37uXfxSbHz+nm6UYTGaHAeHyA+Nyva9cFxrtPgjOdxQttU2MLl 6aT1q+zHZ9dLeEAbwcvwD5uIO/NwyV7qV9pQ2ruCrgFWKSPmX204APaoisYeukcGRdvb HpOw== X-Gm-Message-State: AOJu0YxDRvPnv/x59YtREBrw0i7h+ayg1xyOPXkr3D3I4ttEJR+QmM06 BinNaDslg7SsriWYFAUSmoPoxtXqcYGsb+oQl/iLPZjW05/4qkMaGarrWjEMpG4dwqruPq0q76J I X-Gm-Gg: ASbGncu2BVgseHrluigrq98BuxH0rXMkgfc4+6JVMQHOwQ50pAYvaKy3vZcYEwMTSw1 TozN0oFwMTdGhmryc1S2thGeTg/EWOpHB1iokyhQumKb1UpEpl1r776sdwkKBXDBHR+veeA2pbb 1q9i8HJIwehHqw5wm0elHf3faV1XMlkHbjXdRgIOexJ9hCxMoA0UPBWDWaDeTzrXnS/B0+EZz5P wW+DZwrJwuDsvshiKC1KZSKV7PFjyHftBbnJceUzM7bsyr275XSxyUDXSASBQVWS7RnLaleus0M irPhjb+1YvRIPfNMD2FQDZ8DpDUbQqqu56Sk6vbZ/nUmLBmMti6zuWyoCJeYxiE28IFxaAGvPlp uuw4ur10= X-Google-Smtp-Source: AGHT+IGnQsGOJWNDl0q6CCdL6EXe4wQ79u2huNrkBICowVaDar0FsFp7x91Zvb6GB8neFXeeYx6Hrg== X-Received: by 2002:adf:e548:0:b0:391:2e6a:30fe with SMTP id ffacd0b85a97d-3a07ab9bcd7mr5890824f8f.39.1745846180921; Mon, 28 Apr 2025 06:16:20 -0700 (PDT) Received: from raspberrypi.pitowers.org ([2a00:1098:3142:1f:ffc9:aff6:7f7f:893b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073e46c23sm11068219f8f.75.2025.04.28.06.16.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 06:16:20 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Cc: David Plowman Subject: [PATCH] ipa: rpi: common: Avoid warnings when AeEnable control is used Date: Mon, 28 Apr 2025 14:16:17 +0100 Message-Id: <20250428131617.3507-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The AeEnable control is now just a wrapper that is converted to ExposureTimeMode and AnalogueGainMode controls instead. Therefore, it should simply be ignored when we encounter it, without the need for any warnings. Signed-off-by: David Plowman Reviewed-by: Naushir Patuck Reviewed-by: Kieran Bingham --- src/ipa/rpi/common/ipa_base.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp index 4c09a093..80c17588 100644 --- a/src/ipa/rpi/common/ipa_base.cpp +++ b/src/ipa/rpi/common/ipa_base.cpp @@ -967,6 +967,17 @@ void IpaBase::applyControls(const ControlList &controls) break; } + case controls::AE_ENABLE: { + /* + * The AeEnable control is now just a wrapper that will already have been + * converted to ExposureTimeMode and AnalogueGainMode equivalents, so there + * would be nothing to do here. Nonetheless, "handle" the control so as to + * avoid warnings from the "default:" clause of the switch statement. + */ + + break; + } + case controls::AE_FLICKER_MODE: { RPiController::AgcAlgorithm *agc = dynamic_cast( controller_.getAlgorithm("agc"));