From patchwork Wed Apr 2 07:31:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Gruszka X-Patchwork-Id: 23101 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D9E24C323E for ; Wed, 2 Apr 2025 07:32:10 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CEF876897A; Wed, 2 Apr 2025 09:32:09 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="lgb3+U0E"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7FA6968979 for ; Wed, 2 Apr 2025 09:32:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743579128; x=1775115128; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=eddFopoxjIrp9IByZCmAufpqoy9aH/Krce5CzNw/EBY=; b=lgb3+U0E5SPdzYKRDtKHcjf4pVonPofgNrva8oRVuZN0ECxhijlgsrMj 2e/yEG9EYjgieppCOvyec1sy8dSDoXyJKnGaunWH/Vq77OrfczM5p/hX+ ek7jvUEmjglH4CfRvu442nAVtmNEUfIAdWdOY3fVpm52Ufnzy9h+1FcKP zUwg2ZX3hONV9hii0gDFDNdEgsLGBLg4fW/Pi5SaemRsp71VU823My1S4 +TAGqFSgi+LRNBp39akcQLfFZFBbLAv4CSKDqPcSWoaFJxgKskAZy6lXg wve6jn9r7p7W1vqgaFtTv24pVDCiUZ2gMPNXyuYecRy+M96DE2jCjqMxf A==; X-CSE-ConnectionGUID: jGDRD+n6SGC+KOpRbL3Gaw== X-CSE-MsgGUID: kpWkOmGpQJmcu0lfoAaWDA== X-IronPort-AV: E=McAfee;i="6700,10204,11391"; a="44938467" X-IronPort-AV: E=Sophos;i="6.14,295,1736841600"; d="scan'208";a="44938467" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2025 00:31:38 -0700 X-CSE-ConnectionGUID: eW3TIL0iQ9ygvjFOFJuK0g== X-CSE-MsgGUID: bywYG8t9TIaim0qCc0ZFXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,295,1736841600"; d="scan'208";a="131481805" Received: from sgruszka-mobl.ger.corp.intel.com (HELO localhost) ([10.246.8.237]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2025 00:31:35 -0700 From: Stanislaw Gruszka To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Hans de Goede , Laurent Pinchart , Kieran Bingham , Sakari Ailus Subject: [PATCH v3] ipa: simple: Initialize ccmEnabled to false Date: Wed, 2 Apr 2025 09:31:33 +0200 Message-Id: <20250402073133.15710-1-stanislaw.gruszka@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" ccmEnabled variable is not initialized by default, which results in usage of CCM when the algorithm itself is not enabled and configured. The bug manifests itself as seldom reproducible corrupted video stream. Fix by initialize ccmEnabled member where it is declared. Reviewed-by: Milan Zamazal Reviewed-by: Laurent Pinchart Fixes: ac3068655643 ("libcamera: software_isp: Track whether CCM is enabled") Signed-off-by: Stanislaw Gruszka --- v2 -> v3: - update changelog v1 -> v2: - initialize on declaration - fix spelling src/ipa/simple/ipa_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h index 7dc2cd7ae828..51522720ab98 100644 --- a/src/ipa/simple/ipa_context.h +++ b/src/ipa/simple/ipa_context.h @@ -91,7 +91,7 @@ struct IPAContext { IPAActiveState activeState; FCQueue frameContexts; ControlInfoMap::Map ctrlMap; - bool ccmEnabled; + bool ccmEnabled = false; }; } /* namespace ipa::soft */