From patchwork Tue Apr 1 14:14:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Gruszka X-Patchwork-Id: 23100 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B2385C3213 for ; Tue, 1 Apr 2025 14:15:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A07A668981; Tue, 1 Apr 2025 16:15:28 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="h13SOuu4"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 24A8468947 for ; Tue, 1 Apr 2025 16:15:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743516926; x=1775052926; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=HPGhbBEW8KlFkNlFe0+LfcVS4ZQIgloPvZlZnVpS674=; b=h13SOuu44f6X9aCXOdhZb/fio1ggk6wXTMrmxV2AcgPQmkOe1Ot90gqd vrnurib6mNM7vWXhGyKjvM//VKvkCS7XP098pg5r5eTMhHj/zRyjn7Bo1 jaf585+G8NSe8Jm8T/WO7xehLV/W0YUXVnQuwQObREx267lCWiRgCUCMn ixveADhd2S41JVn9fIVVXmsTiKX59t9sowk+6ZnqGHiWWn1Jrm3WrJxHF 8R+yMxbzKCIgeaM0ZkZDLTdMqkG5Jdgelppcn1tZWf7cyULhhJhsRcRd/ at//N/XT67g1gYuZX59ix3RRKTbLqbYwRrLXTWnYnKhxuD5RcL0wXxyGJ g==; X-CSE-ConnectionGUID: rfg8cRpKSAGHum8J/qANzw== X-CSE-MsgGUID: EVibgrO0SQmbqFr/QsvwZA== X-IronPort-AV: E=McAfee;i="6700,10204,11391"; a="44854980" X-IronPort-AV: E=Sophos;i="6.14,293,1736841600"; d="scan'208";a="44854980" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2025 07:15:00 -0700 X-CSE-ConnectionGUID: zJzLpc0wQJikS2o5cMJmDw== X-CSE-MsgGUID: /Wa5uHL2R9+6AED9E91N3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,293,1736841600"; d="scan'208";a="163625397" Received: from sgruszka-mobl.ger.corp.intel.com (HELO localhost) ([10.245.112.43]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2025 07:14:58 -0700 From: Stanislaw Gruszka To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Hans de Goede , Laurent Pinchart , Kieran Bingham , Sakari Ailus Subject: [PATCH v2] ipa: simple: Initialize ccmEnabled to false Date: Tue, 1 Apr 2025 16:14:55 +0200 Message-Id: <20250401141455.492231-1-stanislaw.gruszka@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" ccmEnabled variable is not initialized by default, which results in usage of CCM when the algorithm itself is not enabled and configured. The bug manifests itself as seldom reproducible corrupted video stream. Fix by initialize the variable in IPAContext class initialization list. Reviewed-by: Milan Zamazal Reviewed-by: Laurent Pinchart Fixes: ac3068655643 ("libcamera: software_isp: Track whether CCM is enabled") Signed-off-by: Stanislaw Gruszka --- v1 -> v2: - initialize on declaration - fix spelling src/ipa/simple/ipa_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h index 7dc2cd7ae828..51522720ab98 100644 --- a/src/ipa/simple/ipa_context.h +++ b/src/ipa/simple/ipa_context.h @@ -91,7 +91,7 @@ struct IPAContext { IPAActiveState activeState; FCQueue frameContexts; ControlInfoMap::Map ctrlMap; - bool ccmEnabled; + bool ccmEnabled = false; }; } /* namespace ipa::soft */