From patchwork Tue Apr 1 13:52:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 23099 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 188BBC323E for ; Tue, 1 Apr 2025 13:53:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2E2D76894F; Tue, 1 Apr 2025 15:53:05 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ekFoCxvm"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A98568947 for ; Tue, 1 Apr 2025 15:53:03 +0200 (CEST) Received: from pb-laptop.local (185.221.143.221.nat.pool.zt.hu [185.221.143.221]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 948E7741 for ; Tue, 1 Apr 2025 15:51:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1743515471; bh=Dfhz9p4vvRrul2N1cstIdvqeP3jydrzDcS6OeawoNlY=; h=From:To:Subject:Date:From; b=ekFoCxvm0VpAUEruwZIvkNx/AB/mdeQatFOMz2yDIO3BvR1mphPINbH8ss9qGEUob CIyCsekk+Z/NGvhwHQeDBGf/+k3hKdG/1UtGCGgeOhj6Bo/dh2KVNumcVjlWacAmWv hr291nRAqXHBIPAZI4F1SbBNVVFBGySlplJesuv0= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1] gstreamer: Restore `AeEnable` control Date: Tue, 1 Apr 2025 15:52:57 +0200 Message-ID: <20250401135257.754549-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Commit "gstreamer: Generate the new AEGC controls" removed the `AeEnable` control from gen-gst-controls.py. However, the patch set it was part of did not end up removing the `AeEnable` control after all. So restore it for gstreamer users. See 85cb179f289d29 ("controls: Redefine AeEnable"). Fixes: 187f2d537be5a4 ("gstreamer: Generate the new AEGC controls") Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- utils/codegen/gen-gst-controls.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py index 07af7653b..4ca76049e 100755 --- a/utils/codegen/gen-gst-controls.py +++ b/utils/codegen/gen-gst-controls.py @@ -19,7 +19,7 @@ from controls import Control exposed_controls = [ - 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode', + 'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode', 'ExposureValue', 'ExposureTime', 'ExposureTimeMode', 'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod', 'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',