From patchwork Tue Apr 1 09:33:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Gruszka X-Patchwork-Id: 23086 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 80EC2C323E for ; Tue, 1 Apr 2025 09:33:17 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AA1C868980; Tue, 1 Apr 2025 11:33:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="DxjLn+cd"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A0C9268947 for ; Tue, 1 Apr 2025 11:33:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743499994; x=1775035994; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=1MJ8GH3VO5tzN+61G4wYUtJ3/CFveBPuvdirr6mOhSk=; b=DxjLn+cdT++yjrxjD6FDBxXpkfgH827KUpe0dvlkwZkfmEK//7vN5I5+ fcUj00cbRP1qG3u0aGUo47xg4DDRU6ilgi5NRlgxGVCZt+4lCRko3EInH BRI4X2R+/7VNxWBQzVAsRazy82+MTcm/T6JtSMIUFj/YSdPJKGRVvvzks xqmRzQ9lA+zED5ycBs7ngf7xtKnY425QSIPvZRyu4Z/Dx0yfzmtk1df/1 SRbozpzy5IbUJQErpiUyrSEdZqyPojH6TNuo/BWavF9YDPjZSv5IWXYoi ktyAkF/D2GnnNv3dvKpZxv0HBQMK4Rsg4ZM6CHVSMU/A9UqnDAi/K42Gq w==; X-CSE-ConnectionGUID: X0RMQwyQRXyAaexImh3Rgw== X-CSE-MsgGUID: xg18cPe4RgmEMmWKyyKwLA== X-IronPort-AV: E=McAfee;i="6700,10204,11390"; a="32411986" X-IronPort-AV: E=Sophos;i="6.14,293,1736841600"; d="scan'208";a="32411986" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2025 02:33:13 -0700 X-CSE-ConnectionGUID: kzMyOMoRQRm1P9VwnHl5ZQ== X-CSE-MsgGUID: aiNavPtfSV+FhHo6lkfYeg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,293,1736841600"; d="scan'208";a="131193321" Received: from sgruszka-mobl.ger.corp.intel.com (HELO localhost) ([10.245.112.43]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2025 02:33:10 -0700 From: Stanislaw Gruszka To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Laurent Pinchart , Kieran Bingham , Naushir Patuck , Sakari Ailus , Hans de Goede Subject: [PATCH] ipa: simple: Initialize ccmEnabled to false Date: Tue, 1 Apr 2025 11:33:08 +0200 Message-Id: <20250401093308.475810-1-stanislaw.gruszka@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" ccmEnabled variable is not initialized by default, what result of usage of CCM when the algorithm itself is not enabled and configured. The bug manifest itself as seldom reproducible corrupted video stream. Fix by initialize the variable in IPAContext class initialization list. Fixes: ac3068655643 ("libcamera: software_isp: Track whether CCM is enabled") Signed-off-by: Stanislaw Gruszka Reviewed-by: Milan Zamazal Reviewed-by: Laurent Pinchart --- src/ipa/simple/ipa_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h index 7dc2cd7ae828..afccf557121e 100644 --- a/src/ipa/simple/ipa_context.h +++ b/src/ipa/simple/ipa_context.h @@ -82,7 +82,7 @@ struct IPAFrameContext : public FrameContext { struct IPAContext { IPAContext(unsigned int frameContextSize) - : frameContexts(frameContextSize) + : frameContexts(frameContextSize), ccmEnabled(false) { }