From patchwork Mon Mar 3 19:33:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 22913 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4BEDCBD808 for ; Mon, 3 Mar 2025 19:33:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EF8DA687EB; Mon, 3 Mar 2025 20:33:34 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="kehOY30N"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AF42568772 for ; Mon, 3 Mar 2025 20:33:33 +0100 (CET) Received: from pb-laptop.local (185.221.143.4.nat.pool.zt.hu [185.221.143.4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 12ED9122C for ; Mon, 3 Mar 2025 20:32:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1741030322; bh=jVaFuo1jBGDwkojKUOvu6MQaCATcOkDOfA+FyLTPSlQ=; h=From:To:Subject:Date:From; b=kehOY30NenAJ9/KkH2HKMeU8cPDJ2g/f5OH179FWrv2Q3aDHx+NL239jYh/klid1/ 2uoJzXfNfjriH1t1jmGOnA8AURIRGRRQTr6n1oFy1B+RiQG4i2iyZpVCwM+HilzEfF p98FdIR1nB7WDCf29x/MKWDtRyDmRN7NpVvONYFc= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1] libcamera: base: mutex: Remove unnecessary constructors Date: Mon, 3 Mar 2025 20:33:30 +0100 Message-ID: <20250303193330.785575-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The compiler defined default constructor works perfectly fine. Signed-off-by: Barnabás Pőcze Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- include/libcamera/base/mutex.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/include/libcamera/base/mutex.h b/include/libcamera/base/mutex.h index fa9a8d0dc..20ebe6fee 100644 --- a/include/libcamera/base/mutex.h +++ b/include/libcamera/base/mutex.h @@ -23,10 +23,6 @@ namespace libcamera { class LIBCAMERA_TSA_CAPABILITY("mutex") Mutex final { public: - constexpr Mutex() - { - } - void lock() LIBCAMERA_TSA_ACQUIRE() { mutex_.lock(); @@ -84,10 +80,6 @@ private: class ConditionVariable final { public: - ConditionVariable() - { - } - void notify_one() noexcept { cv_.notify_one();