From patchwork Sun Mar 2 02:09:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 22900 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F3BC6C3263 for ; Sun, 2 Mar 2025 02:09:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 99D1B6871A; Sun, 2 Mar 2025 03:09:23 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ly736yeI"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C977861833 for ; Sun, 2 Mar 2025 03:09:21 +0100 (CET) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 37E5F670; Sun, 2 Mar 2025 03:07:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1740881271; bh=Bd4sYTFf0HltRgeOnggFK85C78uxmjFfSBapEZesn1M=; h=From:To:Cc:Subject:Date:From; b=ly736yeIjXd85VomBNQUKJyhcAKJS2XhDhqzZSoWUUJIfAXxdt+YEAUBRxKqaQiFE VCad4vuGvcK5z0N2DMsLlq+73vKX5+QkxTqV5adj7x1n8B+L6q+nKtpsNr9tPO6wfm 0SxzY+UpiMbY/rV1fwp3H7zrmXgtwlrQX+3rF3IY= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [PATCH] libcamera: base: log: Fix uninitialized variable warning Date: Sun, 2 Mar 2025 04:09:03 +0200 Message-ID: <20250302020903.24077-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.45.3 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" gcc 13.3.0, cross-compiling from amd64 to arm64, warns about a possibly uninitialized variable in Logger::parseLogLevel(): src/libcamera/base/log.cpp: In static member function ‘static libcamera::LogSeverity libcamera::Logger::parseLogLevel(std::string_view)’: ../../src/libcamera/base/log.cpp:694:55: error: ‘severity’ may be used uninitialized [-Werror=maybe-uninitialized] 694 | if (ec != std::errc() || *end != '\0' || severity > LogFatal) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ src/libcamera/base/log.cpp:690:22: note: ‘severity’ was declared here 690 | unsigned int severity; | ^~~~~~~~ This appears to be a false positive, as the std::from_chars() function should set severity value when it returns without an error. Still, the warning is easy to solve, so fix it by initializing the severity variable. Fixes: 8fa119e0b50f ("libcamera: base: log: Use `std::from_chars()`") Signed-off-by: Laurent Pinchart Acked-by: Kieran Bingham --- src/libcamera/base/log.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) base-commit: c0a58b97989f7d529f1469b2c2f8705ff55d3af4 diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp index 6a040b59290a..8bf3e1daa9c6 100644 --- a/src/libcamera/base/log.cpp +++ b/src/libcamera/base/log.cpp @@ -687,14 +687,13 @@ LogSeverity Logger::parseLogLevel(std::string_view level) "FATAL", }; - unsigned int severity; + unsigned int severity = LogInvalid; if (std::isdigit(level[0])) { auto [end, ec] = std::from_chars(level.data(), level.data() + level.size(), severity); if (ec != std::errc() || *end != '\0' || severity > LogFatal) severity = LogInvalid; } else { - severity = LogInvalid; for (unsigned int i = 0; i < std::size(names); ++i) { if (names[i] == level) { severity = i;