From patchwork Wed Feb 26 00:55:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 22879 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EDB48BF415 for ; Wed, 26 Feb 2025 00:56:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C1CBF6873F; Wed, 26 Feb 2025 01:56:02 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="GtzTt9Iq"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BC9C868735 for ; Wed, 26 Feb 2025 01:56:00 +0100 (CET) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 18E41502 for ; Wed, 26 Feb 2025 01:54:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1740531273; bh=bdhjXQ38vCT/FACh0Vq7iqkqzRSNR8fIkt0yVgs5RPw=; h=From:To:Subject:Date:From; b=GtzTt9IqniraDVp67QESc/7Kya78yc3cGvTixNB59T8a5D2B0JbmShvEe9lAAsoDZ CAjzIv1yScahYB4EsibyvxkvbrC8CrFZJSH9eGqlT3CFsIH435iKeKzICG0uS/SNOj ybCif4tCvRetNn3ibABGLbXoP1HgDmYBqePsfsRg= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH] libcamera: base: signal: Drop pre-C++17 support Date: Wed, 26 Feb 2025 02:55:41 +0200 Message-ID: <20250226005541.30200-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.45.3 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The libcamera public API requires C++17, ddddrop support for older standards. Signed-off-by: Laurent Pinchart Reviewed-by: Paul Elder Reviewed-by: Kieran Bingham --- include/libcamera/base/signal.h | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) base-commit: 33ce463a46c44f874fdbc3e484bee730e7b251a3 -- Regards, Laurent Pinchart diff --git a/include/libcamera/base/signal.h b/include/libcamera/base/signal.h index bbff1495ac75..ed1d81ea5c98 100644 --- a/include/libcamera/base/signal.h +++ b/include/libcamera/base/signal.h @@ -63,11 +63,8 @@ public: #ifndef __DOXYGEN__ template::value -#if __cplusplus >= 201703L - && std::is_invocable_v -#endif - > * = nullptr> + std::enable_if_t::value && + std::is_invocable_v> * = nullptr> void connect(T *obj, Func func, ConnectionType type = ConnectionTypeAuto) { Object *object = static_cast(obj); @@ -75,11 +72,8 @@ public: } template::value -#if __cplusplus >= 201703L - && std::is_invocable_v -#endif - > * = nullptr> + std::enable_if_t::value && + std::is_invocable_v> * = nullptr> #else template #endif