From patchwork Tue Feb 25 15:28:06 2025
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Milan Zamazal <mzamazal@redhat.com>
X-Patchwork-Id: 22863
Return-Path: <libcamera-devel-bounces@lists.libcamera.org>
X-Original-To: parsemail@patchwork.libcamera.org
Delivered-To: parsemail@patchwork.libcamera.org
Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com
	[92.243.16.209])
	by patchwork.libcamera.org (Postfix) with ESMTPS id 64E48BDB1C
	for <parsemail@patchwork.libcamera.org>;
	Tue, 25 Feb 2025 15:28:19 +0000 (UTC)
Received: from lancelot.ideasonboard.com (localhost [IPv6:::1])
	by lancelot.ideasonboard.com (Postfix) with ESMTP id 56D9E6871E;
	Tue, 25 Feb 2025 16:28:18 +0100 (CET)
Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key;
	unprotected) header.d=redhat.com header.i=@redhat.com
	header.b="ePfMUicS"; dkim-atps=neutral
Received: from us-smtp-delivery-124.mimecast.com
	(us-smtp-delivery-124.mimecast.com [170.10.133.124])
	by lancelot.ideasonboard.com (Postfix) with ESMTPS id AF1DC68715
	for <libcamera-devel@lists.libcamera.org>;
	Tue, 25 Feb 2025 16:28:16 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1740497295;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	content-transfer-encoding:content-transfer-encoding;
	bh=3mU4vw0/wcfdUiX7GF64B2URoYAx6+QKAnUfWjqUjQc=;
	b=ePfMUicSzG8Gcr6rrB4TN7dIMLgNWtegd/Vf9x6UU2v5kofNz9T9NAU48p9z3nmfz1F5ik
	6Mi9ZgHkiEdJOoJgBPYez0lZbIzWRi7vKtX+4ml29EoX6Q83uG5pb2P3kuYaAzU0nmMkeT
	DzBK9ybek3zxRyHKfPEtnX4nR3PcI5Q=
Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com
	(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])
	by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,
	cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-qgxUkfRoNEOz3F_G9ATmAw-1;
	Tue, 25 Feb 2025 10:28:11 -0500
X-MC-Unique: qgxUkfRoNEOz3F_G9ATmAw-1
X-Mimecast-MFC-AGG-ID: qgxUkfRoNEOz3F_G9ATmAw_1740497291
Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com
	(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com
	[10.30.177.40])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	key-exchange X25519 server-signature RSA-PSS (2048 bits)
	server-digest SHA256) (No client certificate requested)
	by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)
	with ESMTPS id DD6AF180087F; Tue, 25 Feb 2025 15:28:10 +0000 (UTC)
Received: from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.119])
	by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)
	with ESMTP id 54E4119560AA; Tue, 25 Feb 2025 15:28:09 +0000 (UTC)
From: Milan Zamazal <mzamazal@redhat.com>
To: libcamera-devel@lists.libcamera.org
Cc: Milan Zamazal <mzamazal@redhat.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: [PATCH] libcamera: formatting: Avoid spaces in for loops without
	expression
Date: Tue, 25 Feb 2025 16:28:06 +0100
Message-ID: <20250225152806.22705-1-mzamazal@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40
X-Mimecast-Spam-Score: 0
X-Mimecast-MFC-PROC-ID: FLzGC54NGzZg_8vfgtMVpY2hNihwDr1lyX6FhZhs5NU_1740497291
X-Mimecast-Originator: redhat.com
content-type: text/plain; charset="US-ASCII"; x-default=true
X-BeenThere: libcamera-devel@lists.libcamera.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <libcamera-devel.lists.libcamera.org>
List-Unsubscribe: <https://lists.libcamera.org/options/libcamera-devel>,
	<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>
List-Archive: <https://lists.libcamera.org/pipermail/libcamera-devel/>
List-Post: <mailto:libcamera-devel@lists.libcamera.org>
List-Help: <mailto:libcamera-devel-request@lists.libcamera.org?subject=help>
List-Subscribe: <https://lists.libcamera.org/listinfo/libcamera-devel>,
	<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>
Errors-To: libcamera-devel-bounces@lists.libcamera.org
Sender: "libcamera-devel" <libcamera-devel-bounces@lists.libcamera.org>

The clang formatter removes spaces in places of empty expressions in for
loops.  For example, it changes

  for (init; condition; )

to

  for (init; condition;)

libcamera currently uses both the styles and we should use only one of
them for consistency.  Since there is apparently no option to override
the formatter behavior (see
https://clang.llvm.org/docs/ClangFormatStyleOptions.html), let's remove
the extra spaces to make the formatter happy.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/apps/common/options.cpp        | 2 +-
 src/apps/qcam/format_converter.cpp | 2 +-
 src/libcamera/base/object.cpp      | 2 +-
 src/libcamera/base/signal.cpp      | 2 +-
 src/libcamera/base/thread.cpp      | 2 +-
 src/libcamera/process.cpp          | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/apps/common/options.cpp b/src/apps/common/options.cpp
index ece268d0..cae193cc 100644
--- a/src/apps/common/options.cpp
+++ b/src/apps/common/options.cpp
@@ -1040,7 +1040,7 @@ void OptionsParser::usageOptions(const std::list<Option> &options,
 
 		std::cerr << std::setw(indent) << argument;
 
-		for (const char *help = option.help, *end = help; end; ) {
+		for (const char *help = option.help, *end = help; end;) {
 			end = strchr(help, '\n');
 			if (end) {
 				std::cerr << std::string(help, end - help + 1);
diff --git a/src/apps/qcam/format_converter.cpp b/src/apps/qcam/format_converter.cpp
index 32123493..b025a3c7 100644
--- a/src/apps/qcam/format_converter.cpp
+++ b/src/apps/qcam/format_converter.cpp
@@ -249,7 +249,7 @@ void FormatConverter::convertYUVPacked(const Image *srcImage, unsigned char *dst
 	dst_stride = width_ * 4;
 
 	for (src_y = 0, dst_y = 0; dst_y < height_; src_y++, dst_y++) {
-		for (src_x = 0, dst_x = 0; dst_x < width_; ) {
+		for (src_x = 0, dst_x = 0; dst_x < width_;) {
 			cb = src[src_y * src_stride + src_x * 4 + cb_pos_];
 			cr = src[src_y * src_stride + src_x * 4 + cr_pos];
 
diff --git a/src/libcamera/base/object.cpp b/src/libcamera/base/object.cpp
index 745d2565..37d133cc 100644
--- a/src/libcamera/base/object.cpp
+++ b/src/libcamera/base/object.cpp
@@ -350,7 +350,7 @@ void Object::connect(SignalBase *signal)
 
 void Object::disconnect(SignalBase *signal)
 {
-	for (auto iter = signals_.begin(); iter != signals_.end(); ) {
+	for (auto iter = signals_.begin(); iter != signals_.end();) {
 		if (*iter == signal)
 			iter = signals_.erase(iter);
 		else
diff --git a/src/libcamera/base/signal.cpp b/src/libcamera/base/signal.cpp
index b782e050..7876a21d 100644
--- a/src/libcamera/base/signal.cpp
+++ b/src/libcamera/base/signal.cpp
@@ -49,7 +49,7 @@ void SignalBase::disconnect(std::function<bool(SlotList::iterator &)> match)
 {
 	MutexLocker locker(signalsLock);
 
-	for (auto iter = slots_.begin(); iter != slots_.end(); ) {
+	for (auto iter = slots_.begin(); iter != slots_.end();) {
 		if (match(iter)) {
 			Object *object = (*iter)->object();
 			if (object)
diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp
index 319bfda9..646ad3cb 100644
--- a/src/libcamera/base/thread.cpp
+++ b/src/libcamera/base/thread.cpp
@@ -657,7 +657,7 @@ void Thread::dispatchMessages(Message::Type type)
 	 * the outer calls.
 	 */
 	if (!--data_->messages_.recursion_) {
-		for (auto iter = messages.begin(); iter != messages.end(); ) {
+		for (auto iter = messages.begin(); iter != messages.end();) {
 			if (!*iter)
 				iter = messages.erase(iter);
 			else
diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp
index bc9833f4..68fad327 100644
--- a/src/libcamera/process.cpp
+++ b/src/libcamera/process.cpp
@@ -75,7 +75,7 @@ void ProcessManager::sighandler()
 		return;
 	}
 
-	for (auto it = processes_.begin(); it != processes_.end(); ) {
+	for (auto it = processes_.begin(); it != processes_.end();) {
 		Process *process = *it;
 
 		int wstatus;