From patchwork Fri Feb 21 13:57:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 22821 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 17A9BBDC71 for ; Fri, 21 Feb 2025 13:58:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1570B686A7; Fri, 21 Feb 2025 14:58:44 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Ne4gHGx4"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 673B261857 for ; Fri, 21 Feb 2025 14:58:42 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:4117:4b18:d9c3:804d]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CA6DD7E0; Fri, 21 Feb 2025 14:57:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1740146237; bh=J0AZsBhALWGroEsHsGW6pHzUReoDlTEJKqLIktrX8Gc=; h=From:To:Cc:Subject:Date:From; b=Ne4gHGx4z1Ymg3u6g+wVt1PnyO/9R+HxifEcajL/tnuehS8c2kL2ct1AHpp/M5Jgq ytMyjUSqVtNX+LEh4TOyQ8uqRYwWPCCNyLINvh9Mjue9dymKLlNCVxIZ52HuigxNSf EY59x7yYwoAi9/B2NHVKwHSCBxoQHn6NuDD/jIdU= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH] libcamera: pipeline: Fix LIBCAMERA__TUNING_FILE handling Date: Fri, 21 Feb 2025 14:57:02 +0100 Message-ID: <20250221135836.450451-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In f5da05ed03ee ("libcamera: pipeline: Move tuning file override handling to IPAProxy") a incorrect comparison slipped through. That broke the handling of LIBCAMERA__TUNING_FILE. Fix that. Fixes: f5da05ed03ee ("libcamera: pipeline: Move tuning file override handling to IPAProxy") Signed-off-by: Stefan Klug Reviewed-by: Laurent Pinchart --- This was merged 4 weeks ago. Unbelievable we didn't notice earlier :-/ Best regards, Stefan --- src/libcamera/ipa_proxy.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp index 25f772a41bf8..9907b9615ec7 100644 --- a/src/libcamera/ipa_proxy.cpp +++ b/src/libcamera/ipa_proxy.cpp @@ -115,7 +115,7 @@ std::string IPAProxy::configurationFile(const std::string &name, ipaEnvName = "LIBCAMERA_" + ipaEnvName + "_TUNING_FILE"; char const *configFromEnv = utils::secure_getenv(ipaEnvName.c_str()); - if (configFromEnv && *configFromEnv == '\0') + if (configFromEnv && *configFromEnv != '\0') return { configFromEnv }; struct stat statbuf;