From patchwork Thu Feb 13 19:35:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 22780 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 17775C3272 for ; Thu, 13 Feb 2025 19:36:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2B44468639; Thu, 13 Feb 2025 20:36:43 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DOm2Mftq"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 17B936185F for ; Thu, 13 Feb 2025 20:36:41 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:cb40:22fb:439f:306b]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C3ED6AF; Thu, 13 Feb 2025 20:35:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1739475322; bh=w5vp/zv4lL8pW5FHqRLxef9biB6EV4W3RPB/Xwub3gs=; h=From:To:Cc:Subject:Date:From; b=DOm2Mftq3x8Y69IWvHoWk2az23QpcwZCGGtyF6pIwjIDwjL5cgF1KGhEFstA7rFif SSjkLBh9mnOrOvJS4mIqjnaKYCi/aaewriYV3jttGGkve6w+rtKbaPJ+/nR0JLN7Ng KoUJxhUdBDb6yynBpdbhARvS1RkjQgbejQsVJ9L0= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH] ipa: rkisp1: algorithms: awb: Fix AWB means vector order in RGB mode Date: Thu, 13 Feb 2025 20:35:56 +0100 Message-ID: <20250213193635.114097-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Fix the order of the rgbMeans vector that got broken accidentally during refactoring. As there is currently no way to enable rgb mode at runtime it went unnoticed. Fixes: 29892f1c56c6 ("ipa: libipa: colour: Use the RGB class to model RGB values") Signed-off-by: Stefan Klug Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/ipa/rkisp1/algorithms/awb.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp index cffaa06a22c1..16e829469313 100644 --- a/src/ipa/rkisp1/algorithms/awb.cpp +++ b/src/ipa/rkisp1/algorithms/awb.cpp @@ -245,8 +245,8 @@ void Awb::process(IPAContext &context, if (rgbMode_) { rgbMeans = {{ - static_cast(awb->awb_mean[0].mean_y_or_g), static_cast(awb->awb_mean[0].mean_cr_or_r), + static_cast(awb->awb_mean[0].mean_y_or_g), static_cast(awb->awb_mean[0].mean_cb_or_b) }}; } else {