From patchwork Thu Dec 19 00:59:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 22404 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BE747C32FE for ; Thu, 19 Dec 2024 01:00:05 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E76F96845C; Thu, 19 Dec 2024 02:00:04 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="XXownAI/"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 684F7680B3 for ; Thu, 19 Dec 2024 02:00:03 +0100 (CET) Received: from charm.tail69b4.ts.net (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5057A163; Thu, 19 Dec 2024 01:59:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1734569964; bh=fcE6lHvqdPG0Wdlx7MLI2FypgzV0f7M1zn0luKSYwj0=; h=From:To:Cc:Subject:Date:From; b=XXownAI/ncQN+BK8XcZ/o3zPYyZf+YdgK8f5w20U5IAZdQnXTE/xtQbSjLGiqihC8 NADx6oIg4QuP+XC7TDDvv1vMRxkjnJSWnS4pBjUsj88rOMqgh5Fon3lZgTptFLbJ4q 9+dBKYX7Tialp05yWYkWKL137gw5VouzQNTdaOY8= From: Kieran Bingham To: libcamera devel Cc: bryan.odonoghue@linaro.org, Kieran Bingham Subject: [PATCH] libcamera: camera_sensor_properties: ov5675: Set correct delays Date: Thu, 19 Dec 2024 00:59:58 +0000 Message-ID: <20241219005958.16856-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The OV5675 uses different delays for gain and exposure than are configured in the default sensorDelays utilised by the CameraSensorLegacy. Empirical testing using a Lenovo X13s shows that the exposure delay is only a single frame, and the current setting of 2 frame delay produces exceedingly frequent oscillations in the image exposure. Update the OV5675 sensor delays table accordingly. Signed-off-by: Kieran Bingham --- src/libcamera/sensor/camera_sensor_properties.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp index bd1fc86977ce..813878386a35 100644 --- a/src/libcamera/sensor/camera_sensor_properties.cpp +++ b/src/libcamera/sensor/camera_sensor_properties.cpp @@ -360,7 +360,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen { controls::draft::TestPatternModeOff, 0 }, { controls::draft::TestPatternModeColorBars, 1 }, }, - .sensorDelays = { }, + .sensorDelays = { + .exposureDelay = 1, + .gainDelay = 1, + .vblankDelay = 2, + .hblankDelay = 2 + }, } }, { "ov5693", { .unitCellSize = { 1400, 1400 },