From patchwork Mon Dec 9 10:47:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 22257 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9AE2FBD80A for ; Mon, 9 Dec 2024 10:47:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 947F667E5F; Mon, 9 Dec 2024 11:47:35 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="H/vaJExf"; dkim-atps=neutral Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D442E618AE for ; Mon, 9 Dec 2024 11:47:33 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-434a7cef2e3so3551645e9.1 for ; Mon, 09 Dec 2024 02:47:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1733741253; x=1734346053; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=w5gTjakyt0xnKmfCUBfHdf3arb8cxmqirdSc9BfMuag=; b=H/vaJExfQFO+E2QmOIki470ru9NRe2Pn8xfuEc8dwYAM9k/0FdBYgm5EiWShkLyI7T ua6FNnLmk0JTapWTjzEjaK58wguWvXDO7+oP83a/n0LdiowRuKIQVLuWQe9hNdTnzUUo QylzZGoWDrTnWectKFifSA8Z/3Pz0g/2HFvkuwEJanBAZNo9/5HCNvQpebcCnMp+9xzF 8zaajJtgjfLYfKE9ydHM3xNToxjOHb8P4jqXezxTMr/1oO9rbkQ80ltg7Hb7gmzvbDgt cfuNjOFDDxLs6YkmGswjTuuiDPszlNDpQy9P9UJVOszQiotQconbG//gXZcbFWMDR5o+ 4FyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733741253; x=1734346053; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w5gTjakyt0xnKmfCUBfHdf3arb8cxmqirdSc9BfMuag=; b=bsmEXC0C2wjtEtuzwBdQA1FDAyC4gQnVkRcp5VfIFghXRqXtVEwC/4gEtzMSNrp+zP ux/ydz3+hk+51S2N10PU7r0LVIgNdBveRzYwNYIeWROsFawByWY56D+NQ7rQ832UMyWU XJhCtbwQ+/Alp10z1z0q9aF0FYIVw8qzYtH0WlFw2wUY/CuMnUHxOJtHtEODiugptEaE PS/wT7cGaa57LyTo8H5/2KaUWsUzWj/4l2l1h/KTR+sg0nWXivHAKHwC4QWDONjMUDh4 K6Nch40q93I9sQ7+6L/MkOHoB7FtZxKB+tMv2qz/EI/FxLsd16ZL38JIwu31cLpLWc15 yspg== X-Gm-Message-State: AOJu0YxySMiBGypgUgsn+Ybu4P6VmtAWB57P5xOhhmHu2VcHXU1/Y0xT bumTmaBtlXikH7VQG/dTZF66xd1mHuuh5hNV/rDk4AXYJKmIsCK5kfbmIPFPSqV1bXK3Tr5sLMP I X-Gm-Gg: ASbGncs/gV0mcYjij2TvpEUrnCTbQZumPl07pni9He+OuF7cKHPL5ZXMBhmIyoFpdix aSXGYgHBwPwPB+weE7mwL6iDUP/JsrLOxfSMFc473hr4jCseWgRDLXPXnq9B9Y/B24BBVX/lcEf MXw7TxIxj968C/oCO55jg7UWJx1mF8ko8CeG2dr91ila2qrclFgpEFSJpcYB0oxUsrXen5ppws0 jJ5fH4HF1mL781B9Wx0mPEnzTIrIg0ljKtU4VZ8O6XMxkJrZsR7INuQdMK3W3An3h3w8w== X-Google-Smtp-Source: AGHT+IFj3FBXgWuQOPtw/cQ5E+RHhplvrYEHS6m1ZzLPcjLw5ncjrI9Fd2zyonk+laPfhbBpb1RQzw== X-Received: by 2002:a05:600c:3c97:b0:42c:bfd6:9d2f with SMTP id 5b1f17b1804b1-434ddea311bmr38149875e9.1.1733741253083; Mon, 09 Dec 2024 02:47:33 -0800 (PST) Received: from NAUSH-P-DELL.pitowers.org ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434fb066874sm20723345e9.32.2024.12.09.02.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 02:47:32 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: dave.stevenson@raspberrypi.com, Naushir Patuck Subject: [PATCH] ipa: rpi: Fix wrong frame integration difference value for OV9281 Date: Mon, 9 Dec 2024 10:47:23 +0000 Message-ID: <20241209104727.520859-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The frameIntegrationDiff value should be 25, otherwise we see invalid frames when integration times are set to large values. Signed-off-by: Naushir Patuck Reviewed-by: Laurent Pinchart Tested-by: Dave Stevenson Reviewed-by: Kieran Bingham --- src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp index a65c8ac08c1c..96f7fff499f5 100644 --- a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp +++ b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp @@ -25,7 +25,7 @@ private: * Smallest difference between the frame length and integration time, * in units of lines. */ - static constexpr int frameIntegrationDiff = 4; + static constexpr int frameIntegrationDiff = 25; }; /*